From:   Nick Alcock <nick.alcock@oracle.com>
To:     mcgrof@kernel.org
Cc:     linux-modules@vger.kernel.org, linux-kernel@vger.kernel.org,
        linux-pci@vger.kernel.org
Subject: [PATCH 4/8] kbuild, PCI: endpoint: comment out MODULE_LICENSE in non-modules
Date:   Fri, 10 Feb 2023 16:47:45 +0000
Message-Id: <20230210164749.368998-5-nick.alcock@oracle.com>
In-Reply-To: <20230210164749.368998-1-nick.alcock@oracle.com>
References: <20230210164749.368998-1-nick.alcock@oracle.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?c9qBGion0x5Kdt7GKnoA3qEVf+E06ZOD4LVEF9HrIBzlIR4i0RAHKWZVKZMd?=
 =?us-ascii?Q?C1gqP3WXOuUW6s4HR76M9GKxngtnMnl2j9vxLJlUOPHEKkDXWKgGYUK6+YMR?=
 =?us-ascii?Q?Imll53YQXxSfCoAo6tAcYwJ/l8A5rlRUO/Oz2Pw6Ey2skF73blkZWwjrHQrc?=
 =?us-ascii?Q?Ga85a4Dd/CJhKKxyVbRzCWwPaRBNo8Uc5SN/B9ej75vkGleIiy80WZd1//W+?=
 =?us-ascii?Q?pIw1FGFwRsRFDJZOiivZiA9yOq3Imjg2VQOUipI45nCDWoh/kevyh9xZ60Al?=
 =?us-ascii?Q?f83Fxz1M0fmxRPDTc7niTVROv9HvT8v3RHwwcLtqLbnDl7yZL5nvxneHlT8W?=
 =?us-ascii?Q?6JT4Jmqy7jxTMyUzQqzgflbUQhB0LEUoi5XdwWZQEmFdRffZdMnF59tSPCQL?=
 =?us-ascii?Q?21PQcl8oUtGL+P9NOxDQcLLlxY9nl0YThJ9vbf1W/CfSvTwAMWedc3TGQYJi?=
 =?us-ascii?Q?swCNX+7Kl24SwWPd8cXOIZHBQVrZjwqp9sdnykL1dcktENlJ7OP5pnwSClYA?=
 =?us-ascii?Q?gJXFCHD5CgrfOl1cmsnGjeXrM16DcSrZKkLoHI91BBNBT/nOzOFkb0qdHw8I?=
 =?us-ascii?Q?CbVEPkF57EEJgGcm507NX5Vpme3ywIb3eCSQrW0GA+slwCt7SWPzBIffqZaw?=
 =?us-ascii?Q?dF9m4eCy6r0zDJWb5TZ3tXNXXtQtwmmFWV4gkSx4BMzGrdX5ihGrUqT9rJA8?=
 =?us-ascii?Q?JR0m8eUwZRVLdqgzOBKj7dLVyrU2qHUoC8DJKI3cUstEntFwspSzGlBODslE?=
 =?us-ascii?Q?v7yhkoe7jbU/s3hbVNE8afVJYiKi6iy8r40kXEx3/L+wyEfn8xOw+fx606Kz?=
 =?us-ascii?Q?UpB4OnfoYs3pCUyvqnsCZm6AAqs6vCDCUALP9Ta7zSayZprnApeaGJ6f6x4z?=
 =?us-ascii?Q?953glCxwYGub9Ow6VO5nHeN7+pbQrGuOKdh/yo3847988yz0u1IR/Qcj8mvc?=
 =?us-ascii?Q?Yp3UPgL3UUryQlIo95XXR6dd/HkVbN8Eflx4yfBnHdXFwDvyyOBNHsFUQLed?=
 =?us-ascii?Q?65taz+XgDYj9H5IyUH1nrjzVELTU5rEjcHJTFz92V4PQf6hZzDNqmU3bpqwp?=
 =?us-ascii?Q?BD5+dTe739enjJiUaexkHFC2VWzuryxdmF8P//6H86ZrPObzBDF1zGUE+UDY?=
 =?us-ascii?Q?a1myekqJYa4m/yUSMxneLRGXNigy+vH4w7qC04yZyoMmqyij6rQIdFx5PVPr?=
 =?us-ascii?Q?0cKpi+YMuxaZCWvRSzozKeCy69nJSCsg18smh9xR898BKhwy+m8I7Y8IT7MN?=
 =?us-ascii?Q?umbMO6NmtSngD2mv25RgPDiZGWf/62UOGDQfEp48tlu+lJT0FHawEI1LU5R0?=
 =?us-ascii?Q?bhTI1aJFwtkvCY3tfDjFRCxOuFohX7aLN3feltCdlqO1z7slFKvX4tX9DMve?=
 =?us-ascii?Q?QgE4sKYd2jONl15y6ZlEyWVVL033ra1LlVfq0qDh3DvTO/+3yZxHMeurgZvv?=
 =?us-ascii?Q?uHdec9PePsSlp1Enb9nIoW9fLCFotN3/xpImjZA/J7DzZDJGchAxhRQTdMS3?=
 =?us-ascii?Q?TQA9UhibNGre5niqXH6vfmaHhYCTcnV7rEw5iR+fIwo6zgMThRKbua/y8qVf?=
 =?us-ascii?Q?IlgFaqw64KVWkV6VFo1Wm/OwIrh5W0uz1y3H4beVu2cmk8KfHtqUtz3z4jbw?=
 =?us-ascii?Q?4Q=3D=3D?=
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: 42jqdQ7cL4HiL+RQZsdUrr1JZ0MtoP5Ox+UOZlOF2oDa2gyjhx/C9PvSOY7nCptJuSnZIrj/wefLhsw9z/jn30nw7mCQrzCGQIOPMJEPL451k1akInXZnB19ddak1oMbbRakFyiMKYfdFH7T4IpfSZqlFrkyI34Wqa6K9CCKY9IVGz72fCHY/24U3xiqvmWZQ5gFBp2KHXQotKjNbz9JCM7tP3b+L00gIhIgHgCVjkOcRUrOl5Y+3dJWORXFBryWGWLb5XWRc/WYsYzfTn4t1zOVj+qhw5CC295oE2GtLxryGFPV+qptoaib/dw5Nq57bdqtCAS3OxhC3cbv8MVl/UlbTFTEReETr/t1v6hbvJaZvL+OHoBXPUShDBHUtHNZz4pZ+GUx1jo+qqNa6bkHTykM7zAdspgIriIG6suju9tzB+n2MO01MC0C6zU4MBQl2E2oebDeuWqhdr4hMKyEIGu/HmJHFOdkCKiZs2cDw2o26mqdOLt8JIp+elirP/eYRRMDTWIzhQyRscdIoCgEOINJM2teZboZWBgf2lRTbTUZ83BZTsNMxfXF0t2s3XCDS74F4EoTuNJJ/Hme51fHyKP0zQi5Q62dSbN/WwXHTG93XpksCVH8h3OCrk3tkPGOcC1O2G0cduvllxYRZREhVn/6V20aw0UQQwhp2oPa7wlqyMMEQHUKu69PgNsAJqgZF8aEdqGdNkmrKAYu2jcIMkt88jOGbYVcs+wrKzLOP1aZ8VgPmzZdj7L6XX9cEQPkLlwW/cyMT6+jPO5yj5iKtINSLhoLIhXs39u0RP9lczI=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: b93cfa16-e179-4c9b-f020-08db0b8e0c0b
X-MS-Exchange-CrossTenant-AuthSource: DS0PR10MB6798.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Feb 2023 17:41:31.9834
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: dd+2GDbtQSSV5/4vfizdqfTG3kBTKigi0DA77MiXu+cohylBigJtGfjHAWXy2xgBKpGXjG1B+aO4KqXuj5Qwyw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS0PR10MB6775
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.219,Aquarius:18.0.930,Hydra:6.0.562,FMLib:17.11.170.22
 definitions=2023-02-10_12,2023-02-09_03,2023-02-09_01
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 bulkscore=0
 malwarescore=0 mlxscore=0 mlxlogscore=999 adultscore=0 spamscore=0
 phishscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2212070000 definitions=main-2302100147
X-Proofpoint-GUID: 2it0bOGJeKAr2lMqHos5J8w6NJA7ABAS
X-Proofpoint-ORIG-GUID: 2it0bOGJeKAr2lMqHos5J8w6NJA7ABAS
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Since commit 8b41fc4454e ("kbuild: create modules.builtin without
Makefile.modbuiltin or tristate.conf"), MODULE_LICENSE declarations
are used to identify modules. As a consequence, uses of the macro
in non-modules will cause modprobe to misidentify their containing
object file as a module when it is not (false positives), and modprobe
might succeed rather than failing with a suitable error message.

So comment out all uses of MODULE_LICENSE that are not in real modules
(the license declaration is left in as documentation).

Signed-off-by: Nick Alcock <nick.alcock@oracle.com>
Suggested-by: Luis Chamberlain <mcgrof@kernel.org>
Cc: Luis Chamberlain <mcgrof@kernel.org>
Cc: linux-modules@vger.kernel.org
Cc: linux-kernel@vger.kernel.org
Cc: linux-pci@vger.kernel.org
---
 drivers/pci/endpoint/pci-ep-cfs.c   | 2 +-
 drivers/pci/endpoint/pci-epc-core.c | 2 +-
 drivers/pci/endpoint/pci-epc-mem.c  | 2 +-
 drivers/pci/endpoint/pci-epf-core.c | 2 +-
 4 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/drivers/pci/endpoint/pci-ep-cfs.c b/drivers/pci/endpoint/pci-ep-cfs.c
index d4850bdd837f..52cbe1a5d677 100644
--- a/drivers/pci/endpoint/pci-ep-cfs.c
+++ b/drivers/pci/endpoint/pci-ep-cfs.c
@@ -728,4 +728,4 @@ module_exit(pci_ep_cfs_exit);
 
 MODULE_DESCRIPTION("PCI EP CONFIGFS");
 MODULE_AUTHOR("Kishon Vijay Abraham I <kishon@ti.com>");
-MODULE_LICENSE("GPL v2");
+/* MODULE_LICENSE("GPL v2"); */
diff --git a/drivers/pci/endpoint/pci-epc-core.c b/drivers/pci/endpoint/pci-epc-core.c
index 2542196e8c3d..52498ac868ab 100644
--- a/drivers/pci/endpoint/pci-epc-core.c
+++ b/drivers/pci/endpoint/pci-epc-core.c
@@ -861,4 +861,4 @@ module_exit(pci_epc_exit);
 
 MODULE_DESCRIPTION("PCI EPC Library");
 MODULE_AUTHOR("Kishon Vijay Abraham I <kishon@ti.com>");
-MODULE_LICENSE("GPL v2");
+/* MODULE_LICENSE("GPL v2"); */
diff --git a/drivers/pci/endpoint/pci-epc-mem.c b/drivers/pci/endpoint/pci-epc-mem.c
index a97b56a6d2db..a3280f699f96 100644
--- a/drivers/pci/endpoint/pci-epc-mem.c
+++ b/drivers/pci/endpoint/pci-epc-mem.c
@@ -260,4 +260,4 @@ EXPORT_SYMBOL_GPL(pci_epc_mem_free_addr);
 
 MODULE_DESCRIPTION("PCI EPC Address Space Management");
 MODULE_AUTHOR("Kishon Vijay Abraham I <kishon@ti.com>");
-MODULE_LICENSE("GPL v2");
+/* MODULE_LICENSE("GPL v2"); */
diff --git a/drivers/pci/endpoint/pci-epf-core.c b/drivers/pci/endpoint/pci-epf-core.c
index 9ed556936f48..002310a3b55f 100644
--- a/drivers/pci/endpoint/pci-epf-core.c
+++ b/drivers/pci/endpoint/pci-epf-core.c
@@ -568,4 +568,4 @@ module_exit(pci_epf_exit);
 
 MODULE_DESCRIPTION("PCI EPF Library");
 MODULE_AUTHOR("Kishon Vijay Abraham I <kishon@ti.com>");
-MODULE_LICENSE("GPL v2");
+/* MODULE_LICENSE("GPL v2"); */
-- 
2.39.1.268.g9de2f9a303