From:   Nick Alcock <nick.alcock@oracle.com>
To:     mcgrof@kernel.org
Cc:     linux-modules@vger.kernel.org, linux-kernel@vger.kernel.org,
        linux-pci@vger.kernel.org
Subject: [PATCH 5/8] kbuild, PCI: hip: comment out MODULE_LICENSE in non-modules
Date:   Fri, 10 Feb 2023 16:47:46 +0000
Message-Id: <20230210164749.368998-6-nick.alcock@oracle.com>
In-Reply-To: <20230210164749.368998-1-nick.alcock@oracle.com>
References: <20230210164749.368998-1-nick.alcock@oracle.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?gXhp4GGff6Obs77jT0w7L9kuZeaQce/owXQOyu+J9O99iL14trjTaZYTTUJu?=
 =?us-ascii?Q?YrJntCtDLF6quhGDz/Jq2QkNou8gBErDijn2YuJQ8wdtk3V5rFFtZQiFA8uT?=
 =?us-ascii?Q?cgYZqI2VVnVTSYV+rVrt6HFfQmNhSTF2h7Ut8YB5jIcIo1kKIUXOiP9ixC6o?=
 =?us-ascii?Q?OibbEioF+dyPKNlV7XDG0by9tg+nUtGSQQO2u8mOPadiLdrKvQR5dJ26Bq2m?=
 =?us-ascii?Q?WbR27GmelfjUvlCjVhkq28G/ZGQB8vOM2I50+JQZvjkvwHGnbvG2FCQRqgNU?=
 =?us-ascii?Q?gNRkCXHL66sL1nej53hMHr9QpYyCBUl/ZpYpJJX1WpPB/n1lqTj81qsjk30z?=
 =?us-ascii?Q?u604MAPya7nZayhRwUTftvExfaL7XzJt1H5nn8TIJszd8lJYlBImufSWyb27?=
 =?us-ascii?Q?lxqRV/wX7N2oIcVl9DH7bCkDPUfkFh6tyBZIY9QE+WBH3kF9yyRRGyD7lbqd?=
 =?us-ascii?Q?WewQFArbsfOMkg9Gu/UoZDyM0w0m5hddNkOs0Y0SED1xdFR7GLy0p3cox6Mp?=
 =?us-ascii?Q?h99RLhrg96ajazCw94MYIGBLVPbNS1xqz2zSbONhKyYrLTVDu6KyIr3D0UiF?=
 =?us-ascii?Q?cE9RmMNMJiedFsYU3B1W/vcJuLhYYx6gsEvx57z6+lpNqBt75qFpcYbDRmwP?=
 =?us-ascii?Q?St9RHk5dhlS3O1nOXvxzpfGPmdObvwyTcP7ytNfuqHOMP0O5vBgjfgFfWSc5?=
 =?us-ascii?Q?HqcVMDZS4TXoNQoUpEwgQVY66gQJWrzVuPH5reSQW6co7FVQHUmEGkfG8fte?=
 =?us-ascii?Q?oMW5xwPfgRAD90qUxOIdK8AegumkExOgHUZtgpI93MDJOoIbaoyfoRArMk++?=
 =?us-ascii?Q?a/eOKswQl5jT+/AjvvhAk528FCHUSD7F+erB7cPWT0Qp7XK5GFNssu+FreGW?=
 =?us-ascii?Q?Lw6rFCZHNElsHt5wkeYaBv1k63LGzgYzcfmvvIBlcurvt8318ATIMyTZpWIx?=
 =?us-ascii?Q?H5m4vQxkD4jAblmm4ZUtuOWYj+okMVCpfnvzXl1Trc4jlz488vCh9462TPEt?=
 =?us-ascii?Q?NzDK1a/at9fCPTY23yy6D9nPU55BHe5bGcgoYNYyIOL4fuGu1kEg/ACOEitW?=
 =?us-ascii?Q?OfQQZQyf3vbEx/1tKgNyDbdShv4UO3i80rdkf4CJsWGUOFLVgOrss5LpikYD?=
 =?us-ascii?Q?FhAbqZev2uXBddJmGuBmwQiru4C7nHY6mrVraUfJiD4At+ee0CRxRHgIrBoJ?=
 =?us-ascii?Q?a/1VIr7CBvA+iNuUBBBYrD60LTpq9NJL4Rv9HMV4okVj5oigEv7C6rIiP1XX?=
 =?us-ascii?Q?TXvbM+TIsKF4UOH4zHVFAt9Q6sSmX4xyvyM4DDo01s6XzTVfSHe121zPcOLU?=
 =?us-ascii?Q?a7+8/olRHbAVdXcjgi96yqQFdY2vbNVJr6s2ZT+UGql/cbNMRs3fKrdtDUCf?=
 =?us-ascii?Q?sHYlgvmu3+6kt9GqUHlhzW7srv/yUV8ur4EmqVw068/w49/xAkdx9etmGVei?=
 =?us-ascii?Q?Ae1V8SOShmxD1oK9qKh5u4Y0tfnu4a777KBYSHd1ZBGa6r9YeESMJn/dix3t?=
 =?us-ascii?Q?GU8VzxKRHstVfRyEokqBT+W+OCmjALuxKRaTBg58O61e2oHm5461EFqXiD5Z?=
 =?us-ascii?Q?0tvzGWc5AcMdxPQv2d3j8z1cRnKNQZlpqrojk5yeCIrsHfDprLzF+YCQOqWt?=
 =?us-ascii?Q?LQ=3D=3D?=
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: srzofP6K/hkyC7RWc+EZRmoKWLrPxs8B2j4zAqc7et50Gp/qSSL2paSXW0kAkE1U3o6oEAAYkPe1M030XG8D5VNwmr7fKOzdychJ3HU6ns8Pd08HAxmEj2v8L1h7TlPrt2/tfozcN+PUSMxX8DXx3Rgh0d1k5JrrXdUzC0wj/eY+2bgDv8pmFqBIdcqynKJmk85Ba7DcEsVtEttWC4qjAbghPkVEaDKkUu1T5iMMB5Bwx1FL7zgVwJk9K4zs/DVlgM6vgT9fSeymYLynpSR9QW/rLkERNTGk5ID7GIKfKhAY0ImLBdHWm77WCbhS3id+GiBwHaiTmAPp0IW+T44MGZvvix/HksiKBllr68xSz9vAIb87JAWO/5NG1eZ03F3pX8G4X2EZfjDkre9ma86UdqGBcEqw980GOuxa2rHexmM0COPDF67qHcHGLnhL2cVL9Gq+76/VETBM4vFOscTLDvFC+kovyIDjzMWtXJhFIUKgQnsFiEl1LPIbKtNyt7fCay6lYVj6k/bRdmHJHpSG0iod1jenEx/LLWA8vyxAOCC7USNzB/5syjllfZ/V+PjJcioONwGTv6L4S7ae+Ha7BFr8hIgqD+Fo40J7MLsRHIlsnQkdZaq4Xav+PCvbyycc5+RNjDYqdcnRvhj7GCotdhSbiSeclYHpoH62XGhLeivtJX3Dwdyp11eWynEfCzfxh5iPuEs0NKcvmRo+rEF01TroGJgc04CEKCoB3mUg9FDEdcs85wpNuibi1T384poZl3fV64o9EWk9+NdGaTXObzD6WCvpEtuIt5S9xxCX8f0=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: f90b7bed-dc87-4d70-cbac-08db0b8f4cc7
X-MS-Exchange-CrossTenant-AuthSource: DS0PR10MB6798.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Feb 2023 17:50:30.0698
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 5Q5i5pSlwRBA3lz+kI8wm288EJnW4o8ZfgbKaLn8fZN3griWzwEkkA+Ead3NykY4hdCBdABob9azdG6P/8q70A==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR10MB6256
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.219,Aquarius:18.0.930,Hydra:6.0.562,FMLib:17.11.170.22
 definitions=2023-02-10_12,2023-02-09_03,2023-02-09_01
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 bulkscore=0 mlxlogscore=999
 malwarescore=0 adultscore=0 phishscore=0 suspectscore=0 mlxscore=0
 spamscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2212070000 definitions=main-2302100148
X-Proofpoint-GUID: JckLdBNk2fK5t7gQIokLJl1j04yW10AG
X-Proofpoint-ORIG-GUID: JckLdBNk2fK5t7gQIokLJl1j04yW10AG
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Since commit 8b41fc4454e ("kbuild: create modules.builtin without
Makefile.modbuiltin or tristate.conf"), MODULE_LICENSE declarations
are used to identify modules. As a consequence, uses of the macro
in non-modules will cause modprobe to misidentify their containing
object file as a module when it is not (false positives), and modprobe
might succeed rather than failing with a suitable error message.

So comment out all uses of MODULE_LICENSE that are not in real modules
(the license declaration is left in as documentation).

Signed-off-by: Nick Alcock <nick.alcock@oracle.com>
Suggested-by: Luis Chamberlain <mcgrof@kernel.org>
Cc: Luis Chamberlain <mcgrof@kernel.org>
Cc: linux-modules@vger.kernel.org
Cc: linux-kernel@vger.kernel.org
Cc: linux-pci@vger.kernel.org
---
 drivers/pci/controller/pcie-hisi-error.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/pci/controller/pcie-hisi-error.c b/drivers/pci/controller/pcie-hisi-error.c
index 7959c9c8d2bc..ef8f3121ed82 100644
--- a/drivers/pci/controller/pcie-hisi-error.c
+++ b/drivers/pci/controller/pcie-hisi-error.c
@@ -324,4 +324,4 @@ static struct platform_driver hisi_pcie_error_handler_driver = {
 module_platform_driver(hisi_pcie_error_handler_driver);
 
 MODULE_DESCRIPTION("HiSilicon HIP PCIe controller error handling driver");
-MODULE_LICENSE("GPL v2");
+/* MODULE_LICENSE("GPL v2"); */
-- 
2.39.1.268.g9de2f9a303