From:   Nick Alcock <nick.alcock@oracle.com>
To:     mcgrof@kernel.org
Cc:     linux-modules@vger.kernel.org, linux-kernel@vger.kernel.org,
        linux-pci@vger.kernel.org
Subject: [PATCH 6/8] kbuild,  shpchp: comment out MODULE_LICENSE in non-modules
Date:   Fri, 10 Feb 2023 16:47:47 +0000
Message-Id: <20230210164749.368998-7-nick.alcock@oracle.com>
In-Reply-To: <20230210164749.368998-1-nick.alcock@oracle.com>
References: <20230210164749.368998-1-nick.alcock@oracle.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?Q/CY7rPq3uDUqSm3TykLNPuufGgkO+CfYQGA5J0s+TXoDPXW/FWdMgdIcSEb?=
 =?us-ascii?Q?eIY7jAQduhYabKaYABlRMtd9JI85DoNG4+vFRncpIVEBsjI2fNZzpBmOyZZ4?=
 =?us-ascii?Q?7wTjDKKks5wQV8kzVSEDN/cZRnWumFgvbXVR+7RUeQzhXbk8zP/U3oy06rbD?=
 =?us-ascii?Q?QeBGwe8hWAjoCH9k534QW5lsbEYgKDkrU2M8i8h5W9A8pHGvqwI0m+EoEvfy?=
 =?us-ascii?Q?ckxyNhMcupmp5LMZMmjSDVGwKi8ojnNC9gPqUpGFJjflSWQhJPOC6wUEZyxU?=
 =?us-ascii?Q?Wz97pm1wRDq42KQ5E1axewVDRqyjWUSPiMA8mZItIBW6hzkpnHDfFsJwzxLG?=
 =?us-ascii?Q?ZCMq4whSYcxITGqDYkmn8kPl9sHPjgmLPsc1sX/0PiADQdJJCxRW+c16/YmP?=
 =?us-ascii?Q?tbQk9zXF0Lpsi3wVabIS5X+KcSo3GT6D9RG9sbkAA+EHb15/bPek2gFFYqkQ?=
 =?us-ascii?Q?pcKxMD2hus2w5OVQZ5oXhYFeO+e/FbfsZCBDnX276OUw/f71IUy+oWPYc8l3?=
 =?us-ascii?Q?UFFWprBTENgT+VAxOsDLpW/8cAFfBbVkY5/zN2YMYS9M3B0uABRQdf34Mu1l?=
 =?us-ascii?Q?BNrIEb6Tngo2nbxWsuhSv49/a3DbZKjekR2o9/Kbjya6YaDNtZhua9VYiaFI?=
 =?us-ascii?Q?Q9ybPD+q6OMpiuiFLdS7GDw/3d52pLuepMqQ4pVNF4AQf//HzOFmLrjmiAsp?=
 =?us-ascii?Q?UiEG7Ok4l6/hUpHPuajqsDtLkb2W0o38D/acc8A/8sevLqhN0wXHdyD/r3ub?=
 =?us-ascii?Q?WGwU3QAq1tf/9MAMoM1liQPaRbqFIVqZ1nPjrgnDSN1rgD76za4STck+YgGg?=
 =?us-ascii?Q?LBS/NteVZ2zikFk+RoAYmV3ck5ATcUZMN+7UclR5tZgFUhwoxLoqLaIsorTX?=
 =?us-ascii?Q?PM1IOk7MwQcJFUpyC/gCu/HTvpRY5bn1guy2RmB6pHnJ2kWSK9eyN5x4a4ns?=
 =?us-ascii?Q?IiVDHAW3G3NrBqiKHLeao0Ykr69nRKfwigrd/bGKfyCComOnfjY9ccU5qbfz?=
 =?us-ascii?Q?4tuLpv2uCKJeU9ghe2SYltitYW+gt0RaABF+vDvXFrIZdFS32aOMXp6D8zhb?=
 =?us-ascii?Q?ui7Qg6NHYHtv+SjO3ZCkrt4+oa+Y/gD5RRZzqG9Yg9so9f/fieUQXL1VwIES?=
 =?us-ascii?Q?mkWkGp8dTGL4sTOEH5/pb0T1hp03nMI2QuXwIO1wCOfNp84onvnSfllXI/mI?=
 =?us-ascii?Q?VRqpuF9Xl97emew+Q95KC2qMXXnxI2SpDkHrUCf/28gbwatbsvs7vbWQsstB?=
 =?us-ascii?Q?HbskkdbbOsONrHwLGP3RNHJZvpDVhtBb3sg0cpuOykTsW2gurJF2YbGYNu9r?=
 =?us-ascii?Q?KurVQ2j1cnXM8URExfejpY1yeAx8WZHU5PQMOaaUeNUrMoEdkLBlJ4PFb2B/?=
 =?us-ascii?Q?yl1+u0xAnQo+EOGgQX6GKVZY+Uf5tNzNXaOua5RJTDb+CD+x072p8k8v5POh?=
 =?us-ascii?Q?hJHJUn5OpXz46Gra+REIpt92xf5rsWcOhzddqrZNv9tFliJk5l978MAr6h0u?=
 =?us-ascii?Q?mzT7tLlfH8CJXaxTSOzEukfDvQFiNLT19dx8mYs0y2k1kgtoOX1ahrpIsxWQ?=
 =?us-ascii?Q?Ag+dv16TmrZjTkIKDo6/hLn4vySsluRUpoGDfcY12NCaOnZDfqEebrtOHJAd?=
 =?us-ascii?Q?uQ=3D=3D?=
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: TIiwrXXkmaagdV7bRK4lqJuI3/racIPb4pSwrvbw1EtQZk0eeJo/ka9U2hqtakt7X8G6zwMHwucL7kAf1Nrm4+LYXki5tEoM0STqX0P2tFvR9jfh1Ue38pNSUTZ5cMcDqu9EOf+x0QYaiRuwWFxDALWgR9626HDZ5TnGSzWyT7Wq8x4TYFqXxZmqTZOpk6u1H4Q5pFTRY7p0WyrL0V21yz/PSH7KSdpLtq9mTch4QLfqtzfvI2QCtTMYidtYxJg588ddLsfwBtrEEZjtAFksuDsxTDqGW3hh+Nav8HmawxOvhEjSS16k1w/hyPn2WuWDFk6CCifUB8KgOo8YT64COeAIn7UiyGbqMgmOTcOhkGNP7kOpd5o3tgnJVDSX1bDG31qVEk1wHOUk4ylSFeUJNIJTgkKhHeS4/pB4aK1n9ad2vIsnrDFgEGwLCGbWFDaQ3YnSVAzTnLV8KcJHys8pR2Z+NxpoNlLvDY8rzCcTXtD15jPEQmD9Wn+HhN1qU7G9Z0tNnGyWkiRcioW2N5eKs7VzDhpR6Fc0bqjMUVvOuEVfDqBkqPJ1oHjA0HXfwQJvCOnBpaNdEXpZV40LXNmu9+cyZ5i3JODwrR30MCMj14vvjVh3hMounA2nTplRWqAQyoGxSB5f/4JTkT+kq5ak9a7MDrHrcuj13zwfyZxHrq+12Y6vzGaYaiANPkIDeRKpI7GRnucsf2BHXcjlGN5kNdLG60pZLlciCixuFPAGJnZJ2hR5GPGZKswUJN+AAbxz+ZoJt2/0cFgRlJmKFYJ3P7+XlOF8XuSRElCpmlAqDjU=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: d77ef8ec-f52a-480c-1941-08db0b908d59
X-MS-Exchange-CrossTenant-AuthSource: DS0PR10MB6798.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Feb 2023 17:59:27.9086
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: A4QzBTRSjp8XzFJutfXUkj9BmM+HUHmq2Awjvd+jaKOgUX4ROITBu/MHSH7ZB9uRTyHALYK7qTqbO68Dv2WUtA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR10MB6543
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.219,Aquarius:18.0.930,Hydra:6.0.562,FMLib:17.11.170.22
 definitions=2023-02-10_13,2023-02-09_03,2023-02-09_01
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 bulkscore=0 phishscore=0 spamscore=0
 malwarescore=0 suspectscore=0 mlxscore=0 mlxlogscore=999 adultscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2212070000
 definitions=main-2302100150
X-Proofpoint-GUID: qHmrJN2Yn902Xu7V3lWr9ae-fnHPbzew
X-Proofpoint-ORIG-GUID: qHmrJN2Yn902Xu7V3lWr9ae-fnHPbzew
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Since commit 8b41fc4454e ("kbuild: create modules.builtin without
Makefile.modbuiltin or tristate.conf"), MODULE_LICENSE declarations
are used to identify modules. As a consequence, uses of the macro
in non-modules will cause modprobe to misidentify their containing
object file as a module when it is not (false positives), and modprobe
might succeed rather than failing with a suitable error message.

So comment out all uses of MODULE_LICENSE that are not in real modules
(the license declaration is left in as documentation).

Signed-off-by: Nick Alcock <nick.alcock@oracle.com>
Suggested-by: Luis Chamberlain <mcgrof@kernel.org>
Cc: Luis Chamberlain <mcgrof@kernel.org>
Cc: linux-modules@vger.kernel.org
Cc: linux-kernel@vger.kernel.org
Cc: linux-pci@vger.kernel.org
---
 drivers/pci/hotplug/shpchp_core.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/pci/hotplug/shpchp_core.c b/drivers/pci/hotplug/shpchp_core.c
index 53692b048301..455f247c27a2 100644
--- a/drivers/pci/hotplug/shpchp_core.c
+++ b/drivers/pci/hotplug/shpchp_core.c
@@ -32,7 +32,7 @@ int shpchp_poll_time;
 
 MODULE_AUTHOR(DRIVER_AUTHOR);
 MODULE_DESCRIPTION(DRIVER_DESC);
-MODULE_LICENSE("GPL");
+/* MODULE_LICENSE("GPL"); */
 
 module_param(shpchp_debug, bool, 0644);
 module_param(shpchp_poll_mode, bool, 0644);
-- 
2.39.1.268.g9de2f9a303