From:   Nick Alcock <nick.alcock@oracle.com>
To:     mcgrof@kernel.org
Cc:     linux-modules@vger.kernel.org, linux-kernel@vger.kernel.org,
        Shawn Guo <shawn.guo@linaro.org>,
        Philipp Zabel <p.zabel@pengutronix.de>,
        linux-pci@vger.kernel.org
Subject: [PATCH 7/8] kbuild, PCI: dwc: histb: comment out MODULE_LICENSE in non-modules
Date:   Fri, 10 Feb 2023 16:47:48 +0000
Message-Id: <20230210164749.368998-8-nick.alcock@oracle.com>
In-Reply-To: <20230210164749.368998-1-nick.alcock@oracle.com>
References: <20230210164749.368998-1-nick.alcock@oracle.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?yhETCZCSTdILZXsywPy7+3jBYiX2DWe8o4n/15i3Q9ubpaJOhkZ2yiJjIOL3?=
 =?us-ascii?Q?/W861T/lo9IeLzyiCkLhdZLaDcivKNirL53y5C0nTTQw5hzaga5+M7yd++ym?=
 =?us-ascii?Q?f7005hYopO25iOqgvn2zeGiMuRyuPjnkAn4UISMzDUy/7vm99/tkjfTlRoU+?=
 =?us-ascii?Q?0ltQKjG+lzseP7LLFtFG1r/m7KGUlTM8gSVCZdBrvlHgCGdliSiNwz8pRzYs?=
 =?us-ascii?Q?kSuiuqPWpMpOSA6gpunWg/RJ3fI81Wxk7jAwn7DZ5CYAxuKQh4ycEc53d2oA?=
 =?us-ascii?Q?47PhpE6ygLgcgne/9e3PxKPq7BERDcnyD4u0UPOqStVndFmIGlHriGqYYNt6?=
 =?us-ascii?Q?qjfk9+KbsAQBE2d1/8KPSKY1pbWwhNoqID7lUmzXw4vLFxg4GWKw4zeuTGia?=
 =?us-ascii?Q?T/1fk4i5pFRANNf9KMpvqB29jU2VSG+NDh0RbCO5JpF0gLPPmDDdIsq1Cef9?=
 =?us-ascii?Q?XCknnwicxyl8DmaCLftsZHL6v9cncyO5UTmdaEdETv7ElllvJbtTWwe1pR34?=
 =?us-ascii?Q?8voCYKc5lTB6tfstFfkV3kMuWXuj5gh6Y3Hh/UiY9UrOWmFUeQHfEPYL1CvV?=
 =?us-ascii?Q?T5OI3heq/7G37PQYBGoDKJTU+KZaeizFr9b3dH6sjonlziV4mpu1hRA4Y0aT?=
 =?us-ascii?Q?ohgsH//KFJXJlJhDj+MwgD5LvMoKfGdm6qw/gTluygUaink8FoHqAcVh9E6X?=
 =?us-ascii?Q?xhcstOlmpfg/AoHA+GV9NCbMPB9UT3tnNZV8bxyJE+7XdJ+kM6OPgFL2GZt4?=
 =?us-ascii?Q?C5lf8oc/WLAy7zYXVNsR2JWvGbAoKywEQuXnifepo1oX5I+uRwum0xFFoBrh?=
 =?us-ascii?Q?qKVd8Yrek70rNb7/RrQKyG64iVv2jqN/KTARbynQ4/uFcxqehhSjDpGjhAIS?=
 =?us-ascii?Q?MBbtaPZZJTIF0NzDzw9exhRU7N4TbpiV2laNi2rixHF18IkAsekGEo6bmTnB?=
 =?us-ascii?Q?eiNpG32bRLmn7bBmzULwWrP+rHwH6qzoibCl959A3ZCLEMiJfQFaqKKEBRLC?=
 =?us-ascii?Q?dPQ/ocWTOvxXCSOR91KtsqbbXIr9MUhKlCtx8gwqdtthZ+YTpf1xGCEM9INy?=
 =?us-ascii?Q?H4XWHdUM+r/bu7Crd1kBuOcCgEMcZP0skhFtgk6KUqrqrJESCBqwOoFzhwK5?=
 =?us-ascii?Q?c4qpNkUXAjTDAFjN7BloVU4ArWl8x/Hz2vvk/CAY0AJkmnIW1TpT9M6vbriW?=
 =?us-ascii?Q?tFbznNoupfozjqV8VyUF9RV1YA6FbzmSRjfJ1CmFd/wOAeW2T/vwZC6K5OVQ?=
 =?us-ascii?Q?Z2SmoYi5XiawFWxRXARdOikAerDcyGtyHC8KVw/wO8sCJ7quPGqcGnFD/9Lt?=
 =?us-ascii?Q?pZTSXoIZeq6RZxrNeaBqGgr6tg4Z1u1sExGvo3NgF6pDqg3iatdwcVIFnFG4?=
 =?us-ascii?Q?EjP6GfEt2WscXfT/UglTqTp56BlIRwTSKktOwXDAun5mGuJTCR0YZ0xL58Dp?=
 =?us-ascii?Q?w0Ai+nTh4CrALQ7NTc/7Giodz/fOFDc9Y4GKpE6Dat7xpdsDUqQfLgDoSa5j?=
 =?us-ascii?Q?qMakaFRAXLWVVaVrt2ecofKCriBOm/M2qTn7sgJCTrBZAj8y4dXxu7zOv/0c?=
 =?us-ascii?Q?I/+/0shl+K4ptnj7/HRHbaP8FqnRgIYYRQUSStFYqt52oQSLEO9Th0VVI04K?=
 =?us-ascii?Q?/w=3D=3D?=
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: q/HdhAZ28TdKO5qCs+mSQ6T2oZIqZ/MYehjZUCggPgeAZwZtPXXj24q3dtogAMjsV2gMGaenweuLg1GLobeWhnrUjLsz1zHhJs4u1vuwCWLPNgkhn9X/cdkgbWv/3VpAyZj4WbaziGtGW+86IQo/Rr2epIqEjZAN5E3xZ6yV8e/9sJv7jINa/UD3V6QQ1+vKYNstJTMRWvFLc9L+PGAAINUwNXISnbyI1lQsR0JKM756g4WaR0P7MOa1CsA7Q8jlsRBakOPW8qlQWdnrISsIaf8jeRabybldWiRE7RbXpsC+EDkMdYu351MqPJeekNbqANRjAMXPMdCKJy1vQDN1UwJbMmDise9Zvhg5QN6Vo+rDVOKOWIX446RKmjR8Xn9Zi/wacvJbt6fmcpibd9lBtvmoOSjQbhMCpZcLmve0b+211TTWE2HwlfUR5edIKXO7iH6302jVcScSEU3JO2v4QG+iEkNkdo1wpPkn5FOuKVflDPd8wJ8brNDT7b3P0P59eAUwDkoGoS5uEcJopKgUl3UjSEuPMNkyoPUlRxSliKjx/8Y2Vsgo1zjqR70RS6WaHlDqAfAYDc8NF9lcgrRSVwZmJXbANDj2/lsVigMtu63FcBo6I7334VbqZqe2jNprN+dcTxmKJk5+/EU20h4THFApKitYbJNBMiU4vRXR9VOboav6EhP2dHGrWlRH2SsHshXvl/SV6QmHEoI6BMbYmLcOzr6YR8r3MEkw3wURxARKr6C/2RyXDMo1q8SW8xx2Gib0ITrW4G0br4E2cRfJR037fEnCLzhjq1DOglpJv1oqv6GolPuLuQWAl0NRVhwtClTPxDG5P5HKDMClkGwZLHjgddheaB+gszoTHVMYcdk=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: f5a69e9d-6f53-4133-e517-08db0b91cdbd
X-MS-Exchange-CrossTenant-AuthSource: DS0PR10MB6798.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Feb 2023 18:08:25.4401
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Y6CqtSYeKlxGPJIkcp2hOQHpCXi20rPiBmuWJsyHEG7bmd4jb7GkbLFtb4s/kfI7d1zgL/uS5HjqENdgkLZTsQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR10MB6741
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.219,Aquarius:18.0.930,Hydra:6.0.562,FMLib:17.11.170.22
 definitions=2023-02-10_13,2023-02-09_03,2023-02-09_01
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 bulkscore=0
 malwarescore=0 mlxscore=0 mlxlogscore=999 adultscore=0 spamscore=0
 phishscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2212070000 definitions=main-2302100152
X-Proofpoint-ORIG-GUID: nKDQ2Od64x_PukIP_lCYESZjI0hclh2Q
X-Proofpoint-GUID: nKDQ2Od64x_PukIP_lCYESZjI0hclh2Q
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Since commit 8b41fc4454e ("kbuild: create modules.builtin without
Makefile.modbuiltin or tristate.conf"), MODULE_LICENSE declarations
are used to identify modules. As a consequence, uses of the macro
in non-modules will cause modprobe to misidentify their containing
object file as a module when it is not (false positives), and modprobe
might succeed rather than failing with a suitable error message.

So comment out all uses of MODULE_LICENSE that are not in real modules
(the license declaration is left in as documentation).

Signed-off-by: Nick Alcock <nick.alcock@oracle.com>
Suggested-by: Luis Chamberlain <mcgrof@kernel.org>
Cc: Luis Chamberlain <mcgrof@kernel.org>
Cc: linux-modules@vger.kernel.org
Cc: linux-kernel@vger.kernel.org
Cc: Shawn Guo <shawn.guo@linaro.org>
Cc: Philipp Zabel <p.zabel@pengutronix.de>
Cc: linux-pci@vger.kernel.org
---
 drivers/pci/controller/dwc/pcie-histb.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/pci/controller/dwc/pcie-histb.c b/drivers/pci/controller/dwc/pcie-histb.c
index 43c27812dd6d..11be36852033 100644
--- a/drivers/pci/controller/dwc/pcie-histb.c
+++ b/drivers/pci/controller/dwc/pcie-histb.c
@@ -450,4 +450,4 @@ static struct platform_driver histb_pcie_platform_driver = {
 module_platform_driver(histb_pcie_platform_driver);
 
 MODULE_DESCRIPTION("HiSilicon STB PCIe host controller driver");
-MODULE_LICENSE("GPL v2");
+/* MODULE_LICENSE("GPL v2"); */
-- 
2.39.1.268.g9de2f9a303