From:   Nick Alcock <nick.alcock@oracle.com>
To:     mcgrof@kernel.org
Cc:     linux-modules@vger.kernel.org, linux-kernel@vger.kernel.org,
        linux-pci@vger.kernel.org, linux-riscv@lists.infradead.org
Subject: [PATCH 8/8] kbuild, PCI: microchip: comment out MODULE_LICENSE in non-modules
Date:   Fri, 10 Feb 2023 16:47:49 +0000
Message-Id: <20230210164749.368998-9-nick.alcock@oracle.com>
In-Reply-To: <20230210164749.368998-1-nick.alcock@oracle.com>
References: <20230210164749.368998-1-nick.alcock@oracle.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?bK01zFtrPKAzfZjOybFdgMQ/4Q0oo7UvzVs+1SWn8clPOqp3n+WYyMAaUsBv?=
 =?us-ascii?Q?AA1yady2NtFFJjh9HhfC4C0Gtrz1LGsaSocebOEKwB43tAw2kjsnSWusvcsR?=
 =?us-ascii?Q?Qrj5nbnawNXvs4b7bEm+gvcMfkyZVAys+PmmbEHK8HMjKwToXjkYmZYTh/+I?=
 =?us-ascii?Q?b4mVd7nBMUcCrSqIsof/DxmGjqK5p6euC/vINjnfCH/yNJVf30eAPjHL4oC+?=
 =?us-ascii?Q?+h+GFUUcO6lbkQ8DBZRD9h+Vy6slwz2qQwoJAkwu9F2zkFk+tcYo2O3OCv59?=
 =?us-ascii?Q?gzvGKpJbzimV/iJqtt+UQfQj477iSk+e9xJMYRfw896peerf8eeAG4YFxa/m?=
 =?us-ascii?Q?hm3YTv1jm5XJ3DimSb+S2n5eOBw2enhKP4iAfv+l20uS7l/Oukn9G9iqVEUc?=
 =?us-ascii?Q?75K9n4muVzNyuv5YVhd9Af2+HtElsVAfAAgNzbS7+obeB+BJyszMzYtZMHhM?=
 =?us-ascii?Q?AKlB2J0KiEW1PYZB1HPPNfFYlHFHKL7VDBzvIWhT+W449eRfuA6W6KuV7FWr?=
 =?us-ascii?Q?cDdhJf/7oT+lVlu3xUZpT3dlraJu0CxREXRTi54LAi8PZMk5h5pV9Q5JodhE?=
 =?us-ascii?Q?U/w7VAiJXIA9mltLbqNkuzjOhVP03N5p+UjDV/v7wC57L/gqO+efZTijUy5x?=
 =?us-ascii?Q?yRL7dGf5OHUtIM4QEaGLgM3ER9kGgRTDm4xdJ8g8k7EVRxRCxKi9ArEBhHak?=
 =?us-ascii?Q?6RVUwyBxN6uyStsErbk6rUNuvgEV6EZc4RMOdU8bvnIjcK6TOAKwrity2vq2?=
 =?us-ascii?Q?LdtqT9Y3HL961ol0z+uEcHb4N6w0ty5daBX90yJJ3ygZyvuTuUC5Rr4X7JxJ?=
 =?us-ascii?Q?SILgg8Xlx7PDjRzYiDSgH0oc0XVOqQfWpukGMSU49rCxYYYldDBIx/aGYJQM?=
 =?us-ascii?Q?053wOAn7NKBYIBRkbPn+C5hql4u/VfXyEhtx4W8p5r7bhh//HkJB8rmkwk9h?=
 =?us-ascii?Q?NuwN3YZmOJSJ4knsuW32brUSIy8YMoCOtYHkIWvcrn4N45KOgcTMNl3+vp9p?=
 =?us-ascii?Q?FJ/Xj4Iu4tlsNlr+DAEJB9TEYGYvSMEujSjPSpBWwLKGBJkByfHW1hYA1Ld8?=
 =?us-ascii?Q?Kbi6lXSaPbMI46yINwrsCFdLSOWZkpUfP9Z1dUDS3Ud6QlVBCJ6+ZSH25zPC?=
 =?us-ascii?Q?TMqd4OCjEClBvEBEQwv8yxWPIhTW0rdktmiXbgSwpJKov+NGPkvuOCsbmbGt?=
 =?us-ascii?Q?nyTUT8BhaBYYygqx+xwPlMfgDcpyU8xU9ti95rM1Uac0cQ6Xl86Tm0TPx5Am?=
 =?us-ascii?Q?gloqFL0WGxR9dbKB3TGfWF76J1Ym5VmjFFV/O/j/++GMj4+pQpKplT3UwqB9?=
 =?us-ascii?Q?z3KGwoDxLdgcdlyZ8nKvEumUEGz+Ug8jIU+BkhxbNxN0xPpcDFYFInLxKGEL?=
 =?us-ascii?Q?5h4ZmL+lsHpjyEJlG26mHhwN8B6wEUK3EDB57qR+7/EOKmfPjEjF78yIQ4x5?=
 =?us-ascii?Q?fZ2D2DE1EUz34MeTmB1wnqx48LUGUj3WCeRsUJGtDTb5JIcFZIkiD4T4Pjc8?=
 =?us-ascii?Q?KogICXF0ujSyJjW/vq2Ftai+QztlVGPEU29j5Ip/Vou4s0JACpxgoQxAzvy/?=
 =?us-ascii?Q?9qgbQskj7B9C4AezMtIzVkGBgOJPcas30nIhNcE1roHNAnsXBveeLoRbDG4Q?=
 =?us-ascii?Q?DQ=3D=3D?=
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: b4gCc7Xs9DlvhDUjIZ6ts6XiQwA2+XFYprUQmGxMnxDrUiOLkxeNwxS3Xask8Cme/7whOcCcE/3ecKay++JQcJFrSGVxdDyZf7i1LPzM26TjWHAzd5KDu5scMVpx3DqnVQncTjTP66Av47+oiCixi3RMgtn9cfp2bQJ5CX1z8ZoTuqd53UuW5GUcff8RCzAqV3kAOKNPri3mwblHEaz/UqEEjA0NBg7Ynu1lEXIOkRoNPlgrGALaCGbtVRtNFZVRxfyQcOFQeHG6EQXySeaew4Gr7XN/HlVSWdS3oYz2gsLLIt4vjvJlXpMoe83+U9UIOzgHeVskarSorwiLUyBskj1oc4LhCNTUB3ltK0Lph/0/YDUUmahTcnIAdQq/9Mib8KAtiTwG8QuViijgoQY33/ZZ5nKFQyTSzY4HkMHlZhTJBDMIsZtAW8li5YFsnlyb9Mbtf3o4t8gY142NNMQx/6f7oVjjTYRa5Mb5eJGbtAoJHWyYrhQqw3sLUsxu7mkFi8SVesGU3KXk6tfhWTDnT4wD98WoWHOdhTdaow8wbKLWK/hc1q8pqBYVbu1r4eSk3pTrt6mUy0hw7BVykqo4ZzXJSgM7K6Rn59J+QsChGD313UmF0uLUpMAFAQ7wmJUBxfuicIIgeQsM/L3193XHJAVxWYuXF6t85WPeo/kp3zbaUXcq9os9SyKGkb8tjKHq4GQlM2Mvdsvr77Dk0BY8mYWpinQ2LNCpIRtrsPnuGUSEbE/llR5BbxfdS1cAME3+VqwshvT9H58/kGwRBfEsb/yIv4/7/ZHEoXEcilZz0Mx/TGQglHU53vDOoIApJLRBUv3Fc7G+qwLC3veh8UzarQ==
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: e41f12da-5625-4b0f-333a-08db0b930e25
X-MS-Exchange-CrossTenant-AuthSource: DS0PR10MB6798.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Feb 2023 18:17:22.9724
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: jkCvspMoaW7bpOt500tNUMHuWhCAB5yPnOwoFjz/a+MmOlgYPi+ZgjJjbP/WPVj9e6TCCrvRf73DStiQjHQB8A==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA2PR10MB4697
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.219,Aquarius:18.0.930,Hydra:6.0.562,FMLib:17.11.170.22
 definitions=2023-02-10_13,2023-02-09_03,2023-02-09_01
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 bulkscore=0
 malwarescore=0 mlxscore=0 mlxlogscore=999 adultscore=0 spamscore=0
 phishscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2212070000 definitions=main-2302100152
X-Proofpoint-GUID: 12wjfv7-ObPTnjI3vyd1tYHUYRlhLLQR
X-Proofpoint-ORIG-GUID: 12wjfv7-ObPTnjI3vyd1tYHUYRlhLLQR
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Since commit 8b41fc4454e ("kbuild: create modules.builtin without
Makefile.modbuiltin or tristate.conf"), MODULE_LICENSE declarations
are used to identify modules. As a consequence, uses of the macro
in non-modules will cause modprobe to misidentify their containing
object file as a module when it is not (false positives), and modprobe
might succeed rather than failing with a suitable error message.

So comment out all uses of MODULE_LICENSE that are not in real modules
(the license declaration is left in as documentation).

Signed-off-by: Nick Alcock <nick.alcock@oracle.com>
Suggested-by: Luis Chamberlain <mcgrof@kernel.org>
Cc: Luis Chamberlain <mcgrof@kernel.org>
Cc: linux-modules@vger.kernel.org
Cc: linux-kernel@vger.kernel.org
Cc: linux-pci@vger.kernel.org
Cc: linux-riscv@lists.infradead.org
---
 drivers/pci/controller/pcie-microchip-host.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/pci/controller/pcie-microchip-host.c b/drivers/pci/controller/pcie-microchip-host.c
index 0ebf7015e9af..08c0b778ce67 100644
--- a/drivers/pci/controller/pcie-microchip-host.c
+++ b/drivers/pci/controller/pcie-microchip-host.c
@@ -1135,6 +1135,6 @@ static struct platform_driver mc_pcie_driver = {
 };
 
 builtin_platform_driver(mc_pcie_driver);
-MODULE_LICENSE("GPL");
+/* MODULE_LICENSE("GPL"); */
 MODULE_DESCRIPTION("Microchip PCIe host controller driver");
 MODULE_AUTHOR("Daire McNamara <daire.mcnamara@microchip.com>");
-- 
2.39.1.268.g9de2f9a303