Message-ID: <7ab8bdac-3264-2718-e5c9-53bcaa5db010@oracle.com>
Date:   Fri, 10 Feb 2023 23:51:46 +0530
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.6.1
Subject: Re: [External] : [PATCH v3 1/1] PCI: layerscape: Add EP mode support
 for ls1028a
Content-Language: en-US
To:     Frank Li <Frank.Li@nxp.com>, helgaas@kernel.org
Cc:     bhelgaas@google.com, imx@lists.linux.dev, kw@linux.com,
        linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org,
        linux-pci@vger.kernel.org, linuxppc-dev@lists.ozlabs.org,
        lpieralisi@kernel.org, minghuan.lian@nxp.com, mingkai.hu@nxp.com,
        robh@kernel.org, roy.zang@nxp.com
References: <20230209151050.233973-1-Frank.Li@nxp.com>
From:   ALOK TIWARI <alok.a.tiwari@oracle.com>
Organization: Oracle Corporation
In-Reply-To: <20230209151050.233973-1-Frank.Li@nxp.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?N284YmNkZ2llNkNDN202am5XcmFnTjR0c3NjR0hkS3BBaHcwK0FRUmR3elBT?=
 =?utf-8?B?V3lXTlIvbm9vS1lmZm5rMUk1dEZZOVJTOWlCdXQxRzBhTVkzTkswTG1ocG91?=
 =?utf-8?B?K0pTUkhROVBZMVBpQ1pWT09seDIwakNvL0UyVi85bXVsM09iZDd5WmcydjRo?=
 =?utf-8?B?VTN0VW1JSHJBTjBLREYwTTgzbGtLV01BQys1Yy8vTXR3RXBvbGxPRG9pOExJ?=
 =?utf-8?B?bElCQUVKbTBveDBFUmkxK28xd01pMktFYkxKWkNDd0NwMm9hY1BXSU5SWEJG?=
 =?utf-8?B?b294elNoZGRxTDRkYU9EQUJoZTJ2VGZrN2dLekZJcU1tWE1KbUdCY05SWlVz?=
 =?utf-8?B?VkV5RWFuUkswbnBmR2xvTnB6WDY4Mnhtb0RvalNSbEhuMnVEWm0yMHpscDNu?=
 =?utf-8?B?bTlyakRaL3BUdE5jalVPcUh4OXVxYzl3WTVQN0ljQWUrL3hobWVVSHJReUhQ?=
 =?utf-8?B?dHpRaEpXenAzMVp2cWczdmhBaEMrcXlhQmt1WjkwbkMzVDBPd2tnZVprbEwx?=
 =?utf-8?B?elFxblIvQzZYQW1HNk15OHZsZENGV1FDNzV4aFpEV3hzcmJpQ3ozV3JoL0pw?=
 =?utf-8?B?RmlvVHVlVE1aamRUV2JaUkc5S3EraVFwREtMejV5V3AvRFhCeWY1YTRwemZ6?=
 =?utf-8?B?cjBrTEdNVXBGYVVha3dmVmZYWGpDQWFXdWRsTmh0dVRTRWNRaUhGMjA0R24v?=
 =?utf-8?B?WGJZUHVmUnpBYlljd0wxKzVqVmFXTXhBSzV3OXhRbERQUjhIZzJRQWxqeVhR?=
 =?utf-8?B?eGt3Q2pxTkpHaTJLRFMydWRVc2hsVGlYbW9LdEJWd1gvUDZTU0JGVzJVeGxV?=
 =?utf-8?B?K2VkTW5MbUtjclJLZ1k4Nk5kTjNpQjdrQitQU3JvSkE0VDIzZDdUVlFUY21t?=
 =?utf-8?B?U2RobjA3eUtabDltblQ5Q2o4SVRoSEt3VDJlNWFWejFpNWZFbEMweExTL2Np?=
 =?utf-8?B?d1MzMGhSSEpxNkIvZkFlb3lIdTIxV25IQ2dqRVR1ci85REczanphOFhqbGVX?=
 =?utf-8?B?RnpvTFJ5MmFSRkw0NHJ4a2hpNTRXeGNwSk94WW1ldmVyNi9kVCtaT1JYRk1h?=
 =?utf-8?B?dzkrblZtTWIxZ3VSQnM1QlU3NGFpemtUZW5qUERHR0tSbUhzMW9vZHR0YjlT?=
 =?utf-8?B?ZlFleXh1VjZiQ3B1ZUhic1oxR2pHcmNRalF4RDh6b3QwcDZoVWczSHdWQnp3?=
 =?utf-8?B?SjJFVFVLa3A3dFNaZVN3OWVaOFEwN1BlYUR6YkEyL0hSZ0E5UjJCZXpyY1Yz?=
 =?utf-8?B?RHl2ekcvemt1TU9vV2dvNTVmSWlXeWZnSytVaTh3b2lMeUVUaGlOWUoyWklX?=
 =?utf-8?B?MUlFSFBtVlh5ZHZ2TEszeEdwaTVRR2lvdVBMUTIyTXhPeTRPRCtXL1BuMTZs?=
 =?utf-8?B?cTROYnZ6N1pZY2xtVTNsT2wrdlBaWEJzL0MvNFpNbjRrTDVVUThOaVN0cFo0?=
 =?utf-8?B?cXZiZzVjOHVrUXVFV3lXOGUxL1l6Q0YxcU9pcWtwc2dlYVJGNStIMHBWS3lL?=
 =?utf-8?B?Qkl6aW83T0NuVmkyUEhlVnNNcEVFcVNmL1JpU1dtdUlTOTdldVE1czFVUFdL?=
 =?utf-8?B?MEpuQnJkaFhJZktJek1UMEMwZ2ZjYkd1c3ZuemVjeHNJS0JMTEcyclVCMlBD?=
 =?utf-8?B?TXZncHJxcUNUcDd5NU9JTWlvWDN1ckZHa2lybVZhTFd4L3dFOHdVdU4xaDR5?=
 =?utf-8?B?aHhVODYwMTNyNlNDallqQmh6b1oxVHYrZG12RjFiS3JuMEs1czVudDQwV1BK?=
 =?utf-8?B?QkIzb05JQ0oyVHF3QTRiVXFxMFNydFN6aTZYNWdKWm9TS0V4RktxT0xGNEd6?=
 =?utf-8?B?TTN6TFJZcDdTTUd3OUR6anF4cEphdld3VzJRbnRCQjQ1TUNIaXQyMnRnd2wy?=
 =?utf-8?B?ZjZlYVp2WjhHYzFxQlVzQWYvZklUcWowMzJpYW1rcWZPRFo2NzFSMnA4enNs?=
 =?utf-8?B?ZHlYckxxbXlmM2lGcjJmSC8zKzVuWlI4b1E5LzgrRnBOK3J2YVk4ZjJVNEdi?=
 =?utf-8?B?enlteHlOVnRwVjg1R080Ri85WXFBNTZoTFpPVmQzajVaaERrNFFQakNtUGc1?=
 =?utf-8?B?cG00bWE0VE52empzZ3ZpVlUwU3VBU1hzWXlZbUNteDdxZC9aOTdmOERRazk0?=
 =?utf-8?B?YWhmbzJMVGcwRHMxSzJTalFkenhSQ1RsN0tmdkQzbHBnMS9mZHNHR2dZNFJ0?=
 =?utf-8?B?QVE9PQ==?=
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: =?utf-8?B?VlpVaGdpRjI5Q1JQdUd1MVdvcnYySUFNMHRzeENGdWhqM05qeTI0ZlNRd2NG?=
 =?utf-8?B?TUUrOExmSlplZXIzaGIzODljT3B5QXA3Y2dNSWd1SWJvY09iTjJMSHZDWDN2?=
 =?utf-8?B?Z0ZOTFBKWkhTVzBQejd6TGk5b0J3SzBJaW50L0toSlA4ODlwYk96Y0x6Mk5q?=
 =?utf-8?B?ZVBKTHFqNFJyb0M3R1I3KzkyZTRYWGxlV1crakl1cGd6dlgzdFlGdVBqMlRR?=
 =?utf-8?B?STc0MkNJVXJ2VTVrR0ZLc1FDSkRFK21mNEc5K1ZId2xrcm9VNE1Bb3RmaGlB?=
 =?utf-8?B?TjNTdnN4bENmMTFkb2JZUXJOOXA1dVhvbGFpV0orSm53OVlqTHJBc0s5clpU?=
 =?utf-8?B?R2tRZmYzbGVPOFRaSUxXOExOYjF0eFkvS1Q0ZFNiNmkyMWphY2pnT2kya041?=
 =?utf-8?B?R3dKczdIRkVDdW9nVmZaa01LcHlmcC9hMTU2ekREOGFBdGFFOTlIOXpGZk5D?=
 =?utf-8?B?V1BUdHhac3BkUjkxMnBoN2h2QW8zQmNjOXRXZEQ0a25uT01iakdVeFYxNlJq?=
 =?utf-8?B?R2VPWHAzMllENkNuS1RJb3M0bitoRXpOOXB3aFRQWC9DSjlVdWNHTktEUjcr?=
 =?utf-8?B?dmRUMkcxdDFEQjRNcDZLcUkrcFlHeitVbXdoZDZMVkp5QnUreHUyV0VpZ085?=
 =?utf-8?B?Uzh3MElsQTZmZnp4Uk9oMGtNY0NiRzY3ajArMG81QzJjQzk2eGdUNkVIUzRI?=
 =?utf-8?B?dWxpSllPUjVWZW1EYTU2by9aV1E2Mll0N0txVlpNaE1ZK0MrQzhaNXdOa2xN?=
 =?utf-8?B?cU5zWkdsU09zTStuYTJCb3ozZTM4bVJsd0hNaWlvcjluZnVoTmVZM1Vnd3BR?=
 =?utf-8?B?aXQ5Z2doaEd2Y28xdm50bGdXK0VlWmFOcmRERk0vWUgyeUVXYnp5MGoyWGdM?=
 =?utf-8?B?REJ2a09mTERzRG5mZWZHRG9GTG9wK0JrVGViSFBiMVRoTkNqUjNyQTF1Rk1D?=
 =?utf-8?B?OCt3TjIzandNUkUxOTN0UEVIVGlOV2RLYU9IZ1BxYk5ZazVqZWdHNGVWdUlB?=
 =?utf-8?B?dVliRXlhZGp3Q1MydldhcmZjWWFsNnRoYlZlSHJwTHBZNW9wcElQUW9BajZu?=
 =?utf-8?B?SWtZWVQ1ai9PTWNrTk9yTWt5RjIzMkUyT24zcGxza1VsNXE2d0ZuY3ZmNTJx?=
 =?utf-8?B?TFV5UkU2MDFISkg4QjREU1BMODN0aTJLbitaaU81UmV3Z0RVS3lrYmZiTmkv?=
 =?utf-8?B?czYzN3hKQldGSFIvLzJVc2lOUW50VFE2Nzlqalh6UEtDUVJ6VWVHV1gzMEQw?=
 =?utf-8?B?emFpeUVNTXZjWFBUOS93U0VoOU1rUEd0Skd4QjBVaEN2N294cGVocC8vUE9j?=
 =?utf-8?Q?Dlaf9AH9oDeE1LeuAtSjMoynXOAdrZH0BA?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 8a8e8020-71c9-4d35-bbb6-08db0b93b127
X-MS-Exchange-CrossTenant-AuthSource: PH0PR10MB4581.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Feb 2023 18:21:56.6919
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: gnRA/VmAcyEpcSW6A62N124I33gpkkSbXvB1mroN+6opFHw9xB/7xUAaq7G56GgFOr6Me8xvRtNUGljtm451587t1OGbecm7Lx7B1gn6Y+4=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN7PR10MB6406
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.219,Aquarius:18.0.930,Hydra:6.0.562,FMLib:17.11.170.22
 definitions=2023-02-10_13,2023-02-09_03,2023-02-09_01
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0 suspectscore=0
 mlxlogscore=999 adultscore=0 phishscore=0 mlxscore=0 malwarescore=0
 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2212070000 definitions=main-2302100153
X-Proofpoint-GUID: g17ZJUgeCBcxD0tmqF0OneWMMooS0JJ8
X-Proofpoint-ORIG-GUID: g17ZJUgeCBcxD0tmqF0OneWMMooS0JJ8
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

LGTM,


Thanks,

Alok

On 2/9/2023 8:40 PM, Frank Li wrote:
> From: Xiaowei Bao <xiaowei.bao@nxp.com>
>
> Add PCIe EP mode support for ls1028a.
>
> Signed-off-by: Xiaowei Bao <xiaowei.bao@nxp.com>
> Signed-off-by: Hou Zhiqiang <Zhiqiang.Hou@nxp.com>
> Signed-off-by: Frank Li <Frank.Li@nxp>
> Acked-by:  Roy Zang <Roy.Zang@nxp.com>
> ---
>
> Change from v2 to v3
> order by .compatible
>
> Change from v2 to v2
> Added
> Signed-off-by: Frank Li <Frank.Li@nxp>
> Acked-by:  Roy Zang <Roy.Zang@nxp.com>
>
>
> All other patches were already accepte by maintainer in
> https://urldefense.com/v3/__https://lore.kernel.org/lkml/20211112223457.10599-1-leoyang.li@nxp.com/__;!!ACWV5N9M2RV99hQ!NR9EU4fPDwxdyrb9tdBm9VNIMHSlw6dLgXCAPDSrm7ftWVNrh6JldLGzzrKyiE0xRlP5OdiGBN7PCf9gRaA$
>
> But missed this one.
>
> Re-post
>
>   drivers/pci/controller/dwc/pci-layerscape-ep.c | 1 +
>   1 file changed, 1 insertion(+)
>
> diff --git a/drivers/pci/controller/dwc/pci-layerscape-ep.c b/drivers/pci/controller/dwc/pci-layerscape-ep.c
> index ad99707b3b99..c640db60edc6 100644
> --- a/drivers/pci/controller/dwc/pci-layerscape-ep.c
> +++ b/drivers/pci/controller/dwc/pci-layerscape-ep.c
> @@ -110,6 +110,7 @@ static const struct ls_pcie_ep_drvdata lx2_ep_drvdata = {
>   };
>   
>   static const struct of_device_id ls_pcie_ep_of_match[] = {
> +	{ .compatible = "fsl,ls1028a-pcie-ep", .data = &ls1_ep_drvdata },
>   	{ .compatible = "fsl,ls1046a-pcie-ep", .data = &ls1_ep_drvdata },
>   	{ .compatible = "fsl,ls1088a-pcie-ep", .data = &ls2_ep_drvdata },
>   	{ .compatible = "fsl,ls2088a-pcie-ep", .data = &ls2_ep_drvdata },