From:   Nick Alcock <nick.alcock@oracle.com>
To:     Rob Herring <robh@kernel.org>
Cc:     mcgrof@kernel.org, linux-modules@vger.kernel.org,
        linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org,
        linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 1/8] kbuild, PCI: generic,versatile: comment out
 MODULE_LICENSE in non-modules
References: <20230210164749.368998-1-nick.alcock@oracle.com>
        <20230210164749.368998-2-nick.alcock@oracle.com>
        <CAL_JsqJ_VhesDZO336tw=KAp88jCLdW9C6y6QDkTF7WpLkr3+w@mail.gmail.com>
Emacs:  is that a Lisp interpreter in your editor, or are you just happy to
 see me?
Date:   Fri, 10 Feb 2023 18:43:45 +0000
In-Reply-To: <CAL_JsqJ_VhesDZO336tw=KAp88jCLdW9C6y6QDkTF7WpLkr3+w@mail.gmail.com>
        (Rob Herring's message of "Fri, 10 Feb 2023 11:36:16 -0600")
Message-ID: <87a61l1hum.fsf@esperi.org.uk>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.1.91 (gnu/linux)
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?yH6rQPs7d1PJ46uuhKN++nLqa0e/+gfGUmlBTDY4t5sLHKatWNXZK0ggncwm?=
 =?us-ascii?Q?HJO+mgDms88bI7HpFXHGc2fI4r4FpMGKCEm6g8E9BNs3YVK88s8G+iZyx60H?=
 =?us-ascii?Q?Cj+3nTh5wnQhdSTd28wLppfOaRHjsk5zY4vAIHvgF0WDHt4AmVXeCK7ckkcX?=
 =?us-ascii?Q?NqbX5KOU+ZjucFzYFjtoaFHOAbBcWPNS3mC86X1abeAuowwzoQZOqLYZxUsd?=
 =?us-ascii?Q?7KaqW/zg8nEGEwyIoUrnchIsxhflFKiSX9b5o0ZM6xfZd3Y9T3URJJVe9uSW?=
 =?us-ascii?Q?k8MWJfmWYirDsl9G7FbPLuJwcRJPrIwfEKOASHOyO0YL9KRq284YX+3VIgd5?=
 =?us-ascii?Q?Ky7NL5PFUvl+08acc8gmAp73NHHPS9hoRNarzurj4qs272BEkzIxNKVvwuHP?=
 =?us-ascii?Q?WyScE4v4Ur8eFIPOGGkZfAalC14qCuwgpFXtw5ysXNpTSGVn0KADS3L5TseE?=
 =?us-ascii?Q?yDOK6oYus3ghiQDauTZzA6OOWQEJZhcxxbxm+ssv5G/hl4qYBE/nRMzIO3ns?=
 =?us-ascii?Q?FU9+IT96RIvpQXwcUR7VBUZNkQdnbaU6b958bMP2+Jqnb3I8CJajoLjltG5D?=
 =?us-ascii?Q?SR7d/l1xaQX8eUNstwSHenjf5e9WqqgX3d0mkQ3PpLnHooyNZJ2dUW6IoCrt?=
 =?us-ascii?Q?uohssRsvdVBGDvGpefbihdJvml3YW84LUYPTZOK1HJb78qd33zgP00OXjiyc?=
 =?us-ascii?Q?H8dfIojVWuRMN5Le8bekkoG77WKctbw7r0UWjKbiGP8glKuaf7cjN/tFHA3X?=
 =?us-ascii?Q?nidwQcPS5u+L0Fu8cBu9xqHqlAk7X3nYr3dQ/tHEArrO0k0wePIlpptnsS6N?=
 =?us-ascii?Q?SGNvimySNUXnVM8W6PQ1wZS6gdlXkv4/FxZftH3P9X0Gq/l/u7QD+bqVm4EP?=
 =?us-ascii?Q?M1XYAvluMhrWbqap9Wh/ex2ys+fhZb4sSdAP81RuobEiCXrBPvY1ENXc7gpQ?=
 =?us-ascii?Q?1qaw/7FjFW/jTumU10+g2DYZOdo9Fz02fO5+eX+TOLUnjG9aGiAU57w+1CZd?=
 =?us-ascii?Q?sE471yvK5hj0nS9aqNYGWi3oMmq2ChR4f/TEcHTepCLhcMa2u6wpFVM6tDD+?=
 =?us-ascii?Q?Y37ikzIRM81bHw+Yu1nL1SaK9egabuaFXdHuvF6FI36y8h+ew99ngErGQXEY?=
 =?us-ascii?Q?S417zYwgrCYPxbG9fBwBMpNs7noIcELxMyhVmtFOIQlJo2fzARerpO+D6s9E?=
 =?us-ascii?Q?F53XVUBqGNnu9aC/j2uUe+oVtP0XYYYgMOGI94FDVYOs3wqxKA62OkUgctV1?=
 =?us-ascii?Q?K8XrMBpshqi1A6W31xM5d613MQM6CvQto9ZWgpQnfj3tGCjoac7fxelAHib8?=
 =?us-ascii?Q?m+FC9XOpi8M94Q64OiKcNQ5adEaK8WaNtmcMsPgYrnlw8wE1D247v+0QKScc?=
 =?us-ascii?Q?lqxpeozqCj/ImlZZjEmNzn3Qjzf0f6NSSpvQKYfQpd+jPlBSXPXMrbpEmsR9?=
 =?us-ascii?Q?qfdiopg4blQ5W5oYBFR2zozvWmkLJyUuonRrKWNkL7PjqhBhjaVIhnrw23uP?=
 =?us-ascii?Q?DrfyJHb4hb8eFKKerfTpYazgmWIAqNSnmxZ3cyAb5sDIP7zwAC+QZ7EZgDWV?=
 =?us-ascii?Q?a87AeoIY2mt1hoqXWVstTl7NY0eYW+yFHYbknX3v3YCgpl6DQq1DzIL3zRbZ?=
 =?us-ascii?Q?Ug=3D=3D?=
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: vpwtPnYXJwHZkJdl9h6XXaHBRTiMVsl7XKpr/sLkg5NNUrPqyVDljkFM3wDJGcJau7UHz96ZDO5XSMfPP75IA/nko/dwzL1SLvlX0wV1b7AhlsPLXSzzd3wX2Q5q4ckA2E5pgWCqa1T+KbiLpmK9Z9Mvh3YSKm7g/z31xLyx0NI1uuNQQT4tOtxx/qRohkUmym6RqFOdFmJ58n/nsir4oc4zW2UT26tT9lhlJVLuK7rt5kahh50RtdbepImDSzs4Ry5NIMYi+ggyYQy4BIdLUTLvSyzEAK8AwaHVUj83MXI0BSDCFaZfiiYVxEMz6srMpQYNWp0cX/CMU3lG+JBDwv/8qh8A9ffSrO34YBHbRxtE2zpGAJ61TYbWFxt34knZ9+8dQI01TNTJRVhIGqsyY57z7SQ3w6tSoTMyFMWuPhPX9gwMHrFpJ2QpYIh2F45pa1Ir0I0ol0WrgOoTJtmkCCf12CnSH0NgLjqmEE4totXoVFGx7qm6cqjuhVUti3EuG1Sy1SMN6FnuBKw3xEDFWPbV/stnlg0kDhfE2BuiViQGHm76g6LaadcQVsxxdlrP4in4HYP+2T8QQ5sEPQaLivmWJyQYlKGilZPXV0HuAA4hRXg4FZ4UPtqereasSDyDj4itP0zviO5VH1m/5maAdJ+5hTuGbyicBRGiN5sRQhkQs24osmwG8swFKfPK57TI7LIoPiCZNOH8TzDIsk5Rulg1EdHtiLE7suYzA9bxqoGY8mQ97nPHXFZJP/LVJNSHOkqPODc/VQzLVQ7FkLPLr1lT9YdHPKxkDBs4m0Z2edEQ9EFRZe53oyDhdT0c2q/MMjvBPQH+G3yeLSvJ5uy8xQ==
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 3871881b-7717-42f7-5760-08db0b98007b
X-MS-Exchange-CrossTenant-AuthSource: DS0PR10MB6798.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Feb 2023 18:52:47.6591
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: axFdEzxVwdV7QVYrG3UjpJUp8MVkY7VKNnqEghXM3OQjNeda0SnUnBEfin7tCCfTE+nZgH+frCcOuZ2g7WziKw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BLAPR10MB5042
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.219,Aquarius:18.0.930,Hydra:6.0.562,FMLib:17.11.170.22
 definitions=2023-02-10_13,2023-02-09_03,2023-02-09_01
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 bulkscore=0
 malwarescore=0 mlxscore=0 mlxlogscore=999 adultscore=0 spamscore=0
 phishscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2212070000 definitions=main-2302100158
X-Proofpoint-GUID: QdfIk99bGOaisfijBOfLuR8S-rVqN2zT
X-Proofpoint-ORIG-GUID: QdfIk99bGOaisfijBOfLuR8S-rVqN2zT
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 10 Feb 2023, Rob Herring uttered the following:

> On Fri, Feb 10, 2023 at 11:05 AM Nick Alcock <nick.alcock@oracle.com> wrote:
>>
>> Since commit 8b41fc4454e ("kbuild: create modules.builtin without
>> Makefile.modbuiltin or tristate.conf"), MODULE_LICENSE declarations
>> are used to identify modules. As a consequence, uses of the macro
>> in non-modules will cause modprobe to misidentify their containing
>> object file as a module when it is not (false positives), and modprobe
>> might succeed rather than failing with a suitable error message.
>
> How is there an issue when any given module could be built-in instead?

"modprobe module-that-might-be-built-in" is always meant to succeed if
the module is built-in; but "modprobe thing-that-can't-be-a-module-at-all"
is meant to fail. e.g. on a system in which ext4 is built in, I see

loom:~# modprobe ext4
loom:~# lsmod | grep ext4

(with either reporting any answer, and the modprobe returning exitcode 0).

But trying to modprobe something that cannot be a module says, e.g.
(sorry for old kernel, just happens to be what I can lay my hands on
easily right now):

loom:~# modprobe slab
modprobe: FATAL: Module slab not found in directory /lib/modules/5.16.19-00037-ge8dfda4e77fb-dirty
[exitcode nonzero]

This is what is expected, even though slab is built in. It's not a
module, it cannot be a module, so trying to modprobe it should fail.

But right now we have things like this:

silk:~# modprobe zswap
[nothing, exitcode 0]

zswap cannot be built as a module, so this output is wrong (and
inconsistent with the slab attempt above). (Sure, this isn't exactly a
disastrous consequence, but I have other things I'm going to contribute
after this series that depend on this being got right consistently.)

> The general trend is to make all PCI host drivers modules, the primary
> reason this one, IIRC, is not a module is because it is missing
> remove() hook to de-init the PCI bus. Not too hard to add, but I
> wanted to do a common devm hook to do that instead of an explicit
> .remove() hook in each driver. I suppose we could just ignore that and
> allow building as a module. Unloading is optional anyways.

That's perfectly acceptable for me -- I'm not saying that these things
should not be modular, only that *as long as* they are not modular, they
should not have a MODULE_LICENSE. Making it possible to build them as
modules again is fine!

-- 
NULL && (void)