Message-ID: <49a3244a-1416-12c4-9dfa-661cf5b5d569@amd.com>
Date:   Fri, 10 Feb 2023 14:36:56 -0500
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.7.1
Subject: Re: [PATCH] drm/amd/display: Remove duplicate/repeating expressions
Content-Language: en-US
To:     Deepak R Varma <drv@mailo.com>, Leo Li <sunpeng.li@amd.com>,
        Rodrigo Siqueira <Rodrigo.Siqueira@amd.com>,
        Alex Deucher <alexander.deucher@amd.com>,
        =?UTF-8?Q?Christian_K=c3=b6nig?= <christian.koenig@amd.com>,
        "Pan, Xinhui" <Xinhui.Pan@amd.com>,
        David Airlie <airlied@gmail.com>,
        Daniel Vetter <daniel@ffwll.ch>, amd-gfx@lists.freedesktop.org,
        dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org
Cc:     Saurabh Singh Sengar <ssengar@microsoft.com>,
        Praveen Kumar <kumarpraveen@linux.microsoft.com>
References: <Y+YVy7RaxnXokJ3l@ubun2204.myguest.virtualbox.org>
From:   Harry Wentland <harry.wentland@amd.com>
In-Reply-To: <Y+YVy7RaxnXokJ3l@ubun2204.myguest.virtualbox.org>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?QU10enpwOG5CY0RNUnQxOUtjYlE2TjNyRXJYeE1IUXhPWXdxV3VMaHh0ZDFl?=
 =?utf-8?B?SmJRbzVHakxjVkEyN05Rc2xxWURHUGR2MHJDbUE2QldtaWV0WHBQaWhnSDhy?=
 =?utf-8?B?QUpzdlhXTGV4Mmp3a2xKckozc1pFTGROaWUvdWNSdjlLWm52bGNMZnFiOU1y?=
 =?utf-8?B?T3RTZ25xb1hKNzBiOENtdGJINXRWWnQ5QTZYOGhQQ0tFb2hMNGVQc1d0QVpJ?=
 =?utf-8?B?bEdKb21YZS93ZGh3RTU2Z2VoQkJYbFp5dkhpQWpjcDJTVDZJV21RQ1Qwb2ZK?=
 =?utf-8?B?bWVWRnlFVUhpWER5TXVpRnBNaXg0SjN4eGw5TUNiUGtiUG9oeE9oYXdGaE92?=
 =?utf-8?B?cmk0dnJvTjAycFE1MW4zNmhLVURDOVUxbWN0OWdFN29kdDdNai9tNExwY05u?=
 =?utf-8?B?S2xnbkRKMG5LQmprZS9qUzFGb0c3YnBHWVl4WXlrV25lN2gzWERRK1dZakRj?=
 =?utf-8?B?WkNBTGlCMnNIbTh0aU5KQXltaXVROUdQSlJ4OXdDWldUODVscGEzOVFMUEFD?=
 =?utf-8?B?SlZRRSttVjFTVXhWSnl1NERuVE03WXh6Y0lZT2RNczVNeE9rTmFtVlRQdWFR?=
 =?utf-8?B?TlptRVRiNmZ3eDVKb2RZZ1A2Y0J0MnZzL28wSmc4QXdNRnZFT0RWOFlIaS8w?=
 =?utf-8?B?YTVlU2pFOWczc0J5a0ZaTmw5aks2MkxqVEJHelh0YlJXaDBkNUluVEtkNnFL?=
 =?utf-8?B?UTQ4Myt3RFQ1YXcyVGdRRk11Y3daTFkxWTVMeG5lZXU4SHE4MC9WOHNZd1BJ?=
 =?utf-8?B?UHhnZThGZ3J2QUhvenFnQUZvb1dXM1VCWWRpb1NiaUw0ZlVrNXVlQ0wvQU5y?=
 =?utf-8?B?Sm1YcHVkSDBCV2FRS3RBZnF4MTRMODNXd2x1cGVoTW50cmJNQVRsalg1TU1B?=
 =?utf-8?B?U1kvWkxiOFh1MUxKcnFSbnNIMlF3aXUzbnk3czFFOGRXcExqc2thM1gwLzNR?=
 =?utf-8?B?YVZvTTErcnNlbFVXVTAyd0dic2I2WG4zUGJlRERPKy9UQlFFNFNESEd4c2lo?=
 =?utf-8?B?bEUrSTVSRmhiaGcyQTB3Z3dkVExYWk10Q2dVMTZKMUFJVWwzcWlMNlVvbnhT?=
 =?utf-8?B?Y1B0Q1JTbWVDV3lLWXR5OGhQdUNtR2E4Skl4MHhhT3FTcVFhT0lSSHJrUDRJ?=
 =?utf-8?B?TGQvZ2JhYjVad0JYQVhVdXhNZWdUOUtEOWdPQ1hqdTRnTEM1cTZENmJMQnlD?=
 =?utf-8?B?K2hoOUpwaVFuKzRWVFM5UE85ZjNHZkRiY1JhYWZvL3hVaVBlc1h3ZExNS09Q?=
 =?utf-8?B?U1Y0MzJvQTMzalU5VUdOdmFTSDZCQkY0QWtBaHJqbmNiZXlGNXpNclpiTzdi?=
 =?utf-8?B?NVpyTWY1Rk0wNXNrejRRdUplK0VtNDgyeGJ6RHR1VlBzRko0NWQxdmxWa2VY?=
 =?utf-8?B?d0hlWHBYZTFqWSs2Tit1NllUZ2FhQ0hNRkZFaW9YYUpOdXFycHVyYkYzZGx0?=
 =?utf-8?B?S0FPTk1oYWZkMDVUN1Q1M2NuRWRQcURLMzhQNFFjYU9Cd1MrRit2ZitCL0M3?=
 =?utf-8?B?WkFMTEhBQ1JONUFWTzY2c0ltS1ZtUW1PeTdKc2dzbU5RY0RXODJMRHpZM2tT?=
 =?utf-8?B?Yzk0dnYyU2thUklVYmp6azRPaWswSElDdnU0eTlFeEtlYld4MjIxTHZ6ZUZ4?=
 =?utf-8?B?Nm1INWhpbEo3ZzlvamdRYlovV1RBME0yQTh6RkVROTFDQXc5SHdncEczSXhn?=
 =?utf-8?B?RFZkZGN3OWFXOFZ1bDhiNFEySTRJaXJGc1R5TVdRM1ZpTzUyWVoxZHhFYTh5?=
 =?utf-8?B?b1JuUlgybWl1MzdTdUxaRzZ6WXEzYlRkKzVqV1pFSXRtZ2JlbFdKZEZ2TnpW?=
 =?utf-8?B?Snp4UUJIbDFTMjhOVGpyR09rZ3BwWHhDZDhGdDVwUjlUTjh2U25nRlAzcE5G?=
 =?utf-8?B?WGtJQTVmckJITm9LWGQ5b0JCeVl4N29BeHdPQVo2dlVvdFhzUFJGTVhZby9T?=
 =?utf-8?B?b0dLK1RDeFRxWFlBTjZtSmhWQWUyOUdJZCs3Nlk2K3Y2WWsybU9zS2JKTWFO?=
 =?utf-8?B?UlliaUptZTV2dWt3WU84dE4zQjk5RWY2anFXUVlsT3FHZTlhWm05WGNSdEU2?=
 =?utf-8?B?ZVJtZDBVd29EMUZxUSs4VW0vMHBjM0gxU2N4RENaaXRRYzZIamkrZDVILzht?=
 =?utf-8?Q?iOPFwT7D9NDCF9EY74DTUWvz0?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: fe8e3f35-3bd8-4f59-557c-08db0b9e2daf
X-MS-Exchange-CrossTenant-AuthSource: CO6PR12MB5427.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Feb 2023 19:37:00.6322
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 2/1o44RoFqMhoaFWFuqrCx48bS+aMnCQYh8BrR9rWp/zTStjEILy5jYw4q9zq2yAxqHWqMXMpDGnXo7rtgWeHg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR12MB6711
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 2/10/23 05:00, Deepak R Varma wrote:
> Remove duplicate or repeating expressions in the if condition
> evaluation. Issue identified using doubletest.cocci Coccinelle semantic
> patch.
> 
> Signed-off-by: Deepak R Varma <drv@mailo.com>

Reviewed-by: Harry Wentland <harry.wentland@amd.com>

Harry

> ---
>  .../gpu/drm/amd/display/dc/dml/dcn32/display_mode_vba_32.c    | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/drivers/gpu/drm/amd/display/dc/dml/dcn32/display_mode_vba_32.c b/drivers/gpu/drm/amd/display/dc/dml/dcn32/display_mode_vba_32.c
> index 4b8f5fa0f0ad..ae89760d887d 100644
> --- a/drivers/gpu/drm/amd/display/dc/dml/dcn32/display_mode_vba_32.c
> +++ b/drivers/gpu/drm/amd/display/dc/dml/dcn32/display_mode_vba_32.c
> @@ -2335,8 +2335,7 @@ void dml32_ModeSupportAndSystemConfigurationFull(struct display_mode_lib *mode_l
>  
>  			if (mode_lib->vba.DSCEnable[k] && mode_lib->vba.ForcedOutputLinkBPP[k] != 0)
>  				mode_lib->vba.DSCOnlyIfNecessaryWithBPP = true;
> -			if ((mode_lib->vba.DSCEnable[k] || mode_lib->vba.DSCEnable[k])
> -					&& mode_lib->vba.OutputFormat[k] == dm_n422
> +			if (mode_lib->vba.DSCEnable[k] && mode_lib->vba.OutputFormat[k] == dm_n422
>  					&& !mode_lib->vba.DSC422NativeSupport)
>  				mode_lib->vba.DSC422NativeNotSupported = true;
>  
> @@ -3639,7 +3638,6 @@ void dml32_ModeSupportAndSystemConfigurationFull(struct display_mode_lib *mode_l
>  			if (mode_lib->vba.SourcePixelFormat[k] != dm_444_64
>  					&& mode_lib->vba.SourcePixelFormat[k] != dm_444_32
>  					&& mode_lib->vba.SourcePixelFormat[k] != dm_444_16
> -					&& mode_lib->vba.SourcePixelFormat[k] != dm_444_16
>  					&& mode_lib->vba.SourcePixelFormat[k] != dm_444_8
>  					&& mode_lib->vba.SourcePixelFormat[k] != dm_rgbe) {
>  				if (mode_lib->vba.ViewportWidthChroma[k] > mode_lib->vba.SurfaceWidthC[k]