Message-ID: <ebda03df-ad02-c89e-882b-03f7514c3d92@oracle.com>
Date:   Sat, 11 Feb 2023 01:41:20 +0530
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.6.1
Subject: Re: [External] : [PATCH v3 1/1] PCI: layerscape: Add EP mode support
 for ls1028a
Content-Language: en-US
To:     Frank Li <Frank.Li@nxp.com>, helgaas@kernel.org
Cc:     bhelgaas@google.com, imx@lists.linux.dev, kw@linux.com,
        linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org,
        linux-pci@vger.kernel.org, linuxppc-dev@lists.ozlabs.org,
        lpieralisi@kernel.org, minghuan.lian@nxp.com, mingkai.hu@nxp.com,
        robh@kernel.org, roy.zang@nxp.com
References: <20230209151050.233973-1-Frank.Li@nxp.com>
From:   ALOK TIWARI <alok.a.tiwari@oracle.com>
Organization: Oracle Corporation
In-Reply-To: <20230209151050.233973-1-Frank.Li@nxp.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?d0ovSlAyR0NFNUVHVVdldzhUWHlkcHlPMmpqUkpXU2VaVnh5Y05BYm9lZTZZ?=
 =?utf-8?B?M2lpZDVkNXBLeHl0VFdFS0xpQWhKdnIrLzROL09PVXZkVVdiMDlBYTNiVUtY?=
 =?utf-8?B?Z21GTFgzWTRVTGxKOXNNS0xOZTA0ZlQvMXVwbytNUGI2VWZRc1cvVVdSZmFD?=
 =?utf-8?B?WnNrTHdPWXV2Q0pURG00SmlQZTBHbmlPUGhjSmRGZ3IxcFk4YU9HSjlTMWpF?=
 =?utf-8?B?dkxaUkdkM25Sa0dGL0ozd1QvWEdUVmJvYUF5MktYNC8zclJuKytwdlYxbEhP?=
 =?utf-8?B?ZmE4ZmZqWHdwQ2RaNnhnb3NjQXQ1RkhTUXVvcWUxWWdGVGhZanRQMUhzVElh?=
 =?utf-8?B?c3dCY1VlVS83MEhKM1Y0UzcrUDBXaHpQV1RYMVBQU2ZIc2pxeWdiUG5tWURz?=
 =?utf-8?B?bVAwNmtwN3FIK1pPQkZJOFN2cTNscTNMVU1kSit4UUFBeE1jMXFmajd4c01v?=
 =?utf-8?B?aENlempPZWVGOGp6Uzc2L3hhMlJWNWo4U0FraEpvVXV5bG1rb1JmVlFsMzNW?=
 =?utf-8?B?Y2RkZmtXMkxOUThudnJOazBjNmJVVXpTYVMwUUFQZG9RM01FSFFiY0VjRTM2?=
 =?utf-8?B?TmQ4Q0ZaaFFHNnl6d3lOQlJtUjM4VjBZZFZqWnNxaEo4NUk1TDlucXF6aGlC?=
 =?utf-8?B?ZS84Qkt4VEp6TXRPY2VFb05udHFVMjkwampuTVQ2YW9nbzRQNVZRRFhjMURa?=
 =?utf-8?B?NjVPZ29kSkQzS0NNL1VQcXZnaEFVcCtsL1h6RUdXSUlKbTZpOWk3OUtIaXBl?=
 =?utf-8?B?dkRnMXAxY0Fzc2FOYTN6TU9qdDdSVTBwdlZaUitlZkc0V0dJOTNFNFlhRncr?=
 =?utf-8?B?Z0svSmFkWEZpRng0eDYyL1czV3dudkN4eFZ2VmZXcGMxWG5rNDFObUF1dk53?=
 =?utf-8?B?SG9KbmJaT3FQTVNmQmlqcS9TdnhMQ2pQdFlOc3V0WFhpNllCL2lNNThzbGFq?=
 =?utf-8?B?NDFxSlRFUys0R1pPRnFWd0NMS25ubW1YbUtjVnhmdndYaDduZjlBMFJhM1kw?=
 =?utf-8?B?aXB3dHpCOUVEZGM4dlQ5enVyNUhVR0J6MWNVM0xmVHc1b2ZTVWtRdG50V01m?=
 =?utf-8?B?V3NsYzQvc0ZmQXRhWTZCV0YzVmVYMUhmbEZGbWdnZ1ZkY0cweXlYbU1sT1Zz?=
 =?utf-8?B?Sy96QWFJWTI0VUlnUVJFRTVsVjludElIRmw5bkY2b01ZSzNzcmpXaVo1REdq?=
 =?utf-8?B?emRGNDlJaDd5TXgrTGRRdjRrUzBKdUdzMmo1bTlOT1FwdU5DNlZER1JtcWth?=
 =?utf-8?B?dDNvdlB2eEltNWhpSm0ra01xUGhuZG1zMXNtMmlZTUx4YWUyZExieEc5KzNU?=
 =?utf-8?B?Q1YxZUgyaGpjd3N0M3Z3MmpIZkoveDhZeHRZdW10MlFpd2VCUUYxaVlJZkhL?=
 =?utf-8?B?RFlueDJxdys2RzVNOWNUMjlIdWxibUpvck1GcUF4K1FlZ2hhRlp4aFV1SW9q?=
 =?utf-8?B?clY5anplUWFzMER0d2ZKUEgrbWtuVWFwZXFET0NRSkc4RTlTQnMrOWprY3ps?=
 =?utf-8?B?KzNTM215cC81OFBBaThZTVJZK3VBcXFoc2dldDlDVjE2eGtQb25KZThwMDVi?=
 =?utf-8?B?b1Q4QVd3ajJQMzJDTUd2T1picUtpWmZ4WmRCeUtDaThXN0lnV2I5Z0pTSzMr?=
 =?utf-8?B?Q0hPdzVTQVR2czlyYjVUVEdmeGhjVWhyejBhSHRVdnM2WnVoTFBLZjQ5TE8y?=
 =?utf-8?B?V0w4QXN2akNKWW1ZSlo2YkhabWZnYVQyV1N0d29YWVpLZ0FBeVY5ckNGOFYx?=
 =?utf-8?B?MVkzVjRxUTRxZldqdG8wUEFudHlTYzNrUytZMUFwMFduSUN3bzZSVTB0VFdw?=
 =?utf-8?B?YitNMURSTmlWNE84eVlqOWRjVXVvODBIQytwTzlRaDRwM2lJVUxtd1ZZWjdr?=
 =?utf-8?B?MUNBcHo1aVlZaWgzZVZXREhMRGtSbStVSzJMU2hIQTBVRXJpd0Y5RHZ5cFZY?=
 =?utf-8?B?TjlZQWNsS1l5RkRRc0VWSlRsNnR6ZjA4ZWZmNTc1U3ZTSmlTUVBXRlhqMHN3?=
 =?utf-8?B?dkIrWGEvRElVcE5vZlBsaFlhekNRY3RwSmlGODRuUm8zRWhHY2RROVphNnpC?=
 =?utf-8?B?WndxaExtNTdLdEpwQUR0QnZ0ZE1wMjV0QUhXQlZsMnJEZU5LUEYzWnpCd2tQ?=
 =?utf-8?B?Ty9hOFAxK2xBN1FzRjlIazB6R2hDeWcySFlBMVdONUlvQlZFSzhsa1I3cDRU?=
 =?utf-8?B?Snc9PQ==?=
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: =?utf-8?B?d0xmNE9lYUpvSGNUSUVwTHJiZFErWERtQThobjIxL1IxQVN1bk9CWDRaTmFM?=
 =?utf-8?B?cW9Nb0NFRG5nUmV6c0hiNjZMbWk3bk4zY0k0M3BOdFZKSlpENzFuS3hPbXNU?=
 =?utf-8?B?Vy9MVmdYNHJsNVNGZTBvUW4xTXpOSWNRN3VsM3VIUjlaazZQSVhZOXo4d21F?=
 =?utf-8?B?NXM0ek5VODQwcWRpZllHRExDMWtYQXk0WWowbGhNMFI4aFhVay9XZ3lqdEdn?=
 =?utf-8?B?M2xhc3pBdzNjYmhFaytCemdBQ2Z3c0x6VXdmdEhibzNJWWpZbkUrd1lFRklk?=
 =?utf-8?B?dVpjdnpQTTA4STFTcG5EZ09XL3JVd3JHZXY1Nm1GVTRNWWJBTlczeko0SC9q?=
 =?utf-8?B?VjdSUUYxNUhzN2NDTkZlTmJiWHB3aU1zeDhkaWc2WlpVVk1ualBwMWF1OWlD?=
 =?utf-8?B?WklseTBHczNzL2lWV1ZmNXdqMmZyODM5bGgrcC9YbkNMQWd6anlFbllxUWho?=
 =?utf-8?B?Y2RuWXRIMWtJQ1lVSkhZWWowZEdJU1J6djJkakF6R2ZyaGZRVlV2NlBmNXVU?=
 =?utf-8?B?NjFidmluRzVwbmZ0UTJjcW43RzA2UmVCMEJQTFJid21OQ2Zqakpla2NtWEd0?=
 =?utf-8?B?aUZvL1FsamRZcHB2SUtuQ3JONkZSaDYwL2I3azRRekZOZXROZk5IbjZGSG16?=
 =?utf-8?B?Q1RqMXcxUS9UVnBSSXlzZVluUEpkMThZMVV1aUpvS3IySkUxejUweXp6eUhD?=
 =?utf-8?B?bm90Q1paejhpdWtQdVdoVE1NSWM0OTZEejZVc2J5NDlYVHlyMWs3MWprVkd5?=
 =?utf-8?B?YWhmT2RkbXlQclVJSFpSOHJYMTNQL0J4RWplK0c5eE16OVp6c3NPQ0xMUkJk?=
 =?utf-8?B?eTMrMWMwSC9XK2JTUEtoWnJsMHhiVEw2azJQTm12dk5EM2x4MU9SWW9qK0pF?=
 =?utf-8?B?dkhqQWx2Y3VZMkVlZU1VTkJRaGs3dHU5dmhKNENPT1ZRdS9LUlVtN3BDb0xI?=
 =?utf-8?B?Qks2WTRVeUVTQW9HNytyNjNHMldIdjRVUTJ5Q0tTU2NidGR4aURobFJESjZQ?=
 =?utf-8?B?Vm96VURQWU1HNXBDUjNYSms5MGFyVXpQTzZ6cWZ1TXE1NTJtUUk2cnFxYy9n?=
 =?utf-8?B?MkdBNHl0MitndlArTlZYLzNHSHNLdWY0WVR6NU0xTHgxSmlBRFg5bVpINTFW?=
 =?utf-8?B?SEFVYkxXUUtYTzRUN1JodThRd1NIWVZGS3BoeWI5TUV2WnR2d2ZsN29JUGlO?=
 =?utf-8?B?OFNGK3BOK2c5YkxCK252WlJHWGtkTjB4WDQvd1JSK0hzN0pBZk5XMWdwR3ll?=
 =?utf-8?B?Witrcm45ZUdqNlQxWlE5S2FURHVROEU4SzBldDV1M2RjeEkxWHFPU0hVL3oy?=
 =?utf-8?Q?x7Et5qYzU4f+doIQLfVWGdOJgyoQn2fwkA?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 3625d04e-eef3-4553-ef7b-08db0ba2ffd0
X-MS-Exchange-CrossTenant-AuthSource: PH0PR10MB4581.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Feb 2023 20:11:31.0515
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: jnpAKuP312L9rFtC/76KDlL0BJM6GLelENTtQGxRN09JZL4XYW7d8aC+kfNXeHhGnHmCjnjz9wTVWy+aQCw/uGSteiYzXOvZ91bWVwmXBX4=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BLAPR10MB4866
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.219,Aquarius:18.0.930,Hydra:6.0.562,FMLib:17.11.170.22
 definitions=2023-02-10_15,2023-02-09_03,2023-02-09_01
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0 suspectscore=0
 mlxlogscore=999 adultscore=0 phishscore=0 mlxscore=0 malwarescore=0
 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2212070000 definitions=main-2302100172
X-Proofpoint-GUID: WGTcwyOGApGH4rXWvlezPnKmypOYxFZh
X-Proofpoint-ORIG-GUID: WGTcwyOGApGH4rXWvlezPnKmypOYxFZh
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Reviewed-by: Alok Tiwari <alok.a.tiwari@oracle.com>

On 2/9/2023 8:40 PM, Frank Li wrote:
> From: Xiaowei Bao <xiaowei.bao@nxp.com>
>
> Add PCIe EP mode support for ls1028a.
>
> Signed-off-by: Xiaowei Bao <xiaowei.bao@nxp.com>
> Signed-off-by: Hou Zhiqiang <Zhiqiang.Hou@nxp.com>
> Signed-off-by: Frank Li <Frank.Li@nxp>
> Acked-by:  Roy Zang <Roy.Zang@nxp.com>
> ---
>
> Change from v2 to v3
> order by .compatible
>
> Change from v2 to v2
> Added
> Signed-off-by: Frank Li <Frank.Li@nxp>
> Acked-by:  Roy Zang <Roy.Zang@nxp.com>
>
>
> All other patches were already accepte by maintainer in
> https://urldefense.com/v3/__https://lore.kernel.org/lkml/20211112223457.10599-1-leoyang.li@nxp.com/__;!!ACWV5N9M2RV99hQ!NR9EU4fPDwxdyrb9tdBm9VNIMHSlw6dLgXCAPDSrm7ftWVNrh6JldLGzzrKyiE0xRlP5OdiGBN7PCf9gRaA$
>
> But missed this one.
>
> Re-post
>
>   drivers/pci/controller/dwc/pci-layerscape-ep.c | 1 +
>   1 file changed, 1 insertion(+)
>
> diff --git a/drivers/pci/controller/dwc/pci-layerscape-ep.c b/drivers/pci/controller/dwc/pci-layerscape-ep.c
> index ad99707b3b99..c640db60edc6 100644
> --- a/drivers/pci/controller/dwc/pci-layerscape-ep.c
> +++ b/drivers/pci/controller/dwc/pci-layerscape-ep.c
> @@ -110,6 +110,7 @@ static const struct ls_pcie_ep_drvdata lx2_ep_drvdata = {
>   };
>   
>   static const struct of_device_id ls_pcie_ep_of_match[] = {
> +	{ .compatible = "fsl,ls1028a-pcie-ep", .data = &ls1_ep_drvdata },
>   	{ .compatible = "fsl,ls1046a-pcie-ep", .data = &ls1_ep_drvdata },
>   	{ .compatible = "fsl,ls1088a-pcie-ep", .data = &ls2_ep_drvdata },
>   	{ .compatible = "fsl,ls2088a-pcie-ep", .data = &ls2_ep_drvdata },