Message-ID: <af294def-fff7-469c-b8c6-a245ba641c2c@intel.com>
Date:   Fri, 10 Feb 2023 13:12:43 -0800
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Firefox/102.0 Thunderbird/102.6.1
Subject: Re: [PATCH] PCI: Fix build error when CONFIG_PCI_MSI disabled
Content-Language: en-US
To:     ALOK TIWARI <alok.a.tiwari@oracle.com>, <bhelgaas@google.com>,
        <nathan@kernel.org>, <ndesaulniers@google.com>, <trix@redhat.com>
CC:     <linux-pci@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
        <llvm@lists.linux.dev>, <tglx@linutronix.de>,
        <kevin.tian@intel.com>, <darwi@linutronix.de>
References: <158e40e1cfcfc58ae30ecb2bbfaf86e5bba7a1ef.1675978686.git.reinette.chatre@intel.com>
 <333dee5b-6710-998c-bf3f-2cb1d676a7da@oracle.com>
From:   Reinette Chatre <reinette.chatre@intel.com>
In-Reply-To: <333dee5b-6710-998c-bf3f-2cb1d676a7da@oracle.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?aGZ5bGpvTk03UThnU1hPY0gzNitWQklWK0JucG52TmxLUTRjS2ZyMUphcVgz?=
 =?utf-8?B?M1pLRFB3MzZ0Vzh1OFlSUDM1VHZBWUFMZHJRbVZKTmZGTWJRRzM0emNKRmVN?=
 =?utf-8?B?N3B4bVU0M09TNUpzYVFkNGQ2cHIvR0xRN2pMS0FJTGJ1Y0pjeDNJTXR4cEpQ?=
 =?utf-8?B?U2hGRXBqR09PUFJmdWJiRXNSRnprM0dkVzk0REdoVUplSU9SbWdFcG5OdTJa?=
 =?utf-8?B?Q2NGZzNhV1o0dlU2cmlqU0k4MTBYU1p2ek5oQ3d4Mmtqd3UycllUMnl4aXh3?=
 =?utf-8?B?WW1lTTZLVlBiYnpkL3RJNklqa1FyNWxuYStYTTZQeExtWHFkN0diOUNoZHhr?=
 =?utf-8?B?WGhCWGIydHJDNW5ISUIrY3BuaWlDdXptd3BocWRRQjBKZUgzS0xlZ3ozQ1dp?=
 =?utf-8?B?bXhiQ0tqWmhpbGEvYk0rQ0syVGtYSEdnVDNscHhSdWt0TFVTTVEwRGJ5WExC?=
 =?utf-8?B?OHRQTzRqc0xpV3ZCWS8vMHNIRmJZbFU2SDBDUE40T0pVaEZDbWMzS0RDa0hn?=
 =?utf-8?B?U2hhby90QTRieCswcWI4THJKZ1ZVanBSNzNGRkhhc3lJMjNGeXRHRUhNcDFr?=
 =?utf-8?B?U09sWlpTRGprUkRzeFFxQ1hqUWhSZC96ditHeGtmS3J4bW1XWDFIRG02bUFn?=
 =?utf-8?B?SHhqSVhMZnNUZmFtU3ExYVdQZVRkMTRaT0g0M3VPU011QkNQS2hkWVUzM25m?=
 =?utf-8?B?RllkejFQcnNwZWVXcG9TZUtMbDNVMWRQTkFoUkNhK0p3dDFkMi9lWHM5ZmJp?=
 =?utf-8?B?bXAvYUc5SmtYSG1iaElWY1czcHlrSFMxRHBmU0F2VXduQ3ZIa0JGcWNIanJ5?=
 =?utf-8?B?TVhEUTk1NkkzRmZvOHNZY0htV2NObFFoMzd2Q3BqaHo2MTF5QUkwSjVXUmlh?=
 =?utf-8?B?UzBjZkU5VVo3MTVCT1BVazlQM3U2YmdsbEtJa1d3bVBMcUVjNG4vMUp1K3VE?=
 =?utf-8?B?elhmVGZnM2trMmJhSGtlSTF6eHJRaXFPYXNSZ05sc1Z5L3B5ZDJsaHVvbmpO?=
 =?utf-8?B?a3E0cFRRd3A2alNYQzhOdkZGRTVTcGsyV05OblBJZU9Bd0lrSmc1THNMcFlE?=
 =?utf-8?B?TlpKOEVNWTd6aFlmOTI3V3A2NUIzQ0FkaEFaanJQRUhwVXRsa2dRVW43TXVF?=
 =?utf-8?B?ZDl0UmpKNUdodmRMZVdVekc3K2xJZVhOTml5UFVOS1o2U0NSRGx2MjQ1bzFx?=
 =?utf-8?B?MDRsbHlJOHhzRFR1cVg0QXlQU3hQZ3dDYzhMd3NWa3NueklVS3N6d0x6cEdD?=
 =?utf-8?B?ODIwRzZKN1E5eWJPTnBnYWRhTDhFWHY1RUhBdnZOekxTazg0bDZyclhGa3ZY?=
 =?utf-8?B?RGpYbEI5RFB4WWJiWmVZcGM1QlhyOEhXN2h5MjdLcXE4S1E2dnMwQjhJVnVS?=
 =?utf-8?B?ODJWcHVkZjhBcCtnOTNvc1BGeHU2YmlHL0VyQmhtdkNmL2ZCZVg1Z1FSSE1I?=
 =?utf-8?B?Mm9DbWtOb0lEZkRIbklmNlNEV1E0WFhTT1BDNDF3NFF4OGFiODQ0QkdmM0FB?=
 =?utf-8?B?SzlQWGJ3OGtmVW8reStkNVVadzZ1bTdsZEhWbnJ2WldIM1ZydEdiZjZHYkEz?=
 =?utf-8?B?eW5tR0VoZGNERTBVbGp5ZmVxL094anV4RGNLdHMwalgwNDdGT1dXdi8rSEVQ?=
 =?utf-8?B?L2hTSTI3cGJrdHFsMCtWL3NRZUZBZCtCZHh0VUFGYlYwZlc1ZHovR21FR1Nx?=
 =?utf-8?B?N0NRQXNpL252dXhGdnEyVmlETGpCMVZQZmlQOHBqTWppcWlsT3UzUXRPckNj?=
 =?utf-8?B?a1A4cmlJdWFtbUJoMUd5VVVJWHBiTCtEQStpbTZVSzJnTS9QelgyUG84clVn?=
 =?utf-8?B?UTQwdE5UWmFwU01KdUFnMHcrMU1KRFV0eU1CRWpjRk9XMXR3dXVEbEU1d2Zp?=
 =?utf-8?B?SnJYMXhDbU4xMXIvUENOWDZCQzcxZVNoQ2VzTTN6cjdyUGt1OUlka0dENkNw?=
 =?utf-8?B?MHdsNVc4bTVBVnB4clF4a01DY2hvNndKV0kzbzd5aFJwMG5pYVIvTFlnYzJT?=
 =?utf-8?B?dUdPWEd5R2FEYUQ5dnpUVGtkclJzQlFUZHJCZkI3d3IyQWo1QXBZZHhONUY5?=
 =?utf-8?B?Z3V2VllhS08reEhVSENMQjFHSkh4aWNSdTNTVDl4R05ycDFhOUZYMjAzU2Y2?=
 =?utf-8?B?S3ZlWlJhNTZ5bWJwSmNmRnVwRmdnYmYyUEduVUcxRGFLdHptdUJKU2FVUEw0?=
 =?utf-8?B?Mmc9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 7f5618f7-035e-40ee-2a25-08db0bab8f6e
X-MS-Exchange-CrossTenant-AuthSource: CY4PR11MB1862.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Feb 2023 21:12:47.9387
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: TlMKtUq1BQujH1ZunjCDqZXrJvR0y22Iw5TGS/aOz9CvUizPH7XtUcGhO/X5YiMMrYT0Gl9w8yUwWn1OS1Tf8w/3HI2L3p5E253a0WIk/vw=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS0PR11MB6397
X-OriginatorOrg: intel.com
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Alok,

On 2/10/2023 12:45 PM, ALOK TIWARI wrote:
> shall we need to define this function under -> #ifndef CONFIG_PCI_MSI
> 
> #ifndef CONFIG_PCI_MSI
> 
> +static inline struct msi_map
> +pci_msix_alloc_irq_at(struct pci_dev *dev, unsigned int index,
> +              const struct irq_affinity_desc *affdesc)
> +{
> +    struct msi_map map = { .index = -ENOSYS };
> +
> +    return map;
> +}
> +
> +static inline void pci_msix_free_irq(struct pci_dev *pdev, struct msi_map map)
> +{
> +}
> +#endif

No need. include/linux/pci.h already has those definitions.

include/linux/pci.h already has:

#ifdef CONFIG_PCI_MSI

...

#else

... 
/*  new function definitions will be inserted here */
...

#endif


Reinette