From:   Vladimir Oltean <vladimir.oltean@nxp.com>
To:     netdev@vger.kernel.org
Cc:     linux-kernel@vger.kernel.org, Michal Kubecek <mkubecek@suse.cz>,
        Vinicius Costa Gomes <vinicius.gomes@intel.com>,
        Xiaoliang Yang <xiaoliang.yang_1@nxp.com>,
        Kurt Kanzenbach <kurt@linutronix.de>,
        Rui Sousa <rui.sousa@nxp.com>,
        Ferenc Fejes <ferenc.fejes@ericsson.com>,
        Pranavi Somisetty <pranavi.somisetty@amd.com>,
        Harini Katakam <harini.katakam@amd.com>,
        UNGLinuxDriver@microchip.com, Petr Machata <petrm@nvidia.com>,
        Ido Schimmel <idosch@nvidia.com>,
        Aaron Conole <aconole@redhat.com>
Subject: [RFC PATCH net-next] selftests: forwarding: add a test for MAC Merge layer
Date:   Sat, 11 Feb 2023 00:12:43 +0200
Message-Id: <20230210221243.228932-1-vladimir.oltean@nxp.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?sjBI7erZ17vDCEIOSXD0PIEkSVtMqi3wGNM+ZS0/C6RFQ5WURq+IOTVLHFWS?=
 =?us-ascii?Q?oAc26SskjUkXc2XoCfheYxlW7s3Psg9shUY+Zvd9Wa5WRTyQquwOwRsBZ1mk?=
 =?us-ascii?Q?xebe6bhoBSCjFdCzvhCEF3gdJ3HNup0cDFPDr4v4+t2pgFprGl+UDzee9qCA?=
 =?us-ascii?Q?LZH7wnnoISIOfE+31rQZ8UOU5iWmsk7w0UJr9OAvzTbRGY12aeLooahNm0oV?=
 =?us-ascii?Q?/29PcEJQbPYmsYaLK3UNVo11cr9oCEfS1PBo54vm/FdYmVDvl0qkArUIhr0C?=
 =?us-ascii?Q?FwP3M7wAP2C8v0VXLfacnWIaLAY0BTBFfKLN8poy5y+XcUbTXjBdcOr0lxsj?=
 =?us-ascii?Q?IR/OvCuvF49FO8zif7ba+8u6BPhQ4DrH8aiywlnlfkAPvxNsMtPkN9Xk0pGO?=
 =?us-ascii?Q?FCtCzNcSW+Zg64BWkjytIaUqkGPugEJ99imyJA7MxxtPR820SlLqssd/YXZG?=
 =?us-ascii?Q?imZ7JFpDoeQjkbGGAFjJFdAg86U7ELZ5rgcLE+Gv3gfSaqSZ+16DAuayCLTF?=
 =?us-ascii?Q?4lPbbrpS4gj2H/q+mgQrwau3EfwDLG+J0Oa/ooF+DWLa3nXdbwNjNICMLlsi?=
 =?us-ascii?Q?2g4AGQYFyYqMKptwPlfHDWKGvsTD7qwGnYE6Vy1aspmmUURSdaSGfSjNN5SW?=
 =?us-ascii?Q?dQM5yc6RKjNpVcobjb6FukNH2X4xLnRcpz0hlXt2sFwB2HSBwad9bCBsjUx6?=
 =?us-ascii?Q?WVOVKWqvA1Vp7jIrXBG4JrdYC+wWKb72FJiGMnUCBDsxbnIgHm1/k0iQTfCW?=
 =?us-ascii?Q?CzwpfVIfEciyVaZw4LC7IdGSmIbJp4ndEFaRrJlEcePZnKImJjcEfdm6cF6P?=
 =?us-ascii?Q?5i/X4rwOKE3Mti7RPETQ9gl9SMzivMDwDSg/4uWsB+cdi2s9fYBX3MK84gKr?=
 =?us-ascii?Q?g0B4AY0XbN1eUO8thOvHSEFDRQZbn49ifgGNSflajAdKOA0hQzG/ucW2zk2S?=
 =?us-ascii?Q?n7YvVjydBtZuxQnNGyjnlQJQf/TQ0IsQYCKYRdkwm4gCT2Hq36N2XvojQ1CY?=
 =?us-ascii?Q?3iWeryNiUv65paBcp28gU/hjxDhHCme1cBQW13dfs/Ob9wNcF0bxA3r03nr5?=
 =?us-ascii?Q?EkYpwKX2b9T72XP7vsYjeOAEuoJv1cWKQbu9ZXfofiz29NZU4Uaa3nCup0MZ?=
 =?us-ascii?Q?reEFfCLttmZnT36mCCU7hfIaissOlcifZId3s3HHdAhhGrFHTYdamzy39N3a?=
 =?us-ascii?Q?27louHhb2snAj+IFKzj/DBlYDiSUDxkIH/NJ1UzFIv9gS3uGL/KZepC5GbXm?=
 =?us-ascii?Q?pZl0dYa1WANXIInNhBsD4dl9tKtTduZgjjRKU+xxdADYKoeVXtr7SjrXcNrF?=
 =?us-ascii?Q?oOtFEVx12Zvzm0koq56TPU3EbGKzt9rudVvBmIFh+gvUiFCY2C5X2xECgIB3?=
 =?us-ascii?Q?cbY76fRKrk5ITGdjvSFBvkOj6c8IXKTLIwbBkIPTYQa6RqV9Fr+5NcXipq4m?=
 =?us-ascii?Q?15qfKqXGxUFChFsBsBlIqIjTPMaP7MErM5pc3TsmH8Z0J6i5VswoGkAucqYK?=
 =?us-ascii?Q?hKV1p9F4gRx4moJ2qxAr0ZOYzM0Cic62cyLbKNP/1EOfArTZGItzld2jeUXL?=
 =?us-ascii?Q?QWMjDmUQxQshtha+H2TrZQEpItpjvkze+Lbdi/jd8Jlff7WRJiG28NVQVk2/?=
 =?us-ascii?Q?bg=3D=3D?=
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 12991387-62ca-4130-34db-08db0bb3f75f
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5136.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Feb 2023 22:12:58.2351
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: qKX2ofNTTj3wK+9USrO5VtqJ3XqWYu3gwQ1DZytuArHklybmHKKTITA8YsgcX3Az2+vilDXltynjDG1UPQuk9Q==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU2PR04MB8840
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

The MAC Merge layer (IEEE 802.3-2018 clause 99) does all the heavy
lifting for Frame Preemption (IEEE 802.1Q-2018 clause 6.7.2), a TSN
feature for minimizing latency.

Preemptible traffic is different on the wire from normal traffic in
incompatible ways. If we send a preemptible packet and the link partner
doesn't support preemption, it will drop it as an error frame and we
will never know. The MAC Merge layer has a control plane of its own,
which can be manipulated (using ethtool) in order to negotiate this
capability with the link partner (through LLDP).

Actually the TLV format for LLDP solves this problem only partly,
because both partners only advertise:
- if they support preemption (RX and TX)
- if they have enabled preemption (TX)
so we cannot tell the link partner what to do - we cannot force it to
enable reception of our preemptible packets.

That is fully solved by the verification feature, where the local device
generates some small probe frames which look like preemptible frames
with no useful content, and the link partner is obliged to respond to
them if it supports the standard. If the verification times out, we know
that preemption isn't active in our TX direction on the link.

Having clarified the definition, this selftest exercises the manual
(ethtool) configuration path of 2 link partners (with and without
verification), and the LLDP code path, using the openlldp project.

This is not really a "forwarding" selftest, but I put it near the other
"ethtool" selftests.

Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp.com>
---
This is more for the sake of the discussion, because neither the ethtool
nor the openlldp changes for MM were accepted yet.

Not sure if this is the best way to integrate lldpad into a kselftest,
given the fact that systemd starts it with a persistent configuration
file.

 .../testing/selftests/net/forwarding/Makefile |   1 +
 .../selftests/net/forwarding/ethtool_mm.sh    | 174 ++++++++++++++++++
 tools/testing/selftests/net/forwarding/lib.sh |   9 +
 3 files changed, 184 insertions(+)
 create mode 100755 tools/testing/selftests/net/forwarding/ethtool_mm.sh

diff --git a/tools/testing/selftests/net/forwarding/Makefile b/tools/testing/selftests/net/forwarding/Makefile
index 91201ab3c4fc..7d95990e18ce 100644
--- a/tools/testing/selftests/net/forwarding/Makefile
+++ b/tools/testing/selftests/net/forwarding/Makefile
@@ -15,6 +15,7 @@ TEST_PROGS = bridge_igmp.sh \
 	custom_multipath_hash.sh \
 	dual_vxlan_bridge.sh \
 	ethtool_extended_state.sh \
+	ethtool_mm.sh \
 	ethtool.sh \
 	gre_custom_multipath_hash.sh \
 	gre_inner_v4_multipath.sh \
diff --git a/tools/testing/selftests/net/forwarding/ethtool_mm.sh b/tools/testing/selftests/net/forwarding/ethtool_mm.sh
new file mode 100755
index 000000000000..b66db9419a27
--- /dev/null
+++ b/tools/testing/selftests/net/forwarding/ethtool_mm.sh
@@ -0,0 +1,174 @@
+#!/bin/bash
+# SPDX-License-Identifier: GPL-2.0
+
+ALL_TESTS="
+	manual_with_verification
+	manual_without_verification
+	lldp
+"
+
+NUM_NETIFS=2
+REQUIRE_MZ=no
+source lib.sh
+
+# Borrowed from mlxsw/qos_lib.sh, message adapted.
+bail_on_lldpad()
+{
+	if systemctl is-active --quiet lldpad; then
+		cat >/dev/stderr <<-EOF
+		WARNING: lldpad is running
+
+			lldpad will likely autoconfigure the MAC Merge layer,
+			while this test will configure it manually. One of them
+			is arbitrarily going to overwrite the other. That will
+			cause spurious failures (or, unlikely, passes) of this
+			test.
+		EOF
+		exit 1
+	fi
+}
+
+manual_with_verification()
+{
+	check_ethtool_mm_support
+	bail_on_lldpad
+
+	ethtool --set-mm $h1 verify-enabled on tx-enabled on
+
+	# Wait for verification to finish
+	sleep 1
+
+	ethtool --json --show-mm $h1 | jq -r '.[]."verify-status"' | \
+		grep -q 'SUCCEEDED'
+	check_err "$?" "Verification did not succeed"
+
+	ethtool --json --show-mm $h1 | jq -r '.[]."tx-active"' | grep -q 'true'
+	check_err "$?" "pMAC TX is not active"
+
+	log_test "Manual configuration with verification"
+}
+
+manual_without_verification()
+{
+	check_ethtool_mm_support
+	bail_on_lldpad
+
+	ethtool --set-mm $h2 verify-enabled off tx-enabled on
+
+	ethtool --json --show-mm $h2 | jq -r '.[]."verify-status"' | \
+		grep -q 'DISABLED'
+	check_err "$?" "Verification is not disabled"
+
+	ethtool --json --show-mm $h2 | jq -r '.[]."tx-active"' | grep -q 'true'
+	check_err "$?" "pMAC TX is not active"
+
+	log_test "Manual configuration without verification"
+}
+
+lldp_change_add_frag_size()
+{
+	local add_frag_size=$1
+
+	lldptool -T -i $h1 -V addEthCaps addFragSize=$add_frag_size >/dev/null
+	# Wait for TLVs to be received
+	sleep 1
+	lldptool -i $h2 -t -n -V addEthCaps | \
+		grep -q "Additional fragment size: $add_frag_size"
+}
+
+lldp()
+{
+	require_command lldptool
+	bail_on_lldpad
+
+	systemctl start lldpad
+
+	# Configure the interfaces to receive and transmit LLDPDUs
+	lldptool -L -i $h1 adminStatus=rxtx >/dev/null
+	lldptool -L -i $h2 adminStatus=rxtx >/dev/null
+
+	# Enable the transmission of Additional Ethernet Capabilities TLV
+	lldptool -T -i $h1 -V addEthCaps enableTx=yes >/dev/null
+	lldptool -T -i $h2 -V addEthCaps enableTx=yes >/dev/null
+
+	# Wait for TLVs to be received
+	sleep 1
+
+	lldptool -i $h1 -t -n -V addEthCaps | \
+		grep -q "Preemption capability active"
+	check_err "$?" "$h1 pMAC TX is not active"
+
+	lldptool -i $h2 -t -n -V addEthCaps | \
+		grep -q "Preemption capability active"
+	check_err "$?" "$h2 pMAC TX is not active"
+
+	lldp_change_add_frag_size 0
+	check_err "$?" "addFragSize 0"
+
+	lldp_change_add_frag_size 1
+	check_err "$?" "addFragSize 1"
+
+	lldp_change_add_frag_size 2
+	check_err "$?" "addFragSize 2"
+
+	lldp_change_add_frag_size 3
+	check_err "$?" "addFragSize 3"
+
+	systemctl stop lldpad
+
+	log_test "LLDP"
+}
+
+h1_create()
+{
+	ip link set dev $h1 up
+
+	ethtool --set-mm $h1 pmac-enabled on tx-enabled off verify-enabled off
+}
+
+h2_create()
+{
+	ip link set dev $h2 up
+
+	ethtool --set-mm $h2 pmac-enabled on tx-enabled off verify-enabled off
+}
+
+h1_destroy()
+{
+	ethtool --set-mm $h1 pmac-enabled off tx-enabled off verify-enabled off
+
+	ip link set dev $h1 down
+}
+
+h2_destroy()
+{
+	ethtool --set-mm $h2 pmac-enabled off tx-enabled off verify-enabled off
+
+	ip link set dev $h2 down
+}
+
+setup_prepare()
+{
+	h1=${NETIFS[p1]}
+	h2=${NETIFS[p2]}
+
+	h1_create
+	h2_create
+}
+
+cleanup()
+{
+	pre_cleanup
+
+	h2_destroy
+	h1_destroy
+}
+
+trap cleanup EXIT
+
+setup_prepare
+setup_wait
+
+tests_run
+
+exit $EXIT_STATUS
diff --git a/tools/testing/selftests/net/forwarding/lib.sh b/tools/testing/selftests/net/forwarding/lib.sh
index d47499ba81c7..30311214f39f 100755
--- a/tools/testing/selftests/net/forwarding/lib.sh
+++ b/tools/testing/selftests/net/forwarding/lib.sh
@@ -129,6 +129,15 @@ check_ethtool_lanes_support()
 	fi
 }
 
+check_ethtool_mm_support()
+{
+	ethtool --help 2>&1| grep -- '--show-mm' &> /dev/null
+	if [[ $? -ne 0 ]]; then
+		echo "SKIP: ethtool too old; it is missing MAC Merge layer support"
+		exit $ksft_skip
+	fi
+}
+
 check_locked_port_support()
 {
 	if ! bridge -d link show | grep -q " locked"; then
-- 
2.34.1