Message-ID: <6fa247b53740ca760a608e1446f95c95.sboyd@kernel.org>
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
In-Reply-To: <20230206073101.14796-1-quic_kathirav@quicinc.com>
References: <20230206073101.14796-1-quic_kathirav@quicinc.com>
Subject: Re: [PATCH V2] clk: qcom: ipq5332: mark GPLL4 as critical temporarily
From:   Stephen Boyd <sboyd@kernel.org>
Cc:     quic_varada@quicinc.com, quic_srichara@quicinc.com,
        Kathiravan T <quic_kathirav@quicinc.com>
To:     Kathiravan T <quic_kathirav@quicinc.com>, agross@kernel.org,
        andersson@kernel.org, konrad.dybcio@linaro.org,
        linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org,
        linux-kernel@vger.kernel.org, mturquette@baylibre.com
Date:   Fri, 10 Feb 2023 14:14:47 -0800
User-Agent: alot/0.10
Precedence: bulk

Quoting Kathiravan T (2023-02-05 23:31:01)
> diff --git a/drivers/clk/qcom/gcc-ipq5332.c b/drivers/clk/qcom/gcc-ipq533=
2.c
> index c8a5fa1bafca..2e043d2d0598 100644
> --- a/drivers/clk/qcom/gcc-ipq5332.c
> +++ b/drivers/clk/qcom/gcc-ipq5332.c
> @@ -127,6 +127,16 @@ static struct clk_alpha_pll gpll4_main =3D {
>                         .parent_data =3D &gcc_parent_data_xo,
>                         .num_parents =3D 1,
>                         .ops =3D &clk_alpha_pll_stromer_ops,
> +                       /*
> +                        * There are no consumers for this GPLL in kernel=
 yet,
> +                        * (will be added soon), so the clock framework
> +                        * disables this source. But some of the clocks
> +                        * initialized by boot loaders uses this source. =
So we
> +                        * need to keep this clock ON. Add the CRITICAL f=
lag
> +                        * so the clock will not be disabled. Once the co=
nsumer
> +                        * in kernel is added, we can get rid off this fl=
ag.

s/off/of/

Does CLK_IGNORE_UNUSED work the same? It doesn't sound like a critical
clk from the description of the comment.

> +                        */
> +                       .flags =3D CLK_IS_CRITICAL,
>                 },
>         },