MIME-Version: 1.0
References: <1675944939-22631-1-git-send-email-ssengar@linux.microsoft.com>
 <1675944939-22631-6-git-send-email-ssengar@linux.microsoft.com>
 <CAL_JsqK0WgWm-mG=fYyDVAi4uhL+fM0OD7KEF+xYYOOGNX8-oQ@mail.gmail.com> <20230209174641.GB1346@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net>
In-Reply-To: <20230209174641.GB1346@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net>
From:   Rob Herring <robh+dt@kernel.org>
Date:   Fri, 10 Feb 2023 16:37:28 -0600
Message-ID: <CAL_JsqK+4ecEmGyo0jVs3B-E6Rjj4Lo8vB0En6pEUR1P4cRXpA@mail.gmail.com>
Subject: Re: [PATCH v5 5/5] Driver: VMBus: Add device tree support
To:     Saurabh Singh Sengar <ssengar@linux.microsoft.com>
Cc:     krzysztof.kozlowski+dt@linaro.org, kys@microsoft.com,
        haiyangz@microsoft.com, wei.liu@kernel.org, decui@microsoft.com,
        daniel.lezcano@linaro.org, tglx@linutronix.de,
        virtualization@lists.linux-foundation.org,
        devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
        linux-hyperv@vger.kernel.org, mikelley@microsoft.com,
        dphadke@linux.microsoft.com
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Thu, Feb 9, 2023 at 11:46 AM Saurabh Singh Sengar
<ssengar@linux.microsoft.com> wrote:
>
> On Thu, Feb 09, 2023 at 09:50:31AM -0600, Rob Herring wrote:
> > On Thu, Feb 9, 2023 at 6:15 AM Saurabh Sengar
> > <ssengar@linux.microsoft.com> wrote:
> > >
> > > Update the driver to support device tree boot as well along with ACPI.
> >
> > Devicetree

[...]

> > > +       for_each_of_range(&parser, &range) {
> > > +               struct resource *res;
> > > +
> > > +               res = kzalloc(sizeof(*res), GFP_ATOMIC);
> > > +               if (!res)
> > > +                       return -ENOMEM;
> > > +
> > > +               res->name = "hyperv mmio";
> > > +               res->flags = IORESOURCE_MEM | IORESOURCE_MEM_64;
> > > +               res->start = range.pci_addr;
> >
> > This is not PCI. It's a union, so use 'bus_addr' instead.
> >
> > But wait, resources and IORESOURCE_MEM are *CPU* addresses. You need
> > cpu_addr here. Your DT happens to do 1:1 addresses so it happens to
> > work either way.
>
> bus_addr works for us, will send V6

Sigh. bus_addr may work, but is wrong as I explained.

And you've already sent v6... Please slow down your pace with sending
new versions. 4 versions in a week is too much. Give others time to
comment and me to respond to discussions. Like a week...

Rob