Message-ID: <03414cfb-1f82-0422-73e7-4e5b2479bc5e@intel.com>
Date:   Fri, 10 Feb 2023 15:21:01 -0800
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Firefox/102.0 Thunderbird/102.6.1
Subject: Re: [PATCH v3 1/3] x86/resctrl: Factor rdtgroup lock for multi-file
 ops
Content-Language: en-US
To:     Peter Newman <peternewman@google.com>, <fenghua.yu@intel.com>
CC:     <Babu.Moger@amd.com>, <bp@alien8.de>,
        <dave.hansen@linux.intel.com>, <eranian@google.com>,
        <gupasani@google.com>, <hpa@zytor.com>, <james.morse@arm.com>,
        <linux-kernel@vger.kernel.org>, <mingo@redhat.com>,
        <skodak@google.com>, <tony.luck@intel.com>, <tglx@linutronix.de>,
        <x86@kernel.org>
References: <20230125101334.1069060-1-peternewman@google.com>
 <20230125101334.1069060-2-peternewman@google.com>
From:   Reinette Chatre <reinette.chatre@intel.com>
In-Reply-To: <20230125101334.1069060-2-peternewman@google.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?SUlDVjRpWjQzL3ppK1JaWEllWTI4MTFGTE1ZazBVTENPZHZ3OVVtVUFZUDlG?=
 =?utf-8?B?TzRLWEE4OHhlL2xsMzdUeWJRNCtBVldTVDJMTnJUVE1QT3VYN1pPbmFGV2Zo?=
 =?utf-8?B?elBuR0lLQi9IbnpFbUNvSUFmNEFPRGtyNmdITnpFckl5emgrL1RTS0Y3U0hT?=
 =?utf-8?B?eFZnRThscWFjcTFiTWNTSzRSY2kyWWxreUduZExSVlY2SE15cEd0N01mVlhZ?=
 =?utf-8?B?QmxaVXN0My8weUJESUJaMnNubWRQZ0RidWtWWWdicVZYRmhQdUlEZ2dqS1I5?=
 =?utf-8?B?VVlXaXZOdCsyWVNGSHF3aVhiWTh1YnQwcDdHck9saENiVWhYcDdkY3pmamVY?=
 =?utf-8?B?RlFmUUlWTWtGZExLK3lFSGExNWxGODY0NExzVm5oWDZJVUVqbENmZmpLaXdX?=
 =?utf-8?B?YzV4Um9pa0llbXZobmwwYzZ2elphQVFpUDU5K2NRT3p5OFFqWnpsL0RTTVo5?=
 =?utf-8?B?N0V0V3cwVktZdGxNYzBFU001NHFqZ082Q3c1eEFrWTBOM0JDVS9weGtjOU5Y?=
 =?utf-8?B?aUV6TVhZNWl1bXBSWXlMNndUc1Y4ejZoUzV1L0JGOVFWN2tueC9tcmdFTGVP?=
 =?utf-8?B?clVienNtaWp3L1pXbXJtWDlzazVwZWltQ0Q2dnFaRUFmeWJITWpJUjZ2cERG?=
 =?utf-8?B?QlM5TE91TzZJYy9PQUl1Z0lnZUh4U0lIOHljUmo1NHk0enZJKzl2M29BUGhG?=
 =?utf-8?B?NldtdHNCTXcwQlh2RDVvWGVxc0RUZlBVOVpmNWZ2QWV4Q0NLaDQwT2hvOE9B?=
 =?utf-8?B?Q3pTQXNDMnE3aHEyVkhiN0lwbC9GRGsxamxJMlY1S3p1RXp4SlQyOUdPRStm?=
 =?utf-8?B?WnFkV1dEdUU1NjJJTC9JN0NONHFPVnJiQnFIQi8xaDZaNUFubC9MNkpRWkg2?=
 =?utf-8?B?M280a0pIRWlEemlrUFNHc3FVMURzVkFIUk53WDRvcXBBcjUwSUdPb055N2N1?=
 =?utf-8?B?Zk11VGxDdjBnQTNSS3l4UUt6OU14dWhzbXlZYit3NEFiTExYbGE2UEIvUGcw?=
 =?utf-8?B?YWtxcXJMRGdYbko2VEJWbHlPSlYxbDkxVWVGSXVBNkNidk11MkZLaU9JSTVm?=
 =?utf-8?B?dk54eXZxNXVPeXdCL1pLWS9zWTlyQzIrRDFsNTZtWGk0TGlZY2p4aEppaDA1?=
 =?utf-8?B?TkxoL3ZxSlFBMEV2S214NjVlbzM3SVZWMXk3UmtXYTVmd1BFeS95WEZjekhr?=
 =?utf-8?B?MXREUGZOQU5SWXZYVEVveHpJTXJzNlZuUDFUckZIUXg2ZWJzTUIzb1FGTld2?=
 =?utf-8?B?cGpLempHdFhmNTBQQXF3U0J2MGVaYnRuQzl5U3NNTm9IaG1SU3dYR0liZW55?=
 =?utf-8?B?VWRkU0lzNG9yUzJ4YzRDSGhrSEtkSkZneXlwYkI1WVR5K3ZobTN3Y1BidEg5?=
 =?utf-8?B?VXhMbmorZGRFRFNsWSsvRzBxU1lNeU8wb2xWa1R0VlQyUGdMVS9wTWVxVzBL?=
 =?utf-8?B?RnZzbVJLQXBhcjc5Rzk5OE9SRVFmS1RhSGw0N2RMWkl1b2VLRksyV2RkYzd3?=
 =?utf-8?B?bU43bWk1N250VG8yWkRVU2QybjhoU0xPSCtWT2M1L0gyci81WVpFQmJxR1pk?=
 =?utf-8?B?SHNIVFFZWTRmM2hIcjR1N29PU0xmUVBFblhDV01TSGNOY0tSRnRhR3pra3JZ?=
 =?utf-8?B?MlV0YU5TejJNTTJ5amdkcndIRStMdHltL2NHUXVCMmRzSnZxaUhObGJteW8r?=
 =?utf-8?B?dGNTbEErcmRBZktxY09LUFI0QlNBd24wTmc3UzBzYVdRdGtISG84dERXQ0Ji?=
 =?utf-8?B?eFlOWjF4Z2xXUU1BZy85ckc0bko1dUJpSGprSTJBYXlpSXpUR2ljZU82VXJF?=
 =?utf-8?B?amxrUmxtZGpuTXFFckdvbmpRTUk3ZmVtT0pxWGJlN2wrRVl1eS9YZGpTWkkr?=
 =?utf-8?B?RWhJa3BYUGQvd1FYV2F5WFZBczZJK21aNkpsWU40L1dab1BDQlAvUmZnMnN6?=
 =?utf-8?B?T2RycnozMUNDazNLd3MwdHZ4T24wWTdYYlE2SnRXVllWc2dIa0pqVGlhaFBW?=
 =?utf-8?B?WU1QKzhPMmZPbUdpM0w2TzB4VkFEVW0ycEs2cFVTRkVGTlBzam9vdVBJdzho?=
 =?utf-8?B?VDlHZm1ad2QxdTVIK3I3bjBuZ3FMK3c4OS9taC94Mkphbjd6dHdmbGtybUJT?=
 =?utf-8?B?TUN2MVJnTlhlNG9NUWUwckFTSkxPUld5aThNc1JsUy9JOG1aZHYzU0ZQMnQy?=
 =?utf-8?B?TkE9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: fe73fba0-6e97-4a31-7d3b-08db0bbd7b05
X-MS-Exchange-CrossTenant-AuthSource: CY4PR11MB1862.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Feb 2023 23:21:04.6551
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 5K4vdd3kCOXNd21tP0t977N2IPXIgNxvz805OEWi/eKQ6LBcEz18tJxU/s7Hz51x0+p5sr+xLSJUXVxVGnZszNTpUzbMDGoU5ALHIFkw97o=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR11MB7123
X-OriginatorOrg: intel.com
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Peter,

On 1/25/2023 2:13 AM, Peter Newman wrote:
> rdtgroup_kn_lock_live() can only release a kernfs lock for a single file

how about s/kernfs lock/kernfs reference/?

> before waiting on the rdtgroup_mutex, limiting its usefulness for
> operations on multiple files, such as rename.
> 
> Factor the work needed to respectively break and unbreak active
> protection on an individual file into rdtgroup_kn_{get,put}().
> 
> This should not result in any functional change.
> 

"should" has been a trigger word on occasion. You can just
write "No functional change." (also in second patch).

Reinette