Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5A0CEC636D7 for ; Sat, 11 Feb 2023 02:01:43 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229588AbjBKCBl (ORCPT ); Fri, 10 Feb 2023 21:01:41 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37248 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229437AbjBKCBj (ORCPT ); Fri, 10 Feb 2023 21:01:39 -0500 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1462E6C7C3; Fri, 10 Feb 2023 18:01:39 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 9751461CC8; Sat, 11 Feb 2023 02:01:38 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 75344C433D2; Sat, 11 Feb 2023 02:01:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1676080898; bh=R8cdpASP8dow1Rjwf5C3fVoWhvNrNqy3otJzWDY+6W0=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=me62q7azybO6+GX9LJGEYGDVkVujPhKGP1yhQKO/J2lA0ZtPiu2EI2+rh2apfzklL +rMdIclWAVt4Iay23VzdRnYSaWK27n3P24HwNR9YZ2JTcm5/Xv/u4iEGtOsBgk1rLD 6ZxOVTTRqgSLiCiBcNPS1inGpOMlH+Wk0YcOe9MztG3BL+cgbBPMUHTcISCf/n8HLl zqm1hYjG4LZJAD1IU9vV0RbWYLc+ZL1nntT95X8lx1KCsA/G6gsbt6xH7Gi0Mx6mBI JCJvB0PlnSFHvK2G+Y25HpCjN4bAOQzGVUGYyAJ/4f3gfJWNonB/8ZDbEW6twNHfI+ 4zHEIo+oOj6zA== Date: Fri, 10 Feb 2023 18:01:36 -0800 From: Jakub Kicinski To: Alexander Lobakin Cc: Alexei Starovoitov , Daniel Borkmann , Andrii Nakryiko , Toke =?UTF-8?B?SMO4aWxhbmQtSsO4cmdlbnNlbg==?= , Martin KaFai Lau , Song Liu , Jesper Dangaard Brouer , bpf@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH bpf] bpf, test_run: fix &xdp_frame misplacement for LIVE_FRAMES Message-ID: <20230210180136.101f8762@kernel.org> In-Reply-To: <20230209172827.874728-1-alexandr.lobakin@intel.com> References: <20230209172827.874728-1-alexandr.lobakin@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 9 Feb 2023 18:28:27 +0100 Alexander Lobakin wrote: > - struct xdp_frame frm; BTW could this be a chance to rename this? First time I read your commit msg I thought frm stood for "from".