IronPort-SDR: PIXoAO2x9GI4vV0s5ANg4XqI+8pPAyo7PB5nr/OiGbZXjXI2Lvg7Qzoo4XVkDV8RfwbAwEhLR4
 8N/eW2gOqeMOjvE1/ChGOywPdyannw+S4gqucrMwZIw09B3edr72KM1eIGiJ0uPaNrwk6gAghO
 xwA+m3TL2sG7I6xI8FIWDE5WnDkyAXN4HdEM3bQo5if0gkIXh02UqlBW0dzwRk2mCwcqkD7vQP
 2GjJErsArsZIz3JHIYkc5UGKK+MOM/ED9kTLS/Vw2vfr+xgL71dFvTbb4YxZgUbII/y3lDPPv9
 DOg=
IronPort-SDR: liLyZ7dzlGyHZoFGx4CR4YK7MUJh2T0SenRLKUhoLE75MWps66WnDuyBUyx2f4becOxL8dY5Ef
 Gaq82ow2D8O6Sz4h4zF4l3FNV/CalnhMyZVMIcOnElwn1WPS8NNMPgTcPBUeT6b2zobxU5U6dd
 gc1pS9z+vqNeQQYMVw+m6qSPCcEzISyx3VGdgRoYfOk33TAk235vxqDJW2jiWAph5J76gIjJcq
 w/a7gXpTj27Jq2KmbxrTWR3z+uWRZSRldWhnwSHKEkN0RQeMfPTgOOVCZciCcU4UyDQZgUNY7S
 Stk=
WDCIronportException: Internal
Message-ID: <dce110de-649d-cde8-9401-346675c95263@opensource.wdc.com>
Date:   Sat, 11 Feb 2023 12:11:48 +0900
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.7.1
Subject: Re: [PATCH] ata: libata-core: Disable READ LOG DMA EXT for Samsung
 MZ7LH
To:     Patrick McLean <chutzpah@gentoo.org>, linux-kernel@vger.kernel.org
Cc:     linux-ide@vger.kernel.org
References: <20230210215151.812839-1-chutzpah@gentoo.org>
Content-Language: en-US
From:   Damien Le Moal <damien.lemoal@opensource.wdc.com>
Organization: Western Digital Research
In-Reply-To: <20230210215151.812839-1-chutzpah@gentoo.org>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 2/11/23 06:51, Patrick McLean wrote:
> Samsung MZ7LH drives are spewing messages like this in to dmesg with AMD
> SATA controllers:
> 
> ata1.00: exception Emask 0x0 SAct 0x7e0000 SErr 0x0 action 0x6 frozen
> ata1.00: failed command: SEND FPDMA QUEUED
> ata1.00: cmd 64/01:88:00:00:00/00:00:00:00:00/a0 tag 17 ncq dma 512 out
>          res 40/00:01:01:4f:c2/00:00:00:00:00/00 Emask
>          0x4 (timeout)
> 
> Since this was seen previously with SSD 840 EVO drives in
> https://bugzilla.kernel.org/show_bug.cgi?id=203475 let's add the same
> fix for these drives as the EVOs have, since they likely have very
> similar firmwares.
> 
> Signed-off-by: Patrick McLean <chutzpah@gentoo.org>
> ---
>  drivers/ata/libata-core.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/drivers/ata/libata-core.c b/drivers/ata/libata-core.c
> index 2ea572628b1c..c4c89d24f84c 100644
> --- a/drivers/ata/libata-core.c
> +++ b/drivers/ata/libata-core.c
> @@ -4045,6 +4045,9 @@ static const struct ata_blacklist_entry ata_device_blacklist [] = {
>  	{ "Samsung SSD 870*",		NULL,	ATA_HORKAGE_NO_NCQ_TRIM |
>  						ATA_HORKAGE_ZERO_AFTER_TRIM |
>  						ATA_HORKAGE_NO_NCQ_ON_ATI },
> +	{ "SAMSUNG*MZ7LH*",		NULL,	ATA_HORKAGE_NO_NCQ_TRIM |
> +						ATA_HORKAGE_ZERO_AFTER_TRIM |
> +						ATA_HORKAGE_NO_NCQ_ON_ATI, },
>  	{ "FCCT*M500*",			NULL,	ATA_HORKAGE_NO_NCQ_TRIM |
>  						ATA_HORKAGE_ZERO_AFTER_TRIM },
>  

Looks OK, but ATA_HORKAGE_NO_NCQ_ON_ATI is for PCI vendor ID 1002h. AMD
also has vendor ID 1022h. Did you check you adapter vendor ID & tested
this patch ?

-- 
Damien Le Moal
Western Digital Research