IronPort-SDR: jjssRE0CutOIGI4xl0SUDHq7QBXutnLyG7GqxhX104aK3nMVf6D3WUnAmMTiEYzxiI6y1dLSyJ
 AnAISvpofnRwwEPfc8/zi8ENxwkbrXu44wwgeYPQashnVnv213IUuoKTjHl3OoQMQiVCIfKPL4
 8orbb/6rRIF8ImydRNJHBzuZKUTAqPBGwugXlNMM8+AvcEIh3TXaaAr5psU3WjOSOXVl6Rzdjk
 0loa3mWl1owarOs3SSYepsUu/zuV7VBoFfiABOy0nlJuJ48IXNX1dbBxB/en1Y8T2xESuo0Kjl
 xEs=
IronPort-SDR: M2tVw36DAIGDEWXde7tOKAb5wZpGVD9xcuHt6ip2NXNcL4G0To0UEl+oLUDIFjmh9MNILe8mdd
 ja9jAriAX4lS8FhSSLWtWYTNQTks3NjlFUnbvL9j3flKPTcdmyKyl/ZtyFM2TYRStFKdLtB6ED
 VEB7qYklU6jyf/bzcH5MxX2huCj+zkDu+nqzd/VIv9zhDYnBN6aiTkulWCNxCqMtdGfSLCuugK
 FT2ghNBK7Yfs19IGmZEY3iPHD60JxrHheoOEaoLtiL77JHhRdRYZZX8RfwzY0p3RCPLvwaRioY
 +Jk=
WDCIronportException: Internal
Message-ID: <d2a0c3bd-d7ef-85ff-6268-712c098e9d32@opensource.wdc.com>
Date:   Sat, 11 Feb 2023 12:12:23 +0900
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.7.1
Subject: Re: [PATCH] ata: libata-core: Disable READ LOG DMA EXT for Samsung
 MZ7LH
Content-Language: en-US
To:     Patrick McLean <chutzpah@gentoo.org>, linux-kernel@vger.kernel.org
Cc:     linux-ide@vger.kernel.org
References: <20230210215151.812839-1-chutzpah@gentoo.org>
From:   Damien Le Moal <damien.lemoal@opensource.wdc.com>
Organization: Western Digital Research
In-Reply-To: <20230210215151.812839-1-chutzpah@gentoo.org>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 2/11/23 06:51, Patrick McLean wrote:
> Samsung MZ7LH drives are spewing messages like this in to dmesg with AMD
> SATA controllers:
> 
> ata1.00: exception Emask 0x0 SAct 0x7e0000 SErr 0x0 action 0x6 frozen
> ata1.00: failed command: SEND FPDMA QUEUED
> ata1.00: cmd 64/01:88:00:00:00/00:00:00:00:00/a0 tag 17 ncq dma 512 out
>          res 40/00:01:01:4f:c2/00:00:00:00:00/00 Emask
>          0x4 (timeout)
> 
> Since this was seen previously with SSD 840 EVO drives in
> https://bugzilla.kernel.org/show_bug.cgi?id=203475 let's add the same
> fix for these drives as the EVOs have, since they likely have very
> similar firmwares.
> 
> Signed-off-by: Patrick McLean <chutzpah@gentoo.org>
> ---
>  drivers/ata/libata-core.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/drivers/ata/libata-core.c b/drivers/ata/libata-core.c
> index 2ea572628b1c..c4c89d24f84c 100644
> --- a/drivers/ata/libata-core.c
> +++ b/drivers/ata/libata-core.c
> @@ -4045,6 +4045,9 @@ static const struct ata_blacklist_entry ata_device_blacklist [] = {
>  	{ "Samsung SSD 870*",		NULL,	ATA_HORKAGE_NO_NCQ_TRIM |
>  						ATA_HORKAGE_ZERO_AFTER_TRIM |
>  						ATA_HORKAGE_NO_NCQ_ON_ATI },
> +	{ "SAMSUNG*MZ7LH*",		NULL,	ATA_HORKAGE_NO_NCQ_TRIM |

Are you sure about the upper case here for this drive model name ?

> +						ATA_HORKAGE_ZERO_AFTER_TRIM |
> +						ATA_HORKAGE_NO_NCQ_ON_ATI, },
>  	{ "FCCT*M500*",			NULL,	ATA_HORKAGE_NO_NCQ_TRIM |
>  						ATA_HORKAGE_ZERO_AFTER_TRIM },
>  

-- 
Damien Le Moal
Western Digital Research