Message-ID: <5945f254-0581-093b-168d-8cf2c0a34eab@oracle.com>
Date:   Sat, 11 Feb 2023 10:35:53 +0530
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.6.1
Subject: Re: [External] : Re: [PATCH] PCI: Fix build error when CONFIG_PCI_MSI
 disabled
To:     Reinette Chatre <reinette.chatre@intel.com>, bhelgaas@google.com,
        nathan@kernel.org, ndesaulniers@google.com, trix@redhat.com
Cc:     linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org,
        llvm@lists.linux.dev, tglx@linutronix.de, kevin.tian@intel.com,
        darwi@linutronix.de
References: <158e40e1cfcfc58ae30ecb2bbfaf86e5bba7a1ef.1675978686.git.reinette.chatre@intel.com>
 <333dee5b-6710-998c-bf3f-2cb1d676a7da@oracle.com>
 <af294def-fff7-469c-b8c6-a245ba641c2c@intel.com>
Content-Language: en-US
From:   ALOK TIWARI <alok.a.tiwari@oracle.com>
Organization: Oracle Corporation
In-Reply-To: <af294def-fff7-469c-b8c6-a245ba641c2c@intel.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ZGU2TWVjSUx5VDI5RzFFbmVKTzNKK011b25VZUNHVkJzUkhacFBIWGhwL1pE?=
 =?utf-8?B?M3JkV2ZmWVdHNFVoYTB0NGx6aDFlTlBNTXdaZXBkTHUwUzQ4ZXk1d1p1TVVi?=
 =?utf-8?B?TThFTERTZGMzSFNDSXFpbDhDSDV5TWlvakRFMlBVWjdHb0p4RGVBTXhCb0VK?=
 =?utf-8?B?WDlTRDA4L1dGV1ZXZC9Bc1F3SDZvSlIwYjd0di96dEJLdkdNNmRGL1ZhYlNu?=
 =?utf-8?B?aHFtMDBLWm0wQjNaMzJGUEcyTlVWTXROTzMwNFdNZDFmV205NVRscTliTURl?=
 =?utf-8?B?RDBxbzR0ejNsUVFBU1R2Y0NEUjJoRTlaY3MvREFTZS9sT25lV0xBaHkzSVN1?=
 =?utf-8?B?QnppUkVWdVdpQkVGY2pjQmErRnZYZVNadFZOREhVVHV4aHJBeDlraEFYenBh?=
 =?utf-8?B?ZmtOMTdVYSt3b1Y3cG5oeTlXL0ZmK2RZaXA1MEkvQU5BZ2pyeGNWQjVuK3ZE?=
 =?utf-8?B?SjRmNzEvUUx6MGtJNFBYRUdTQytSVkFkeW9DSGdkaDdZVUswZFd0aHVrTEpi?=
 =?utf-8?B?YlY3blNGSS9GYjhXd3JuVk1Fc3pheGxUUVp4RVN5dnNlaCszazVGSGlaaDl5?=
 =?utf-8?B?cExKQXlybkNiWTZ6OEt3cnh4U040bEFqSlhoWFAyMml4OUtLKzY4c2hrSGdn?=
 =?utf-8?B?VVdwbGJOTExrSHRJdGIzSzRtQkJhK1FUV09ZdEV3YSsxUFJtWmpoN2gvL1hv?=
 =?utf-8?B?dlVXK2VRbnBUYkhXSVVRNGlYU1U1NU9HQ25WTGhKZm41blRyaXFHMmV3UmtM?=
 =?utf-8?B?TFh5c24ybldlNUMwYmt6Zld4YWRRdmc0NjcyMzUxWmxjR1AxVUNKdlVVczc5?=
 =?utf-8?B?K0tlbUFlclNuNHJTUmo0ZXNYdkVnSEhQWlltTzdybmc3VHVHWk4rL2NlLzJM?=
 =?utf-8?B?bTVUUmpUb3YwSjc0RS9WQUdwMGY2MUwwRkRoT0hQaUZjdDRXVHRTWXJFaC9J?=
 =?utf-8?B?RVI5ZU5xWC96ZXVacTZtOVZVTjNDRE5OWW45dDhUM0NacHlPTkxXV0tFamZD?=
 =?utf-8?B?QjVZU0MrbGprTTVkMm90ck42a3Mrdmo0RlBwUk82eDZuS2QzVDk3M1RnV0R5?=
 =?utf-8?B?RmxTNSs0dHlucllmZEFKUXFJbHNDa2Vlc0dGNUZBY3dBVmw4SFFnWTZicUtt?=
 =?utf-8?B?RGNGazVqbjMrV2hXZndCR3I5UkZoWDRERmErZmtKZThvZjJEdWdMNk9DeE1J?=
 =?utf-8?B?Z2x2YS9ENkc4bXVuQm9rUnFUcndTZW8xL3p1S3BPcmc4K1M2NDVEaDMzN0hi?=
 =?utf-8?B?RmtJZjNYcTNjUEdMVjhlUUhQNXNWQnZvNWdrRUd3YjZoZ3VmSEZDYmZ3YkNR?=
 =?utf-8?B?ZlRUSTNSb094RFlFQ044bVlPcnNyQ3pIM0NjWFo4VjZEWVdFWEVHZkVOZkFH?=
 =?utf-8?B?eFhZeWdLRDlhMFVmbTVxZ3o1VEJRU2dKc25HZmVXR3l6V2xyTVoySjNiem5y?=
 =?utf-8?B?Q2tDK0p3RXU4ZXplRnYwbG12MlgyYWE3M2dLWm45ZFZoSTU4cVM0ZVAwekMz?=
 =?utf-8?B?bEovT1Y5d2hnMVhkSGZ2cWJHbGxIODNUKzBzOSt2aDVvOERCSVpIQkx2RGVy?=
 =?utf-8?B?WDllMmN6ZXBaUFRydGFZaWY3clJ1RVJzNnJZcmVFcm11eHJyQjgyeUF1MEI5?=
 =?utf-8?B?aGdpcGYwREZRZUphUUtLMTR5WjhYWGRaR1UzTVFTbHErZlZ2YS9lLzZLNG5R?=
 =?utf-8?B?NjYyZXE0VUJTWHEyU3lia0FJOElPL3FybmFuZWJQK3UzSFBydC9FMTdOd2Mx?=
 =?utf-8?B?OUNtMmptK3gwZDRaMmZlYmtrZ1NtMUxFVXUwc01UbDc1MXFTS1dkS2ZjTUha?=
 =?utf-8?B?YkVWNWxuOC9kN0RqdlI2RURRV0UwMlJNa0E0SHdDc1Z3Qldta0ltcDAycXZE?=
 =?utf-8?B?ZmxhVy9BWVoySXB2cllyZFJ1OUpJUFk2eklqYktXSmhnRXhaM2FSc1VpQ3Z5?=
 =?utf-8?B?N0pSUzRLaEdqSnViOEdIMGRlajFYL1VBUGMwMERJNlM4M0Z0TmxwRzRSR20x?=
 =?utf-8?B?czFsTDF0Y1NHSVpHV2lUR3ZFMHN4NjBVbzRBakxIMXZkVHlQTkZFS3pYdit0?=
 =?utf-8?B?SHE5S3luZzVWRkpFUnVIVnVzOG9KMExiSlNIQ1FVNmJGejhCTWExc0owWjdk?=
 =?utf-8?B?b0E3RW41Z0xXdVlGMExibHI3ZE4wbXVzWTlIODNQWFBmWlhlaC83WWE3Sm9T?=
 =?utf-8?B?VHc9PQ==?=
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: =?utf-8?B?Y3YrNjdlWTNsY1FYemplTjd2M2ZsTExOMFNxVDNqZTkvVG1VZGJiMzZuQzA5?=
 =?utf-8?B?NThqS004L3JKWlNGMlpEVGVoWHBhRlNFaU5wZHZyN2JhRU96bklsZnIrMm9V?=
 =?utf-8?B?VHBld3hBQ0RrWERPeFVLNE04Z0hXd1IxbUIrcC8rVWhkMFFCT0g3UnQzeEdr?=
 =?utf-8?B?dHY0SUxoaU5URlBDMmxEaFROWTY4Q0ZvRXl0eWFVaVE0YUxJL1JHdjBvWFN6?=
 =?utf-8?B?bUQ3MFE3aXFPVFh3RlJrbXJyQjBvQ3BVbnhlVE5pOTc4aVJFUzh3YU9lNk5n?=
 =?utf-8?B?dzNLdEpuYVBLV1pnVWsvd1E0SkNsSU84NU5qNkY0bDNtUDNPNjAyVjVUNmg2?=
 =?utf-8?B?VlhEaXUzUzJzRXd3a2Z5SGt1Q1k1Z0tMa1pXRmU1Wmt2M09kYXYxb2pzYUpj?=
 =?utf-8?B?RTI1MDZpN1M4aXZiRU4xa2JETVZMcGxuRXV6cHVDS2JhL3o4UFFSU1RsbW5U?=
 =?utf-8?B?b1dCRWRKOXRPZHptcEQwYUZwOTRidTlIWVRkZ1Azb2xvWTBIVjRxSHpycEFI?=
 =?utf-8?B?bE84b0hpeWlLd3hBWjdMR3MybGV6NHFMMXJWVVB0dU5DTVpqb2hudGNkWlpU?=
 =?utf-8?B?T1NWTjMxWFVIajg0eDkyYmdxejVkL3ZmSnA5akhFRWRMYnN3dXBTMDEwNzZU?=
 =?utf-8?B?SS83NzNhWW9IUHF3Qk1JYmZTdnRDZ25BUkdDTGd0RlIzR2R3MDIybTNOSUts?=
 =?utf-8?B?cGdPSHZqSlI2czc4dGwyZE1GUWNPaWlSTjdvVXVzYjJscnEyWVUzVXh2V0I1?=
 =?utf-8?B?Y2V3MkRuNzdOYmt3OWZxNHhmTTdzZGpveHFTSFhnclp2OFAxSzVvc09RSnBZ?=
 =?utf-8?B?K2FQWmd0dDQraERIMXlEbWNRNFVYOUFBWk85VXFhV1BoVzFLd090QkdadUpU?=
 =?utf-8?B?bGU3ekdaNmJ6ZDVCcFI2WjhuSk9yUjUyQ1lsNFV6WTdTT0VNenNLbkZ6c25Q?=
 =?utf-8?B?eTJhMS9XeXBFVmhOazRvY05NdURueHZIMmROa0tqVWwyOGduZzllQUpXb3hn?=
 =?utf-8?B?empDUlQ2UmFUZGdjdTYvdWVWRDZMZ1V3dDFrNzl4N0xUZ0crQkliei85eFNE?=
 =?utf-8?B?dU12OExoaSsxdjVYcWkrb2gzTG9NT21MdzB1clNNZlBKUDNqM0pUYmMrNVFD?=
 =?utf-8?B?dm83bWNYL1JxVkZhVmkyV05MejRTWmMxTy9ud05pUm5KSTMzV1dNM1FxemFt?=
 =?utf-8?B?VldkTWk3cko4T3RvSTR3Z05CUWNBVC9UMEd2bllPNnFFbFJMbTFhRjNkUjRv?=
 =?utf-8?B?NXM1WlhKUHd1cmdqcGJuck8vdURBcWl5OGhzb1RPR2pJT3c2Zz09?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: befd4fee-e226-4049-2ba2-08db0bedacf8
X-MS-Exchange-CrossTenant-AuthSource: PH0PR10MB4581.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Feb 2023 05:06:04.4687
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Bna674SXqM0YTAXaT3xEZkpHvmcXWz1J/2aQqncfDKzvMIipCk1dtVvsYx0LBFeNTB6j7XYqH3BqCets42t2yOXqbW6AMEfQyJW7t3QDivg=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR10MB4557
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.219,Aquarius:18.0.930,Hydra:6.0.562,FMLib:17.11.170.22
 definitions=2023-02-11_02,2023-02-09_03,2023-02-09_01
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 malwarescore=0 bulkscore=0 adultscore=0
 mlxlogscore=999 phishscore=0 spamscore=0 mlxscore=0 suspectscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2212070000
 definitions=main-2302110045
X-Proofpoint-GUID: Gb8gNu-mWBuASC-5_GcEubDq5O6ZRnp2
X-Proofpoint-ORIG-GUID: Gb8gNu-mWBuASC-5_GcEubDq5O6ZRnp2
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

if, new function going to part of #else case . that is absolutely fine.

but that is not present in given PATCH.

Thanks,

Alok

On 2/11/2023 2:42 AM, Reinette Chatre wrote:
> Hi Alok,
>
> On 2/10/2023 12:45 PM, ALOK TIWARI wrote:
>> shall we need to define this function under -> #ifndef CONFIG_PCI_MSI
>>
>> #ifndef CONFIG_PCI_MSI
>>
>> +static inline struct msi_map
>> +pci_msix_alloc_irq_at(struct pci_dev *dev, unsigned int index,
>> +              const struct irq_affinity_desc *affdesc)
>> +{
>> +    struct msi_map map = { .index = -ENOSYS };
>> +
>> +    return map;
>> +}
>> +
>> +static inline void pci_msix_free_irq(struct pci_dev *pdev, struct msi_map map)
>> +{
>> +}
>> +#endif
> No need. include/linux/pci.h already has those definitions.
>
> include/linux/pci.h already has:
>
> #ifdef CONFIG_PCI_MSI
>
> ...
>
> #else
>
> ...
> /*  new function definitions will be inserted here */
> ...
>
> #endif
>
>
> Reinette