MIME-Version: 1.0
References: <20230210173841.705783-1-sergio.paracuellos@gmail.com>
 <20230210173841.705783-3-sergio.paracuellos@gmail.com> <3ca26ba2-80f5-32a2-0357-d91c87efd1c0@arinc9.com>
In-Reply-To: <3ca26ba2-80f5-32a2-0357-d91c87efd1c0@arinc9.com>
From:   Sergio Paracuellos <sergio.paracuellos@gmail.com>
Date:   Sat, 11 Feb 2023 08:16:26 +0100
Message-ID: <CAMhs-H9eQo-F9G62yyMbRyjmnaTYsJjnYA0puuFb71jCcnq7LA@mail.gmail.com>
Subject: Re: [PATCH v3 2/4] mips: dts: ralink: mt7621: add phandle to system
 controller node for watchdog
To:     =?UTF-8?B?QXLEsW7DpyDDnE5BTA==?= <arinc.unal@arinc9.com>
Cc:     linux-watchdog@vger.kernel.org, wim@linux-watchdog.org,
        linux@roeck-us.net, robh+dt@kernel.org,
        krzysztof.kozlowski+dt@linaro.org, matthias.bgg@gmail.com,
        tsbogend@alpha.franken.de, p.zabel@pengutronix.de,
        linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
        linux-mips@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

Hi Ar=C4=B1n=C3=A7,

On Fri, Feb 10, 2023 at 6:47 PM Ar=C4=B1n=C3=A7 =C3=9CNAL <arinc.unal@arinc=
9.com> wrote:
>
> Could you also change the node name to watchdog@100? make dtbs_check
> points it out:
>
> wdt@100: $nodename:0: 'wdt@100' does not match '^watchdog(@.*|-[0-9a-f])?=
$'

Sure, let me add a small patch fixing this warning in the series.

>
> Thanks.
> Ar=C4=B1n=C3=A7

Best regards,
    Sergio Paracuellos

>
> On 10.02.2023 20:38, Sergio Paracuellos wrote:
> > To allow to access system controller registers from watchdog driver cod=
e
> > add a phandle in the watchdog 'wdt' node. This avoid using arch depende=
nt
> > operations in driver code.
> >
> > Signed-off-by: Sergio Paracuellos <sergio.paracuellos@gmail.com>
> > ---
> >   arch/mips/boot/dts/ralink/mt7621.dtsi | 1 +
> >   1 file changed, 1 insertion(+)
> >
> > diff --git a/arch/mips/boot/dts/ralink/mt7621.dtsi b/arch/mips/boot/dts=
/ralink/mt7621.dtsi
> > index 5ca40fd21..764916eaf 100644
> > --- a/arch/mips/boot/dts/ralink/mt7621.dtsi
> > +++ b/arch/mips/boot/dts/ralink/mt7621.dtsi
> > @@ -73,6 +73,7 @@ sysc: syscon@0 {
> >               wdt: wdt@100 {
> >                       compatible =3D "mediatek,mt7621-wdt";
> >                       reg =3D <0x100 0x100>;
> > +                     mediatek,sysctl =3D <&sysc>;
> >               };
> >
> >               gpio: gpio@600 {