Subject: Re: [PATCH] ubifs: make kobj_type structures constant
To:     =?UTF-8?Q?Thomas_Wei=c3=9fschuh?= <linux@weissschuh.net>,
        Richard Weinberger <richard@nod.at>
CC:     <linux-mtd@lists.infradead.org>, <linux-kernel@vger.kernel.org>
References: <20230210-kobj_type-ubifs-v1-1-052419f90fae@weissschuh.net>
From:   Zhihao Cheng <chengzhihao1@huawei.com>
Message-ID: <a445d84b-2f08-69bf-9b23-5b5c79031d65@huawei.com>
Date:   Sat, 11 Feb 2023 15:17:11 +0800
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101
 Thunderbird/68.5.0
MIME-Version: 1.0
In-Reply-To: <20230210-kobj_type-ubifs-v1-1-052419f90fae@weissschuh.net>
Content-Type: text/plain; charset="utf-8"; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk

在 2023/2/10 10:16, Thomas Weißschuh 写道:
> Since commit ee6d3dd4ed48 ("driver core: make kobj_type constant.")
> the driver core allows the usage of const struct kobj_type.
> 
> Take advantage of this to constify the structure definitions to prevent
> modification at runtime.
> 
> Signed-off-by: Thomas Weißschuh <linux@weissschuh.net>
> ---
>   fs/ubifs/sysfs.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
> 

Reviewed-by: Zhihao Cheng <chengzhihao1@huawei.com>

> diff --git a/fs/ubifs/sysfs.c b/fs/ubifs/sysfs.c
> index 06ad8fa1fcfb..4404ca4f2ce9 100644
> --- a/fs/ubifs/sysfs.c
> +++ b/fs/ubifs/sysfs.c
> @@ -74,13 +74,13 @@ static const struct sysfs_ops ubifs_attr_ops = {
>   	.show	= ubifs_attr_show,
>   };
>   
> -static struct kobj_type ubifs_sb_ktype = {
> +static const struct kobj_type ubifs_sb_ktype = {
>   	.default_groups	= ubifs_groups,
>   	.sysfs_ops	= &ubifs_attr_ops,
>   	.release	= ubifs_sb_release,
>   };
>   
> -static struct kobj_type ubifs_ktype = {
> +static const struct kobj_type ubifs_ktype = {
>   	.sysfs_ops	= &ubifs_attr_ops,
>   };
>   
> 
> ---
> base-commit: e544a07438522ab3688416e6e2e34bf0ee6d8755
> change-id: 20230210-kobj_type-ubifs-5790a3d46e97
> 
> Best regards,
>