Message-ID: <19b4a1e2-c8f8-dad1-51eb-c565fee405ee@oracle.com>
Date:   Sat, 11 Feb 2023 13:50:50 +0530
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.6.1
Subject: Re: [PATCH] scsi: target: core: Added a blank line after
 target_remove_from_tmr_list()
Content-Language: en-US
To:     Greg KH <gregkh@linuxfoundation.org>
Cc:     linux-scsi@vger.kernel.org, darren.kenny@oracle.com,
        michael.christie@oracle.com, linux-kernel@vger.kernel.org,
        stable@vger.kernel.org, martin.petersen@oracle.com,
        d.bogdanov@yadro.com, r.bolshakov@yadro.com,
        target-devel@vger.kernel.org
References: <20230210175521.1469826-1-alok.a.tiwari@oracle.com>
 <Y+dINRZ9ZKLhvT94@kroah.com>
From:   ALOK TIWARI <alok.a.tiwari@oracle.com>
Organization: Oracle Corporation
In-Reply-To: <Y+dINRZ9ZKLhvT94@kroah.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?WXM0UjZQNnZxL0h1ZjgwUXp5Q3hmQ2VucmZCMDlRZXlpNGVlamZLY1NVSUZT?=
 =?utf-8?B?VkFTY2JjT2Jqc1g5dENDbENuR2ZUMnVCaFpaSmpCblhLckhVcjhjeVc5WHpq?=
 =?utf-8?B?Q2lHUnpBSEduWHRuZk5GTkpOc0VNbllNNjJWVHVFZiswWDIvS01TcW0xSERI?=
 =?utf-8?B?WEcrYlNxQnkxbnd2WU5XSmtINzJGRnAxdW15ZndNa0t4VlJMY2UxamtnNU1F?=
 =?utf-8?B?SFZvSklxeXpYc1Y4RWtDT3VObTdPazZXNXFFdWJ4SlZsTlRrNXV6U1VKa2tl?=
 =?utf-8?B?UnI0ODI1TEdqNDZFMFVwVjRiNS9UaXhsZUMxNysraTNrT3FNbUJ6RGluVFl1?=
 =?utf-8?B?MzN3Zys1dWxiK3ByUUtzWkE2alJuTmk2NGhERGNvOTVUM0o0VENKc0wvcWhT?=
 =?utf-8?B?RStXOUFJbGlJWEZrbmJZTUFLMEM4MlRzMTJNV0ZqbytmWTMzalZlMncwL1JO?=
 =?utf-8?B?SXdncTNNbWhvdFNrNU5YdmhIK0VKOXNMMk9pbzJiS3VVZmhUbkwxUGZRRkRP?=
 =?utf-8?B?ZStkY1ZyZU1QK2Frc0dWOG1lWFRkbTA2V2VxMGFrR0lhYkpSQ1I2WlBTUlJM?=
 =?utf-8?B?dWtFcS8yUEpWSUc5U0FxNEpjamFTUDdIc21pcGFubWh4T3llNmsxZ3RhczJa?=
 =?utf-8?B?QXFCTnVRdEgwYlF4ZHh4TzdkekZTYXZtM3dSanRXS1BnamVXaXpzN0o5MUw4?=
 =?utf-8?B?dEl3ZUJVTTl2djhabVo1QU1LRDRrcjZOMTh0TlpoT2RKUWxlMko5bkI3SExB?=
 =?utf-8?B?SkVha1JpUjAxWDBHYU9QekhhYXdtZmk3M0hPak96dEtJK2NHeGI5cVdPWUwr?=
 =?utf-8?B?MmVOYzl3MDN5L29FczhqTWlVbFlFd1k3dDljSkxJSGw0azk4cE5GN2xKeGZk?=
 =?utf-8?B?TkZTNFNjbHFOWFNaamRvR3Z4bFhtVHRUcXhXaTZmR3kwTzAxK3VEcjd3b2hN?=
 =?utf-8?B?Z1BDTzltbExvU3drTHo3NHFRY29vbDBnZlE4VVIxZk9zVWx1a3FaQml5RC9V?=
 =?utf-8?B?ajMvZ1BwNDVzNi9ybTlGeGlNM0tTVlpTWFU3UlY4ejZ4Y0d5NWpCZDRBTkJN?=
 =?utf-8?B?RWhVM01ER1Fkalc0ZlFPdnhOeGpVVTcxdTdCTWhDdE50SlVEd3EybC9hWjBs?=
 =?utf-8?B?YTBkdWhsVTJDUGJEMVhybG12eVROSGwzZW42cUdVOTBwTWsyZmk5N2FMWWNI?=
 =?utf-8?B?cnN2Nmw5K0hMUFdmdjFSd2ZyaWVoSXN6RVBTTEl1ZGx5RjZxRHk1UlQ0VUJV?=
 =?utf-8?B?UU5Hd21KQVRrdjA4SUlJampMSnFtTjFQRTBKZDYwUkFXRUpjZldsZVA0d2Z4?=
 =?utf-8?B?ZWJQMDNzeFU1UXptSlc1cXZ2bFhHaEtjRGFIVXd6b2RjWkN2UUJ4Z0pHL2tC?=
 =?utf-8?B?dGxlcXlScEgxSjFkcDhmRGNQbXBhWEVGYURFNzVxY0FKT2ZYS1hOWk9Mb2NY?=
 =?utf-8?B?ZXplODdZa3F2dTZlM1FReitVVkZvRlBsb21pR05weEpNNGZXMmgvRmxsZENB?=
 =?utf-8?B?U1NmNGs3UVZ2enhlUEY4cHFhTldpQW9zd0V3aW9GeXA0NXFEVWx3ZTB5VVFY?=
 =?utf-8?B?NXkrMXE3NUNnRGlxVVc1eWIyTGI4S2tOMVBKOEd2STFVMGxTZXR2Zm5ITHVj?=
 =?utf-8?B?R29GTHFMVzJubHEvZW5XVTZuSjhjUFlmVlVYU3JLR28yRXgrdDh1SStBZXpD?=
 =?utf-8?B?WWV3cjRRdVA0blo4SXVLYU82ZFdIWjgvV0wyRjFLa05XbjY5WTZKM0xQUWhv?=
 =?utf-8?B?UW9zWkg1RUlXSzEvWW5kN1B5VmxwdmhhY1VzYlRYbjlwanp6ejJzcmhlQUIz?=
 =?utf-8?B?dm1PT3lrYVIrdkpHQ3JiMWx6NE9wL2VpMDJ2QVFUbzltSjFkaWF3S1dlSDZm?=
 =?utf-8?B?MEkzbFlJUFZHNEtwWkhUTnRmRTgxQ1ltb2NmNnZjYkNVZUZUc0dkTEZGK3NZ?=
 =?utf-8?B?bFgrWXJqMTY1eFNVT2VuRmFwZURqOS9RMzEzWC80bkcyY0hXOVBELzU3d1dF?=
 =?utf-8?B?b1lwdFRMMmJndVk0RDhsNnRRaG54MmFnL09pblI2ekY1dXhpalYzRjVieWdF?=
 =?utf-8?B?YWs3cFRia3MzeE1HMG4wejdXUVoxOHlyb01LOXFoMUJiQzF2WkxpWFVZZXg0?=
 =?utf-8?B?Y0RPRWdjclMzUWx3SzA1RU1LNXZpT3ROYWNaUk90UytpdHdsekxPSnllcERG?=
 =?utf-8?B?RVE9PQ==?=
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: 2fFdBmUgKe9fERKMskRIMDC/p+H4vVFQes5TWuD7xs2aYV8Oc5wMAhfgaPMQNXaCDPTMNUhJMH2f/d+Pu1TCo4WaqieUPx0CLmjfDost+Vuwi2g3t8z7hzB5rZKL89CPieOzJgGRE/lZ6l0jADf3CrHK5LbYPyuAvnsJP06Og2XDAJaNKlIEN02XHFL8v65DUfEtY8LLoQklSrQfx7hT5BMppC2Yqd1IvZGdxSTsvA2cNFT2g5jpUNHA21A2jiK5CePizpQRUCi2q/0e0Qf1yY7zlj01vQ7PnZckim5VFGP4j+jpMjkqGT3d5bSgN02Xtx/+rmFnXZkIWDXdq0XEySNniZVJQvv4OdfKtvRJdVP/i/16cZKrqws1hk9/GV5rOrsVGi4waW02BZFBk9PvmnKsLokLGdFCwWoPsF5Rq8+YmNLXrGnY9kiwvYCObU29lk/HpaYep+058SXPOhBWP8U+z6+uP4dvYXbyWRSnCe5tEpV+3qMKjF0Lr+h+Xeg23kCUwtB8Z8d4UZW/s1YtunyBZCt1fUbkRAqgxmY+BWBC5zvp/jVKsizmy58tH9LUgIF6Dcyr1d/N+Cy4WxfAmM4uRO5JGejI/caE+vvgalozOnTqS/xRgns2cuULJG9Dxh1J0lO3GxbhsDQsdYmAVM57lduKPqdu9ATR0ujNJTo2ecGki0NciKxGxofNshk4E9hInLsUvgop9gNU7WxxeQqhdAWTPLWUGaif0nKhx9h6qo1xjJcrtemydPTg58+XtTgyKIs+3QiEP1HM2nlG1EwtPUmFKlFpqMejMGfD98ba2fhTj7+Z+X9gjPZTkaODWiwxMKug3fStwohzm1SH0g==
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 02cd2822-a738-413a-c073-08db0c08e87e
X-MS-Exchange-CrossTenant-AuthSource: PH0PR10MB4581.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Feb 2023 08:21:00.7949
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: /Acalmk2tRcwZFJ4I5TUaoTkCK0+xKiDk4rnX+ZVj8KD7gBclorkJmLw780rjJLHvPycgVtYmkEK3UHeJAGBO02CvHY60RqPMrSnyitaXhE=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR10MB6741
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.219,Aquarius:18.0.930,Hydra:6.0.562,FMLib:17.11.170.22
 definitions=2023-02-11_04,2023-02-09_03,2023-02-09_01
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 malwarescore=0 bulkscore=0 adultscore=0
 mlxlogscore=999 phishscore=0 spamscore=0 mlxscore=0 suspectscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2212070000
 definitions=main-2302110073
X-Proofpoint-GUID: Gw4kFvpBu-W7AY7XfabGsP9Sua91TIp0
X-Proofpoint-ORIG-GUID: Gw4kFvpBu-W7AY7XfabGsP9Sua91TIp0
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

commit "Fixes: 12b6fcd0ea7f" introduce that change in source code.
that's reason we are using "fixes:". back-porting that change is creating awkward manual conflict resolution.

Thanks,
Alok

On 2/11/2023 1:18 PM, Greg KH wrote:
> On Fri, Feb 10, 2023 at 09:55:22AM -0800, Alok Tiwari wrote:
>> There is no separate blank line between target_remove_from_tmr_list() and
>> transport_cmd_check_stop_to_fabric
>> As per coding-style, it is require to separate functions with one blank line.
>>
>> Fixes: 12b6fcd0ea7f ("scsi: target: core: Remove from tmr_list during LUN unlink")
>> Signed-off-by: Alok Tiwari <alok.a.tiwari@oracle.com>
>> ---
>>   drivers/target/target_core_transport.c | 1 +
>>   1 file changed, 1 insertion(+)
>>
>> diff --git a/drivers/target/target_core_transport.c b/drivers/target/target_core_transport.c
>> index 5926316252eb..f1cdf78fc5ef 100644
>> --- a/drivers/target/target_core_transport.c
>> +++ b/drivers/target/target_core_transport.c
>> @@ -691,6 +691,7 @@ static void target_remove_from_tmr_list(struct se_cmd *cmd)
>>   		spin_unlock_irqrestore(&dev->se_tmr_lock, flags);
>>   	}
>>   }
>> +
>>   /*
>>    * This function is called by the target core after the target core has
>>    * finished processing a SCSI command or SCSI TMF. Both the regular command
>> -- 
>> 2.39.1
>>
> Why is a coding style change tagged with a "fixes:" line and cc: stable?
>
> thanks,
>
> greg k-h