Mime-Version: 1.0
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain; charset=UTF-8
Date:   Sat, 11 Feb 2023 10:25:15 +0100
Message-Id: <CQFMIYLWW6ZO.3LCN13CG142KC@vincent-arch>
Cc:     "Boqun Feng" <boqun.feng@gmail.com>, "Gary Guo" <gary@garyguo.net>,
        <bjorn3_gh@protonmail.com>, <rust-for-linux@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] rust: fix regexp in scripts/is_rust_module.sh
From:   "Vincenzo Palazzo" <vincenzopalazzodev@gmail.com>
To:     "Andrea Righi" <andrea.righi@canonical.com>,
        "Miguel Ojeda" <ojeda@kernel.org>,
        "Alex Gaynor" <alex.gaynor@gmail.com>,
        "Wedson Almeida Filho" <wedsonaf@gmail.com>
References: <20230210152622.92912-1-andrea.righi@canonical.com>
In-Reply-To: <20230210152622.92912-1-andrea.righi@canonical.com>
Precedence: bulk

> nm can use "R" or "r" to show read-only data sections, but
> scripts/is_rust_module.sh can only recognize "r", so with some versions
> of binutils it can fail to detect if a module is a Rust module or not.
>
> Right now we're using this script only to determine if we need to skip
> BTF generation (that is disabled globally if CONFIG_RUST is enabled),
> but it's still nice to fix this script to do the proper job.
>
> Moreover, with this patch applied I can also relax the constraint of
> "RUST depends on !DEBUG_INFO_BTF" and build a kernel with Rust and BTF
> enabled at the same time (of course BTF generation is still skipped for
> Rust modules).
>
> Signed-off-by: Andrea Righi <andrea.righi@canonical.com>

Reviewed-by: Vincenzo Palazzo <vincenzopalazzodev@gmail.com>