MIME-Version: 1.0
References: <20221103213420.1395507-1-j.neuschaefer@gmx.net>
 <CAMuHMdWo5vHCeE6BeSHrUy12uT7_wFhW-VbQmQ5u+4Q8c7-wYQ@mail.gmail.com> <Y+bpODkxY3FlCjPg@probook>
In-Reply-To: <Y+bpODkxY3FlCjPg@probook>
From:   Geert Uytterhoeven <geert@linux-m68k.org>
Date:   Sat, 11 Feb 2023 10:33:05 +0100
Message-ID: <CAMuHMdVzbSvA=1fm1ArwsN0=vU4-Ke_J7=s=N0i9jc69=Xa0qg@mail.gmail.com>
Subject: Re: [PATCH v6] soc: nuvoton: Add SoC info driver for WPCM450
To:     =?UTF-8?Q?Jonathan_Neusch=C3=A4fer?= <j.neuschaefer@gmx.net>
Cc:     openbmc@lists.ozlabs.org, Joel Stanley <joel@jms.id.au>,
        Tomer Maimon <tmaimon77@gmail.com>,
        Paul Menzel <pmenzel@molgen.mpg.de>,
        Arnd Bergmann <arnd@arndb.de>,
        Hitomi Hasegawa <hasegawa-hitomi@fujitsu.com>,
        Linus Walleij <linus.walleij@linaro.org>,
        Conor Dooley <conor.dooley@microchip.com>,
        Hector Martin <marcan@marcan.st>,
        Robert Jarzmik <robert.jarzmik@free.fr>,
        Nicolas Ferre <nicolas.ferre@microchip.com>,
        Brian Norris <briannorris@chromium.org>,
        Sven Peter <sven@svenpeter.dev>, linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8BIT
Precedence: bulk

Hi Jonathan,

On Sat, Feb 11, 2023 at 2:03 AM Jonathan Neuschäfer
<j.neuschaefer@gmx.net> wrote:
> On Fri, Feb 10, 2023 at 11:26:28AM +0100, Geert Uytterhoeven wrote:
> > On Thu, Nov 3, 2022 at 10:37 PM Jonathan Neuschäfer
> > <j.neuschaefer@gmx.net> wrote:
> > > Add a SoC information driver for Nuvoton WPCM450 SoCs. It provides
> > > information such as the SoC revision.
> > >
> > > Usage example:
> > >
> > >   # grep . /sys/devices/soc0/*
> > >   /sys/devices/soc0/family:Nuvoton NPCM
> > >   /sys/devices/soc0/revision:A3
> > >   /sys/devices/soc0/soc_id:WPCM450
> > >
> > > Signed-off-by: Jonathan Neuschäfer <j.neuschaefer@gmx.net>
> > > Reviewed-by: Joel Stanley <joel@jms.id.au>
> > > Reviewed-by: Paul Menzel <pmenzel@molgen.mpg.de>
> > > ---
> > > v6:
> > > - Select REGMAP
> > > - Rearrange Kconfig structure a bit
> >
> > Thanks for your patch!
> >
> > Unfortunately Joel seems to have sent v5 to Arnd instead of v6?
> > https://lore.kernel.org/all/20230201051717.1005938-1-joel@jms.id.au
> >
> > Which is now commit 7dbb4a38bff34493 ("soc:
> > nuvoton: Add SoC info driver for WPCM450") in soc/for-next...
> >
> > > --- /dev/null
> > > +++ b/drivers/soc/nuvoton/Kconfig
> > > @@ -0,0 +1,17 @@
> > > +# SPDX-License-Identifier: GPL-2.0
> > > +menu "Nuvoton SoC drivers"
> > > +       depends on ARCH_NPCM || COMPILE_TEST
> >
> > ... and lacks the above dependency, hence appearing on my radar.
> >
> > > +
> > > +config WPCM450_SOC
> > > +       tristate "Nuvoton WPCM450 SoC driver"
> > > +       default y if ARCH_WPCM450
> > > +       select SOC_BUS
> > > +       select REGMAP
> > > +       help
> > > +         Say Y here to compile the SoC information driver for Nuvoton
> > > +         WPCM450 SoCs.
> > > +
> > > +         This driver provides information such as the SoC model and
> > > +         revision.
> > > +
> > > +endmenu
> >
> > Do you plan to send a follow-up patch?
>
> Yes, hopefully I'll get around to it a few days after rc1, when the dust
> of the (upcoming) merge window has settled a bit.
>
> Or should I rather send it earlier?

I'd say sooner rather than later.
If I hadn't found your v6, I would have sent a patch myself to add the
dependency.

Does the "select REGMAP" fix a build issue? If yes, that's a very good
reason to send it now...

Thanks!

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds