Date:   Sat, 11 Feb 2023 17:30:53 +0100
From:   Pavel Machek <pavel@ucw.cz>
To:     Gergo Koteles <soyer@irl.hu>
Cc:     Dmitry Torokhov <dmitry.torokhov@gmail.com>,
        Jonathan Corbet <corbet@lwn.net>,
        Andy Gross <agross@kernel.org>,
        Bjorn Andersson <andersson@kernel.org>,
        Konrad Dybcio <konrad.dybcio@linaro.org>,
        Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Jiri Kosina <jikos@kernel.org>,
        Benjamin Tissoires <benjamin.tissoires@redhat.com>,
        linux-input@vger.kernel.org, linux-kernel@vger.kernel.org,
        linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
        Caleb Connolly <caleb@connolly.tech>
Subject: Re: [PATCH v2 2/3] Input: add ABS_SND_PROFILE
Message-ID: <Y+fCvaGTkddwNGP6@duo.ucw.cz>
References: <20230209232539.91500-1-soyer@irl.hu>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha1;
        protocol="application/pgp-signature"; boundary="g2w79Pe1No+u8GQT"
Content-Disposition: inline
In-Reply-To: <20230209232539.91500-1-soyer@irl.hu>
Precedence: bulk


--g2w79Pe1No+u8GQT
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

Hi!

> ABS_SND_PROFILE used to describe the state of a multi-value sound profile
> switch. This will be used for the tri-state key on OnePlus phones or other
> phones.

Looks like ABS_PROFILE would be fine to use there, no need to create
new one, no?

Best regards,
								Pavel

> Signed-off-by: Gergo Koteles <soyer@irl.hu>
> ---
>  Documentation/input/event-codes.rst    | 6 ++++++
>  drivers/hid/hid-debug.c                | 1 +
>  include/uapi/linux/input-event-codes.h | 1 +
>  3 files changed, 8 insertions(+)
>=20
> diff --git a/Documentation/input/event-codes.rst b/Documentation/input/ev=
ent-codes.rst
> index b4557462edd7..d43336e64d6a 100644
> --- a/Documentation/input/event-codes.rst
> +++ b/Documentation/input/event-codes.rst
> @@ -241,6 +241,12 @@ A few EV_ABS codes have special meanings:
>      emitted only when the selected profile changes, indicating the newly
>      selected profile value.
> =20
> +* ABS_SND_PROFILE:
> +
> +  - Used to describe the state of a multi-value sound profile switch.
> +    An event is emitted only when the selected profile changes,
> +    indicating the newly selected profile value.
> +
>  * ABS_MT_<name>:
> =20
>    - Used to describe multitouch input events. Please see
> diff --git a/drivers/hid/hid-debug.c b/drivers/hid/hid-debug.c

--=20
People of Russia, stop Putin before his war on Ukraine escalates.

--g2w79Pe1No+u8GQT
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iF0EABECAB0WIQRPfPO7r0eAhk010v0w5/Bqldv68gUCY+fCvQAKCRAw5/Bqldv6
8sM+AJ0VMGsWfvGF+uNYRZ5LzwdYOOkh4ACePA+D30SLyJMWQB2QAguPec2fUzU=
=lel6
-----END PGP SIGNATURE-----

--g2w79Pe1No+u8GQT--