Date:   Sat, 11 Feb 2023 17:40:14 +0100
From:   Pavel Machek <pavel@ucw.cz>
To:     Gergo Koteles <soyer@irl.hu>
Cc:     Dmitry Torokhov <dmitry.torokhov@gmail.com>,
        Andy Gross <agross@kernel.org>,
        Bjorn Andersson <andersson@kernel.org>,
        Konrad Dybcio <konrad.dybcio@linaro.org>,
        Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Jiri Kosina <jikos@kernel.org>,
        Benjamin Tissoires <benjamin.tissoires@redhat.com>,
        linux-input@vger.kernel.org, linux-kernel@vger.kernel.org,
        linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
        Caleb Connolly <caleb@connolly.tech>
Subject: Re: [PATCH v2 3/3] arm64: dts: qcom: sdm845-oneplus: add
 tri-state-key
Message-ID: <Y+fE7gIMD4BDCffy@duo.ucw.cz>
References: <20230209232556.91554-1-soyer@irl.hu>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha1;
        protocol="application/pgp-signature"; boundary="QtnDXKWpFdENi7Om"
Content-Disposition: inline
In-Reply-To: <20230209232556.91554-1-soyer@irl.hu>
Precedence: bulk


--QtnDXKWpFdENi7Om
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

Hi!

> +++ b/arch/arm64/boot/dts/qcom/sdm845-oneplus-common.dtsi
> @@ -52,6 +52,43 @@ key-vol-up {
>  		};
>  	};
> =20
> +	tri-state-key {
> +		compatible =3D "gpio-keys";
> +		label =3D "Tri-state key";
> +		pinctrl-names =3D "default";
> +		pinctrl-0 =3D <&tri_state_key_default>;
> +		state-top {
> +			label =3D "Tri-state key top";

"top/middle" is not too useful. Do we need the label at all? If so,
should it say "loud/vibrations only/mute"?

BR,
								Pavel
--=20
People of Russia, stop Putin before his war on Ukraine escalates.

--QtnDXKWpFdENi7Om
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iF0EABECAB0WIQRPfPO7r0eAhk010v0w5/Bqldv68gUCY+fE7gAKCRAw5/Bqldv6
8qazAJ4tTbEaN/jTDm/HvuDKLvkjqEsbigCgjyR3Jf17uJg1F3quUSWtJIkQgV0=
=mHMW
-----END PGP SIGNATURE-----

--QtnDXKWpFdENi7Om--