Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7F918C636CC for ; Sat, 11 Feb 2023 18:58:19 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229568AbjBKS6R (ORCPT ); Sat, 11 Feb 2023 13:58:17 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45064 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229499AbjBKS6Q (ORCPT ); Sat, 11 Feb 2023 13:58:16 -0500 Received: from mail-ej1-x62e.google.com (mail-ej1-x62e.google.com [IPv6:2a00:1450:4864:20::62e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4FCAC199E7 for ; Sat, 11 Feb 2023 10:58:15 -0800 (PST) Received: by mail-ej1-x62e.google.com with SMTP id m2so23112659ejb.8 for ; Sat, 11 Feb 2023 10:58:15 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux-foundation.org; s=google; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=v6OIGzvOpvoDs5k8U8ZXPR9Oe0WDhcfEQMGkRVj61LY=; b=EIXdLD2NKM3TRG47LtztKC0uokjWh9qOIVDhwX03oat6LH91fz1Bsf/lPs2NP2CG8X +DswqOlfYlGGKQggnB9PN5h6tY4I4kXpr4aX5smQFgvIZzwCwCuHFcRbAT4uyAPo4Q6z xKh6bsoMHKAriwGucZR6A+JhEX/u34NaffC2c= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=v6OIGzvOpvoDs5k8U8ZXPR9Oe0WDhcfEQMGkRVj61LY=; b=mlx6ZrxE8a93K5o0u2z6qbwzhdbobIW6zCtg3a+Yi9wVUXFlCJV9Y88iqcVZVnQjfl AicJ6ndRgKTtM/p2B9q1USS2oEeJP5t0JAaPI5fnlXCCNOVXlZlega9HDIDjEh9WNEBZ sYbCPrh/6IucBcyXKZGfw5Q8L0efo3m6rAX/mg/DCvYbU0uJCxjDmWEnyaF39kkbob25 5RNAZPLwbP9ag4sUAjSeIyGXiskyZ8t2EhwDbnQik/ZNES7CvNQjTKb0CXZMahxeGlqF welfXD4R+XUSoaiS3rwMzfzclIqo8NNjlnGhsHVWpaVibGpNoFenKLn74OUZfqV6KL3h /rwQ== X-Gm-Message-State: AO0yUKXOcmHSBdfMwKI2OrU+jilj62uJiKXVycrt11ou8kk4sdUCIEw+ q8iNIyO2eLk2C2OGXGEfRc2BkaM1j8+wZkMpZyg= X-Google-Smtp-Source: AK7set82LaZCb/BthBIz0klz/vZ/MU+dxIu2UJ9RpSzDHRVbUJXdG7X5l81Pei/BEhT5CFxKog0c9w== X-Received: by 2002:a17:907:d89:b0:890:4731:d1bc with SMTP id go9-20020a1709070d8900b008904731d1bcmr24594893ejc.38.1676141893689; Sat, 11 Feb 2023 10:58:13 -0800 (PST) Received: from mail-ej1-f42.google.com (mail-ej1-f42.google.com. [209.85.218.42]) by smtp.gmail.com with ESMTPSA id qk8-20020a170906d9c800b008a654ade18csm4215090ejb.78.2023.02.11.10.58.12 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 11 Feb 2023 10:58:12 -0800 (PST) Received: by mail-ej1-f42.google.com with SMTP id hx15so23078161ejc.11 for ; Sat, 11 Feb 2023 10:58:12 -0800 (PST) X-Received: by 2002:a17:906:658:b0:88f:a9ec:dfd7 with SMTP id t24-20020a170906065800b0088fa9ecdfd7mr2491955ejb.0.1676141891911; Sat, 11 Feb 2023 10:58:11 -0800 (PST) MIME-Version: 1.0 References: <7a2e5b7f-c213-09ff-ef35-d6c2967b31a7@kernel.dk> <2bb12591-9d24-6b26-178f-05e939bf3251@kernel.dk> <55eaac9e-0d77-1fa2-df27-4d64e123177e@kernel.dk> <787c3b62-f5d8-694d-cd2f-24b40848e39f@kernel.dk> In-Reply-To: <787c3b62-f5d8-694d-cd2f-24b40848e39f@kernel.dk> From: Linus Torvalds Date: Sat, 11 Feb 2023 10:57:54 -0800 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: copy on write for splice() from file to pipe? To: Jens Axboe Cc: Ming Lei , Andy Lutomirski , Dave Chinner , Matthew Wilcox , Stefan Metzmacher , linux-fsdevel , Linux API Mailing List , io-uring , "linux-kernel@vger.kernel.org" , Al Viro , Samba Technical Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Feb 11, 2023 at 7:33 AM Jens Axboe wrote: > > OK, but then the ignore_sig change should not be needed at all, just > changing that first bit to fatal_signal_pending() would do the trick? Right. That was my point. The 'ignore_sig' flag just doesn't make sense. It was a hack for a case that shouldn't exist. Linus