MIME-Version: 1.0
References: <20230207-b4-amlogic-bindings-fixups-v2-v1-0-93b7e50286e7@linaro.org>
 <20230207-b4-amlogic-bindings-fixups-v2-v1-5-93b7e50286e7@linaro.org>
In-Reply-To: <20230207-b4-amlogic-bindings-fixups-v2-v1-5-93b7e50286e7@linaro.org>
From:   Martin Blumenstingl <martin.blumenstingl@googlemail.com>
Date:   Sat, 11 Feb 2023 21:04:05 +0100
Message-ID: <CAFBinCC1O52eraLJ=GoZVM0fM0zVyqdDrkP3RCjNQ=KaqhByLQ@mail.gmail.com>
Subject: Re: [PATCH 5/8] arm64: dts: amlogic: meson-g12b-odroid-go-ultra:
 rename keypad-gpio pinctrl node
To:     Neil Armstrong <neil.armstrong@linaro.org>
Cc:     Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Kevin Hilman <khilman@baylibre.com>,
        Jerome Brunet <jbrunet@baylibre.com>,
        Christian Hewitt <christianshewitt@gmail.com>,
        Yuntian Zhang <yt@radxa.com>, devicetree@vger.kernel.org,
        linux-arm-kernel@lists.infradead.org,
        linux-amlogic@lists.infradead.org, linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Tue, Feb 7, 2023 at 4:08 PM Neil Armstrong <neil.armstrong@linaro.org> wrote:
>
> Fixes the following bindings check error:
> pinctrl@40: keypad-gpio: {...} is not of type 'array'
>
> Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org>
Reviewed-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com>

[...]
>  &periphs_pinctrl {
> -       keypad_gpio_pins: keypad-gpio {
> +       keypad_gpio_pins: keypad-gpio-state {
>                 mux {
>                         groups = "GPIOX_0", "GPIOX_1", "GPIOX_2", "GPIOX_3",
>                                  "GPIOX_4", "GPIOX_5", "GPIOX_6", "GPIOX_7",
I'm wondering whether we make the keys work without having to specify
a pinmux configuration for them separately.
Our pinctrl driver already sets:
   pc->chip.set_config = gpiochip_generic_config;
So you should be able to use the GPIO_PULL_UP flag for these GPIOs in
device-tree instead of specifying bias-pull-up here, for example:
   gpios = <&gpio GPIOX_0 (GPIO_ACTIVE_LOW | GPIO_PULL_UP)>;

output-disable is managed by the direction of the GPIO anyways.
pinmux_ops.gpio_request_enable is also implemented by our pinctrl driver.

This is not urgent - I am just curious as always :-)


Best regards,
Martin