From:   Ondrej Zary <linux@zary.sk>
To:     Sergey Shtylyov <s.shtylyov@omp.ru>
Subject: Re: [PATCH 03/12] pata_parport: remove devtype from struct pi_adapter
Date:   Sat, 11 Feb 2023 21:47:50 +0100
User-Agent: KMail/1.9.10
Cc:     Damien Le Moal <damien.lemoal@opensource.wdc.com>,
        Christoph Hellwig <hch@lst.de>, Jens Axboe <axboe@kernel.dk>,
        Tim Waugh <tim@cyberelk.net>, linux-block@vger.kernel.org,
        linux-parport@lists.infradead.org, linux-ide@vger.kernel.org,
        linux-kernel@vger.kernel.org
References: <20230211144232.15138-1-linux@zary.sk> <20230211144232.15138-4-linux@zary.sk> <909afe94-d786-a94c-5142-818e540705cc@omp.ru>
In-Reply-To: <909afe94-d786-a94c-5142-818e540705cc@omp.ru>
MIME-Version: 1.0
Content-Type: Text/Plain;
  charset="utf-8"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
Message-Id: <202302112147.50725.linux@zary.sk>
Precedence: bulk

On Saturday 11 February 2023 20:11:06 Sergey Shtylyov wrote:
> On 2/11/23 5:42 PM, Ondrej Zary wrote:
> 
> > Only bpck driver uses devtype but it never gets set in pata_parport.
> > Remove it.
> > 
> > Signed-off-by: Ondrej Zary <linux@zary.sk>
> > ---
> >  drivers/ata/pata_parport/bpck.c | 2 +-
> >  include/linux/pata_parport.h    | 3 ---
> >  2 files changed, 1 insertion(+), 4 deletions(-)
> > 
> > diff --git a/drivers/ata/pata_parport/bpck.c b/drivers/ata/pata_parport/bpck.c
> > index b9174cf8863c..451a068fe28a 100644
> > --- a/drivers/ata/pata_parport/bpck.c
> > +++ b/drivers/ata/pata_parport/bpck.c
> > @@ -241,7 +241,7 @@ static void bpck_connect ( PIA *pi  )
> >  
> >  	WR(5,8);
> >  
> > -	if (pi->devtype == PI_PCD) {
> > +	if (1 /*pi->devtype == PI_PCD*/) {	/* FIXME */
> >  		WR(0x46,0x10);		/* fiddle with ESS logic ??? */
> 
>    Why not drop this entire *if* stmt? 

I decided to keep it (for now) as a marker of a possible bug. I currently don't have HW to test this driver.

> 
> >  		WR(0x4c,0x38);
> >  		WR(0x4d,0x88);
> [...]
> 
> MBR, Sergey
> 


-- 
Ondrej Zary