Date:   Sat, 11 Feb 2023 23:45:45 +0200
From:   Vladimir Oltean <vladimir.oltean@nxp.com>
To:     Andrew Lunn <andrew@lunn.ch>
Cc:     Maxime Chevallier <maxime.chevallier@bootlin.com>,
        davem@davemloft.net, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org, thomas.petazzoni@bootlin.com,
        Jakub Kicinski <kuba@kernel.org>,
        Eric Dumazet <edumazet@google.com>,
        Paolo Abeni <pabeni@redhat.com>,
        Florian Fainelli <f.fainelli@gmail.com>,
        Heiner Kallweit <hkallweit1@gmail.com>,
        Russell King <linux@armlinux.org.uk>,
        linux-arm-kernel@lists.infradead.org,
        Ioana Ciornei <ioana.ciornei@nxp.com>
Subject: Re: [PATCH net-next] net: pcs: tse: port to pcs-lynx
Message-ID: <20230211214545.5tu5cfg6jcwy5njd@skbuf>
References: <20230210190949.1115836-1-maxime.chevallier@bootlin.com>
 <20230210190949.1115836-1-maxime.chevallier@bootlin.com>
 <20230210193159.qmbtvwtx6kqagvxy@skbuf>
 <Y+e1IfWcmHJjJlgp@lunn.ch>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <Y+e1IfWcmHJjJlgp@lunn.ch>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?xdfY3ppHIWqnnWl8xHVE3pBRuhlJe3finCYi3FftpItWxXNNsTMPdEAh3yO6?=
 =?us-ascii?Q?5iEt4EMMN6SwU/QlhN+tKI2JjHqjCh93qXR4xvwGjuHf+d1ER9UjcDzn5w8Q?=
 =?us-ascii?Q?jcXkE4KqD3fNtOT4eTni7Ni64qg0IqZgeiLdqFthmIuO07oWkFLH1KzW6DOP?=
 =?us-ascii?Q?r/+XFNB5tloVLTe8CkgYu9LLqhoU2CxakR9OXU2er+QxHGIe6/TSTsL4bbJm?=
 =?us-ascii?Q?FmPx74349i5q3MXapT2+rUFvzjjplvZScGm/80Sy++mImdTzfN+taJzRUgi4?=
 =?us-ascii?Q?dUr1nzXL9K2Uat6pEfkV2bNTWF8zo/vU78BxFMyWzxBfJ2kL/qFDnmsGBFL7?=
 =?us-ascii?Q?6PlRoCLwnrsJZlM+ZLUmu8DxB9h8D+lINmSWw59diqqIiwrTMVSxhsTFdpHw?=
 =?us-ascii?Q?ZL6UjNzXg4dazGQT5TQmNTyZLjnIkl87k+F6s/bptpB20gpW/LOwuYMzIiCy?=
 =?us-ascii?Q?qlHxkWkLB+8fY2nXi4QwDzDoH1LdX+0PCXX2ewKk46PrQelCQetrQ8+ZXlrZ?=
 =?us-ascii?Q?z6o75oYuUJ7mAE9AlpK7MeEr9gIoNrgp6VhkT9E02+pgQk8TxqeSL8qY1XOY?=
 =?us-ascii?Q?yhGZb4T8hORLIwFusWd/2IfRzygx3p3h/fsMe1xws+vVNO3vnAZP4n8ilFKo?=
 =?us-ascii?Q?A3FT+d3AlQlRTO8o8W75ppY7MhY7wyJ9lzuiOb3NPm3DmWEjCwai9e8ZbWAt?=
 =?us-ascii?Q?OxxvW/hFzB+qVlXcsc6fnx4auwQU6pxOa4t8jsQkG3G136fmYf0LJ2XqZ26W?=
 =?us-ascii?Q?K3lfzdYVfI2u8enBf+p4fZEDUfzTXpm5GuPgLII4PPcD5sdPFp7vfwPrHv85?=
 =?us-ascii?Q?+Z/wRDEJvjlIU/jzkpSZYAb9M1GoHgJsVV0hcolIXJBjiGH7H4NmIom+oKE6?=
 =?us-ascii?Q?R50m+4/2aym4HDPQT/SGBXGqic3+z1a38vXlAVm+QuwQeBtlm3Kq9WieySZR?=
 =?us-ascii?Q?+Gs9UVj30h1CiZiYJz5MquLhgjpvOQqAPcxxqdhLpVHwXOhyiRzSrGusqCSV?=
 =?us-ascii?Q?Ntjk/qJrqzREbH4IduI6nmfzEvCY/V5KMMpoBn66vvX49cd87s6dyeWW1ooX?=
 =?us-ascii?Q?l91rlEv3BUCzBIexcnfkBLrIjW3h06qwrf6IXx9UuBZkZO0KaOyKZSYU1xwH?=
 =?us-ascii?Q?vg76kJC40ppiW0BYjw7B4zhQ/+Ja3UIvT+CgDIc296BRi+mJqQ7NM//xwAfN?=
 =?us-ascii?Q?flKoAphKSv2z51x9sc/reQswTcI+zPfWgdKV7hV2bc3IyCu7FnzehdwJtp5T?=
 =?us-ascii?Q?qXJ8smcRUDGXFxy5+eVhef2Tn2sMkcT3HLgJc3mJbUuZm9o1ykm9dP0eNsAE?=
 =?us-ascii?Q?X8tx0RCN1D76BrDHmqnWQe/KNXUIJdFBEL7HdoNgM8viV3YIkE2Q/D1YGgiz?=
 =?us-ascii?Q?KukmM/DMtrWB6Is4JLZRi7X8ZPpFrztkF3KAOvtEHEcheAJW8LCqON55Rzyc?=
 =?us-ascii?Q?7onZWeUTEV2fcQBd1Uaq/qgSj1TuNSMYfMDbttz4VWe2MQBDtEnnyQxaOz8v?=
 =?us-ascii?Q?wvdD6iobcxmhrYpEqIQ279kQOrygD+f2Y7ZaDAbOnIznyVU4baZG/ze70wAQ?=
 =?us-ascii?Q?Gl/YKDj1b0gzafBZ42N0TcJynzeUZ8GSUT1zKkhmJ2mi2XWtl12N/aC7ngrT?=
 =?us-ascii?Q?/A=3D=3D?=
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-Network-Message-Id: f37f2527-928d-4ad7-ad95-08db0c7956aa
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5136.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Feb 2023 21:45:48.9534
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: mYHD7TzV92FZusY3ZYE1uFUpL9/dQTFcA1ZYHh/5/EgEol5ACjVKehdAlFETdf169tYtYoyBsYhUz5M13R46kw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PA4PR04MB7597
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Sat, Feb 11, 2023 at 04:32:49PM +0100, Andrew Lunn wrote:
> Another option might be regmap. There are both regmap-mdio.c and
> regmap-mmio.c.

Maxime had originally considered regmap too, but I thought it would
involve too many changes in the lynx-pcs driver and I wasn't sure
that those changes were for the better, since it would then need
to use the more low-level variants of phylink helpers (for example
phylink_mii_c22_pcs_decode_state() instead of phylink_mii_c22_pcs_get_state()).