Message-ID: <aed35866-507c-870c-7e8a-c1868bcaa084@acm.org>
Date:   Sat, 11 Feb 2023 15:25:03 -0800
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.7.1
Subject: Re: [PATCH] scsi: qla1280: Replace arithmetic addition by bitwise OR
Content-Language: en-US
To:     Deepak R Varma <drv@mailo.com>, Michael Reed <mdr@sgi.com>,
        "James E.J. Bottomley" <jejb@linux.ibm.com>,
        "Martin K. Petersen" <martin.petersen@oracle.com>,
        linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org
Cc:     Saurabh Singh Sengar <ssengar@microsoft.com>,
        Praveen Kumar <kumarpraveen@linux.microsoft.com>
References: <Y+I7/QpQYjBXutLf@ubun2204.myguest.virtualbox.org>
From:   Bart Van Assche <bvanassche@acm.org>
In-Reply-To: <Y+I7/QpQYjBXutLf@ubun2204.myguest.virtualbox.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 2/7/23 03:54, Deepak R Varma wrote:
> When adding two bit-field mask values, an OR operation offers higher
> performance over an arithmetic operation. So, convert such addition to
> an OR based expression.

Where is the evidence that supports this claim? On the following page I 
read that there is no performance difference when using a modern CPU: 
https://cs.stackexchange.com/questions/75811/why-is-addition-as-fast-as-bit-wise-operations-in-modern-processors

> Issue identified using orplus.cocci semantic patch script.

Where is that script located? Can it be deleted such that submission of 
patches similar to this patch stops?

Thanks,

Bart.