Date:   Sun, 12 Feb 2023 01:58:33 +0000
To:     Pavel Machek <pavel@ucw.cz>, Gergo Koteles <soyer@irl.hu>
From:   Caleb Connolly <caleb@connolly.tech>
Cc:     Dmitry Torokhov <dmitry.torokhov@gmail.com>,
        Andy Gross <agross@kernel.org>,
        Bjorn Andersson <andersson@kernel.org>,
        Konrad Dybcio <konrad.dybcio@linaro.org>,
        Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Jiri Kosina <jikos@kernel.org>,
        Benjamin Tissoires <benjamin.tissoires@redhat.com>,
        linux-input@vger.kernel.org, linux-kernel@vger.kernel.org,
        linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH v2 3/3] arm64: dts: qcom: sdm845-oneplus: add tri-state-key
Message-ID: <d1959211-bf33-f4fd-01a8-91dcd247aa70@connolly.tech>
In-Reply-To: <Y+fE7gIMD4BDCffy@duo.ucw.cz>
References: <20230209232556.91554-1-soyer@irl.hu> <Y+fE7gIMD4BDCffy@duo.ucw.cz>
Feedback-ID: 10753939:user:proton
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Precedence: bulk


On 11/02/2023 16:40, Pavel Machek wrote:
> Hi!
>
>> +++ b/arch/arm64/boot/dts/qcom/sdm845-oneplus-common.dtsi
>> @@ -52,6 +52,43 @@ key-vol-up {
>>  =09=09};
>>  =09};
>>
>> +=09tri-state-key {
>> +=09=09compatible =3D "gpio-keys";
>> +=09=09label =3D "Tri-state key";
>> +=09=09pinctrl-names =3D "default";
>> +=09=09pinctrl-0 =3D <&tri_state_key_default>;
>> +=09=09state-top {
>> +=09=09=09label =3D "Tri-state key top";
>
> "top/middle" is not too useful. Do we need the label at all? If so,
> should it say "loud/vibrations only/mute"?

"mute", "vibrate" and "ring" sound good to me.

Although it would be nice if users can easily map the physical key
position to the action when viewing the input device or remapping the
key in userspace.

Do you have any ideas or recommendations on how to do this?
>
> BR,
> =09=09=09=09=09=09=09=09Pavel

--
Kind Regards,
Caleb