Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2C2C4C636CC for ; Sun, 12 Feb 2023 02:46:24 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229657AbjBLCqU (ORCPT ); Sat, 11 Feb 2023 21:46:20 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35486 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229557AbjBLCqR (ORCPT ); Sat, 11 Feb 2023 21:46:17 -0500 Received: from mail-pj1-x1034.google.com (mail-pj1-x1034.google.com [IPv6:2607:f8b0:4864:20::1034]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 005C71449E for ; Sat, 11 Feb 2023 18:46:16 -0800 (PST) Received: by mail-pj1-x1034.google.com with SMTP id nn4-20020a17090b38c400b00233a6f118d0so6848502pjb.2 for ; Sat, 11 Feb 2023 18:46:16 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20210112.gappssmtp.com; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=13n7orFtfB4ykJMQSCkI+SVHhcT583fh+bxIuvlC7mY=; b=ESXg7vS2YfHpVFr9OQZAHv9M3hthBxU2Row9ea0aJR9IjQ6GL15VCoTe39SuK/apcz lfGM7PXnvgu0PiiAykezRpIW1FRoeZgXJJ1f5yT+0kseS0KVDaqQDpA+I+Dymcgg1zY1 iJGmRqnL0dCDPWM41X5z2Oh7WP3Z/XxGAGv3Avnn9/JwRFp3kolnB1oZQv8VGQXmwX3d rD5u2DHcmPTZ0/x3/2kVydfAybYsxNmLWQeSV3+yI7B70FNGMxThFxKX2Pd0AYuzKaP5 7cdqi426YYBSMwwbt6a0/WgGTHOQHmA3ZJ65WGdgZGheeKN3uSzavEMms8FWcLknPqQx PyIw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=13n7orFtfB4ykJMQSCkI+SVHhcT583fh+bxIuvlC7mY=; b=tNfOaG6Vf+cXe5+KpWLKB4PqU+fD0lkIdTHL3q/liEyMSra3yfu/SQFf4FheAQQsOB TFPG99J4snoMeQIDj5m/8I+NDo7dYjgTm3qmRGfvpjPCsB2sNaradN7Aji6sKvQicJI1 ZnXqDVPPK3Ecb9Jx/jLd2DKSL2z1T1VMXWEaOK74fH5Akl4+3EGpuIaxWE1MWLGgvIHk 3a2QF/enHMhGZc/VZCy5mC/8bq2iOGmQTwH4dbgu6wa6KrHKRp77IU4ObSmkMmKhcRnZ iCbR4MdGZdy/70nHEH+tNJIbhIgOEnIARMaSDMtUTiJoPsikM4+f7LTsSgkHJ3gfO1f+ AOvg== X-Gm-Message-State: AO0yUKWeJspRFzsMwq7VtYSbIg2NTtflLM8PkM3a2f/GlOQH5ly5W+I4 Sw5ASutnPMgOBhZPTS16xMrwtQ== X-Google-Smtp-Source: AK7set8Q/Jh+L5ryxfXOAajWPMV5niu5B7Z5pm8YR78FRqb1qNpO8JtR/DWeRFI2ODz7Fg0mdVhiIg== X-Received: by 2002:a17:902:f685:b0:199:2ee:6248 with SMTP id l5-20020a170902f68500b0019902ee6248mr21267626plg.0.1676169976461; Sat, 11 Feb 2023 18:46:16 -0800 (PST) Received: from [192.168.1.136] ([198.8.77.157]) by smtp.gmail.com with ESMTPSA id g13-20020a63be4d000000b00478ca052819sm4935737pgo.47.2023.02.11.18.46.15 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 11 Feb 2023 18:46:15 -0800 (PST) Message-ID: <467c0abe-251f-d74b-57c8-91e02bec1c05@kernel.dk> Date: Sat, 11 Feb 2023 19:46:14 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux aarch64; rv:102.0) Gecko/20100101 Thunderbird/102.7.2 Subject: Re: copy on write for splice() from file to pipe? Content-Language: en-US To: Linus Torvalds Cc: Ming Lei , Andy Lutomirski , Dave Chinner , Matthew Wilcox , Stefan Metzmacher , linux-fsdevel , Linux API Mailing List , io-uring , "linux-kernel@vger.kernel.org" , Al Viro , Samba Technical References: <7a2e5b7f-c213-09ff-ef35-d6c2967b31a7@kernel.dk> <2bb12591-9d24-6b26-178f-05e939bf3251@kernel.dk> <55eaac9e-0d77-1fa2-df27-4d64e123177e@kernel.dk> <787c3b62-f5d8-694d-cd2f-24b40848e39f@kernel.dk> From: Jens Axboe In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2/11/23 11:57 AM, Linus Torvalds wrote: > On Sat, Feb 11, 2023 at 7:33 AM Jens Axboe wrote: >> >> OK, but then the ignore_sig change should not be needed at all, just >> changing that first bit to fatal_signal_pending() would do the trick? > > Right. That was my point. The 'ignore_sig' flag just doesn't make > sense. It was a hack for a case that shouldn't exist. Yep, just wanted to confirm that we'd _only_ do that first one and not go to sleep later on ignoring a signal as that could lead to issues. Your fatal signal pending suggestion is all we need. -- Jens Axboe