From:   Peng Fan <peng.fan@nxp.com>
To:     Abel Vesa <abel.vesa@linaro.org>,
        "djakov@kernel.org" <djakov@kernel.org>
CC:     Mike Tipton <quic_mdtipton@quicinc.com>,
        Vivek Aknurwar <quic_viveka@quicinc.com>,
        "djakov@kernel.org" <djakov@kernel.org>,
        "quic_okukatla@quicinc.com" <quic_okukatla@quicinc.com>,
        "linux-pm@vger.kernel.org" <linux-pm@vger.kernel.org>,
        "linux-arm-msm@vger.kernel.org" <linux-arm-msm@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "abel >> Philipp Zabel" <p.zabel@pengutronix.de>,
        "abelvesa@kernel.org" <abelvesa@kernel.org>,
        Bryan O'Donoghue <bryan.odonoghue@linaro.org>
Subject: RE: [PATCH] interconnect: Skip call into provider if initial bw is
 zero
Thread-Topic: [PATCH] interconnect: Skip call into provider if initial bw is
 zero
Thread-Index: AQHZJ5uglincFtnDF0iVAMF0/8auRK6dHp+AgAAEe4CACTWEAIAAG4eAgAYRjICAACeagIAKeLYAgBQr07A=
Date:   Sun, 12 Feb 2023 10:56:31 +0000
Message-ID: <DU0PR04MB9417A7E511E4C8B512A0CB9E88DC9@DU0PR04MB9417.eurprd04.prod.outlook.com>
References: <1673647679-15216-1-git-send-email-quic_viveka@quicinc.com>
 <83a7bfed-3b16-3d01-b1b2-f197252bd0b1@linaro.org>
 <5e1f37ba-494a-19d2-e412-7631508ab142@linaro.org>
 <151790dd-02e5-a1f5-aab5-360f39e21c57@quicinc.com>
 <35dcb764-e340-5fe7-6637-cdb5f84266ce@linaro.org>
 <6dd7b0b0-f6fb-9de4-c365-d6cbfe04f2c0@quicinc.com>
 <742ff9cd-e7be-11b8-3805-5b60aba6b2f1@linaro.org>
 <Y9fZ6GUzWsCMXzba@linaro.org>
In-Reply-To: <Y9fZ6GUzWsCMXzba@linaro.org>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?r+1J0+K52siGUGy2/5FugF+Ja9ZqMqDhPYX1JHEU6gwfvckIV7mAsM7LExaP?=
 =?us-ascii?Q?p0rmtoD20HjH0VNxzU1s0MPnWmQH+5J0oVOzh1EV0FbZPHo06DTVP+qWSm5Z?=
 =?us-ascii?Q?VVxYfgzAjhO6LJh7F89hRwX/NJ0CNxg9n+3Q0721IrfTiSPXsMARtAReHvzg?=
 =?us-ascii?Q?DE7+bt46NHfOlaSUvZo448bHWZCy3bSEnSgfH5O1iomUYwQLe8miKUVMwiFB?=
 =?us-ascii?Q?1NZZ8SzMqXCC0Ppj6q+fIBuiAYvhTzUgzB+D5A07rasNOcWM+MJVkjWnRoLC?=
 =?us-ascii?Q?W4ei+5LxIeKgHRhucZSgwgQXN18+qAjHlkv3UmbV/JeVjONCXA/Wtm6FK6vW?=
 =?us-ascii?Q?6PplA+NZ93tAoV5AywS424GoL9/PNJ9rW47BdC9j47vIr99OTqVyuawmjuMl?=
 =?us-ascii?Q?OosudkORfA9FdscZROtikUwqu4XDsIrvT5Yn94yefdDypU3/YVLqh6FU0Q8T?=
 =?us-ascii?Q?Fm5UFuXunlf54td5sgkX6fTHso5hAe2DcNtWEc8Fgr1K8l+ZeHN57DHLyyiY?=
 =?us-ascii?Q?f9H21VATFWmVcFLll9KfboeDmJA9frPdWb4maXc7UXTTOYrWOJJBbkM/9OiT?=
 =?us-ascii?Q?mf1lCJW2kphyG1lwLpfHjBgd+SlKHfbq/mvXv/f9ErNsOU7ea1VCDZMxRYAd?=
 =?us-ascii?Q?if9Ft3tdbXk09srHKBYaYjWJ5fY9amQ1Rl4xrimRFapC88oTlhqrG4a1uV3P?=
 =?us-ascii?Q?oFsZqlqueVJMBtReDIQSTh9bD8PQfGyjOUc/J7vUt3wYKDyNuxTX5Im2mAjk?=
 =?us-ascii?Q?ElZn/t5dliNegtGnWkmqU+mU0q9JE9ww+r9TUFm2YA27RRI07vIYtvpEmNBX?=
 =?us-ascii?Q?XCH8zmNL22de+E6EWMDaYAZN4ymsWUFxlvpkD6Pv+Y+wBFWBiXOqmGKGj34t?=
 =?us-ascii?Q?MtYtufaS9XIpWPoiJusCWXYFD4pdckNuolhxSZXLK9KVFUMfEMY2w88sAlKL?=
 =?us-ascii?Q?MQSFO2/pMx25yjxsCJq5cpVeNyUcarIklF0IUzUVD/ItQEExZZP9BgX54fh6?=
 =?us-ascii?Q?Sgp4zMXCqAj08ue8Odm2blRTa9P6kGmvQfwytpUXfJ0dcMY75VNibdjC4u8F?=
 =?us-ascii?Q?YRfbVIruACLYj59Wa7bJ3Ewi20LxuzkoATDo4kSzEgtLUXB7njUgFZ22O3Bq?=
 =?us-ascii?Q?8LbmrRfKMjPykFVygfkdi4dc4ab//Ye//XbyGFCQRzlSBRHx5qIByWuJa433?=
 =?us-ascii?Q?3RJxoZPfT19IiMgtp4TmgclwG29ytmTMcN+ECOGlJgHIC60de7MafFNy3BmV?=
 =?us-ascii?Q?1JYm5bCA621Ga502SHDb0K3QOLEu5RVVzUgixOowUCxNQrSKYeKZQNSTEFB8?=
 =?us-ascii?Q?0DPO3dRhJGebI7FhGmz295+2GhQW0Umc3x7OiKch75pY5x72vEIuqAgxJPzM?=
 =?us-ascii?Q?cu+0L4gKygRW1t8bLEibw78D1bQYmxZkSu17I2LzjXSg3ASiZQCe9qwixhKc?=
 =?us-ascii?Q?U2yFYpXwVzd3StauKm47ywOm0Twt92RQY+9vw9avQVuPZmC92aRvfFPfJt0r?=
 =?us-ascii?Q?2dbaHKrJMZnv5YKW1ghWsYXx+MKhkaiHo+hjNY07fvmOnliK1F9S5HXb2tyt?=
 =?us-ascii?Q?IhgTgBpkRDJ3GLzi/ebp583gVxlf/weycXoAiFR1?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: DU0PR04MB9417.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 090fa614-f589-486b-b8ac-08db0ce7ccf1
X-MS-Exchange-CrossTenant-originalarrivaltime: 12 Feb 2023 10:56:31.8273
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: rAstFiBkueCwFlP+92LBWuzK254CUcrepIoXkbMaExc0lDvuikaMBcyFCTX9mf9HDivCg3KICpv9JxP5wwK7bQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS4PR04MB9689
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


> Subject: Re: [PATCH] interconnect: Skip call into provider if initial bw =
is zero
>=20
> On 23-01-23 22:58:49, Bryan O'Donoghue wrote:
> > On 23/01/2023 20:37, Mike Tipton wrote:
> > >
> > > This isn't actually changing it for all providers. Only for those
> > > that define the get_bw() callback. Right now that's only
> > > qcom/msm8974 and imx/imx. If get_bw() isn't defined, then
> > > icc_node_add() defaults to INT_MAX. So, the logical behavior in that
> > > case is unchanged. Which means this isn't even changing the behavior
> for rpmh yet, either.
> >
> > Yes that adds up.
> >
> > Looking at the commit for get_bw() for the 8974, I think this change
> > would be OK with the intent of this commit
> >
> > commit 9caf2d956cfa254c6d89c5f4d7b3f8235d75b28f
> > Author: Georgi Djakov <georgi.djakov@linaro.org>
> > Date:   Mon Nov 9 14:45:12 2020 +0200
> >
> > @Abel what effect will skipping pre->aggregation() have on i.MX ?
>=20
> I don't think there is any impact on i.MX platforms.
>=20
> Peng, any input?

Thanks for CC me.

No impact on i.MX.

Thanks,
Peng.
>=20
> >
> > ---
> > bod