IronPort-SDR: S6teJ3tIX5Jpw2A/qlZi0pnLgoYVfFJG01tpdWvLwxin4HFTz91QAGJ9gK1199nRjq/1K0mqGm
 3KMIzk5zfY5dUx1prE2QTEGayLI91Aso6WqdPgX4T06bbx9iWeHZZOVsaOybbGG/mbeScVx49g
 GunD05WPWcwiW8TYpPd7OZdXnCcQEzvRjXJgbVm/gOGaCYMzRCNABs1OqQcIeqHjOZ/Iu+P8oM
 0b7K+Nk/eTG8YGlVrbCNEGRUzDP8im6ZlsnuRaRmU9Dmgua/3MIDZFa17Ng0uZ2Lzoi4fzGmaB
 SOg=
IronPort-SDR: VFTrGZnWLqLWjo+mH4E5LP/a5NWBWHoXKewCrj+kBFfpMWk1uzoQxIE9eFy6hxHxg20zVy5QWo
 lCIGvCw+KQRb21TcpDbNrs9tw/TVurMQ+pTrnIANKcK9Kqv7P2nJ4ofcIZySYPTAlv0RUbz5wK
 QsLglbFK7VQNatXYCwlIVdps9LwgjQocfcMShzahI4G+DFxnDlNG3EiB+n3lr+Vqe/wnTBdysI
 bXapEqPnkmq40vdY27aKzaG0lEyl/ZVZoIl0vKWUBJ1gdGVcmG9sH2f+4vwrbWQ1hzuXcpwkIO
 If0=
WDCIronportException: Internal
Message-ID: <16f5f350-5aae-8ba1-d72c-fded975fb5af@opensource.wdc.com>
Date:   Sun, 12 Feb 2023 21:17:10 +0900
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.7.1
Subject: Re: [PATCH 03/12] pata_parport: remove devtype from struct pi_adapter
To:     Ondrej Zary <linux@zary.sk>, Sergey Shtylyov <s.shtylyov@omp.ru>
Cc:     Christoph Hellwig <hch@lst.de>, Jens Axboe <axboe@kernel.dk>,
        Tim Waugh <tim@cyberelk.net>, linux-block@vger.kernel.org,
        linux-parport@lists.infradead.org, linux-ide@vger.kernel.org,
        linux-kernel@vger.kernel.org
References: <20230211144232.15138-1-linux@zary.sk>
 <20230211144232.15138-4-linux@zary.sk>
 <909afe94-d786-a94c-5142-818e540705cc@omp.ru>
 <202302112147.50725.linux@zary.sk>
Content-Language: en-US
From:   Damien Le Moal <damien.lemoal@opensource.wdc.com>
Organization: Western Digital Research
In-Reply-To: <202302112147.50725.linux@zary.sk>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 2/12/23 05:47, Ondrej Zary wrote:
> On Saturday 11 February 2023 20:11:06 Sergey Shtylyov wrote:
>> On 2/11/23 5:42 PM, Ondrej Zary wrote:
>>
>>> Only bpck driver uses devtype but it never gets set in pata_parport.
>>> Remove it.
>>>
>>> Signed-off-by: Ondrej Zary <linux@zary.sk>
>>> ---
>>>  drivers/ata/pata_parport/bpck.c | 2 +-
>>>  include/linux/pata_parport.h    | 3 ---
>>>  2 files changed, 1 insertion(+), 4 deletions(-)
>>>
>>> diff --git a/drivers/ata/pata_parport/bpck.c b/drivers/ata/pata_parport/bpck.c
>>> index b9174cf8863c..451a068fe28a 100644
>>> --- a/drivers/ata/pata_parport/bpck.c
>>> +++ b/drivers/ata/pata_parport/bpck.c
>>> @@ -241,7 +241,7 @@ static void bpck_connect ( PIA *pi  )
>>>  
>>>  	WR(5,8);
>>>  
>>> -	if (pi->devtype == PI_PCD) {
>>> +	if (1 /*pi->devtype == PI_PCD*/) {	/* FIXME */
>>>  		WR(0x46,0x10);		/* fiddle with ESS logic ??? */
>>
>>    Why not drop this entire *if* stmt? 
> 
> I decided to keep it (for now) as a marker of a possible bug. I currently don't have HW to test this driver.

Then leave that if as-is and only add a comment detailing what needs to be
done (rather than just "FIXME"). This "if (1)" is just too odd and will
likely trigger code checker warnings.

> 
>>
>>>  		WR(0x4c,0x38);
>>>  		WR(0x4d,0x88);
>> [...]
>>
>> MBR, Sergey
>>
> 
> 

-- 
Damien Le Moal
Western Digital Research