Return-Path: <linux-kernel-owner+w=401wt.eu-S1758021AbXIEQFy@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1758021AbXIEQFy (ORCPT <rfc822;w@1wt.eu>);
	Wed, 5 Sep 2007 12:05:54 -0400
Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1756874AbXIEQFr
	(ORCPT <rfc822;linux-kernel-outgoing>);
	Wed, 5 Sep 2007 12:05:47 -0400
Received: from ns1.suse.de ([195.135.220.2]:41607 "EHLO mx1.suse.de"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1756681AbXIEQFq (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Wed, 5 Sep 2007 12:05:46 -0400
Date: Wed, 05 Sep 2007 18:05:44 +0200
Message-ID: <s5hlkbl6qsn.wl%tiwai@suse.de>
From: Takashi Iwai <tiwai@suse.de>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Roger Gammans <roger@computer-surgery.co.uk>, linux-kernel@vger.kernel.org,
       Jaroslav Kysela <perex@suse.cz>
Subject: Re: hda_intel : Patch + Regression in 2.6.18 -> 2.6.22
In-Reply-To: <20070905083844.6637da1e.akpm@linux-foundation.org>
References: <20070822222902.GA28563@computer-surgery.co.uk>
	<20070905083844.6637da1e.akpm@linux-foundation.org>
User-Agent: Wanderlust/2.15.5 (Almost Unreal) SEMI/1.14.6 (Maruoka)
 FLIM/1.14.7 (=?ISO-8859-4?Q?Sanj=F2?=) APEL/10.6 MULE XEmacs/21.5 (beta28)
 (fuki) (+CVS-20070806) (i386-suse-linux)
MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka")
Content-Type: text/plain; charset=US-ASCII
Sender: linux-kernel-owner@vger.kernel.org
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 2777
Lines: 69

At Wed, 5 Sep 2007 08:38:44 -0700,
Andrew Morton wrote:
> 
> > On Wed, 22 Aug 2007 23:29:02 +0100 Roger Gammans <roger@computer-surgery.co.uk> wrote:
> > Hi
> 
> A distinct regression, a confirmed fix, yet no reply after more than two weeks.

Sorry, I've overseen this report (as I'm obviously no akpm ;-)


> > I'm fighting a problem with my (new) Acer laptop.  (Aspire 9303)
> > 
> > In 2.6.18 the audio worked fine, but now I've upgraded to 2.6.22
> > it has stopped working. 
> > 
> > I note that there is a acer specific quirk mode in patch_realtek.c
> > enabled for all acer devices introduced in the timeframe. Disabling
> > the quirk so that the driver uses it auot mode makes playback work
> > fine again.
> > 
> > To be clear this pathc seems to work for me:-
> > 
> > --- /usr/src/linux-source-2.6.22/sound/pci/hda/patch_realtek.c 2007-07-09 00:32:17.000000000 +0100
> > +++ linux-source-2.6.22/sound/pci/hda/patch_realtek.c   2007-08-20 22:21:37.000000000 +0100
> > @@ -6392,7 +6392,7 @@
> >         SND_PCI_QUIRK(0x1462, 0x4319, "MSI", ALC883_TARGA_DIG),
> >         SND_PCI_QUIRK(0x1462, 0x4324, "MSI", ALC883_TARGA_DIG),
> >         SND_PCI_QUIRK(0x1462, 0xa422, "MSI", ALC883_TARGA_2ch_DIG),
> > -       SND_PCI_QUIRK(0x1025, 0, "Acer laptop", ALC883_ACER),
> > +/*     SND_PCI_QUIRK(0x1025, 0, "Acer laptop", ALC883_ACER) , */
> >         SND_PCI_QUIRK(0x15d9, 0x8780, "Supermicro PDSBA", ALC883_3ST_6ch),
> >         SND_PCI_QUIRK(0x161f, 0x2054, "Medion laptop", ALC883_MEDION),
> >         SND_PCI_QUIRK(0x1071, 0x8258, "Evesham Voyaeger", ALC883_LAPTOP_EAPD), 
> > 
> > 
> > Unfortunately I think it's pretty clear it will break for others.
> > 
> > The lspci reports the following on the appropriate device:-
> >   00:10.1 0403: 10de:026c (rev a2)
> >         Subsystem: 1025:0112
> >         Flags: 66MHz, fast devsel, IRQ 19
> >         Memory at c0000000 (32-bit, non-prefetchable) [size=16K]
> >         Capabilities: <access denied>
> > 
> 
> Jaroslav, Takashi: can you please comment on this?

The patch would definitely break many other machines, so no, it can't
be applied as is.  Note that there is an equivalent workaround by
adding "model=auto" module option.

The support for Acer Aspire was already improved in mm tree.  At
least, we have the support for Aspire 9810 and co.  If it's the
compatible one, the chance is high.

Roger, could you try git-alsa patch in the latest mm together with
model=acer-aspiore option?  If it works, I can easily add your device
ID to the table.


thanks,

Takashi
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/