Message-ID: <72ae1545-11ad-1c48-c6ac-a5d6e5de54b5@linaro.org>
Date:   Sun, 12 Feb 2023 17:05:24 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.7.1
Subject: Re: [PATCH] dt-bindings: mailbox: sti: convert sti-mailbox to DT
 schema
Content-Language: en-US
To:     Alain Volmat <avolmat@me.com>,
        Jassi Brar <jassisinghbrar@gmail.com>,
        Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Patrice Chotard <patrice.chotard@foss.st.com>
Cc:     linux-kernel@vger.kernel.org, devicetree@vger.kernel.org
References: <20230211205102.9218-1-avolmat@me.com>
From:   Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
In-Reply-To: <20230211205102.9218-1-avolmat@me.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 11/02/2023 21:51, Alain Volmat wrote:
> Convert the sti-mailbox.txt dt-bindings into dt-schema YAML.
> 
> Signed-off-by: Alain Volmat <avolmat@me.com>
> ---
>  .../bindings/mailbox/st,sti-mailbox.yaml      | 54 +++++++++++++++++++
>  .../bindings/mailbox/sti-mailbox.txt          | 51 ------------------
>  2 files changed, 54 insertions(+), 51 deletions(-)
>  create mode 100644 Documentation/devicetree/bindings/mailbox/st,sti-mailbox.yaml
>  delete mode 100644 Documentation/devicetree/bindings/mailbox/sti-mailbox.txt
> 
> diff --git a/Documentation/devicetree/bindings/mailbox/st,sti-mailbox.yaml b/Documentation/devicetree/bindings/mailbox/st,sti-mailbox.yaml
> new file mode 100644
> index 000000000000..527c88147397
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/mailbox/st,sti-mailbox.yaml
> @@ -0,0 +1,54 @@
> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: "http://devicetree.org/schemas/mailbox/st,sti-mailbox.yaml#"
> +$schema: "http://devicetree.org/meta-schemas/core.yaml#"

Drop quotes from both.

> +
> +title: STMicroelectronics Mailbox Driver
> +
> +description:
> +  Each ST Mailbox IP currently consists of 4 instances of 32 channels.
> +  Messages are passed between Application and Remote processors using
> +  shared memory.
> +
> +maintainers:
> +  - Patrice Chotard <patrice.chotard@foss.st.com>
> +
> +properties:
> +  compatible:
> +    const: st,stih407-mailbox
> +
> +  reg:
> +    maxItems: 1
> +
> +  mbox-name:
> +    description: name of the mailbox
> +    maxItems: 1

Is the field defined anywhere? Looks like not, thus you need proper type
(and maxItems might not be correct then).

> +
> +  interrupts:
> +    description: the irq line for the RX mailbox
> +    maxItems: 1
> +
> +  "#mbox-cells":
> +    const: 2
> +
> +required:
> +  - compatible
> +  - reg
> +  - "#mbox-cells"
> +  - mbox-name
> +
> +additionalProperties: false
> +
> +examples:
> +  - |
> +    #include <dt-bindings/interrupt-controller/arm-gic.h>
> +    mailbox0: mailbox@8f00000  {
> +        compatible = "st,stih407-mailbox";
> +        reg = <0x08f00000 0x1000>;
> +        interrupts = <GIC_SPI 1 IRQ_TYPE_NONE>;

This should be rather proper type of interrupt, not none.

> +        #mbox-cells = <2>;
> +        mbox-name = "a9";
> +    };
> +
> +...


Best regards,
Krzysztof