From:   Hariprasad Kelam <hkelam@marvell.com>
To:     Simon Horman <simon.horman@corigine.com>
CC:     "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "kuba@kernel.org" <kuba@kernel.org>,
        "davem@davemloft.net" <davem@davemloft.net>,
        "pabeni@redhat.com" <pabeni@redhat.com>,
        "edumazet@google.com" <edumazet@google.com>,
        Sunil Kovvuri Goutham <sgoutham@marvell.com>,
        Linu Cherian <lcherian@marvell.com>,
        Geethasowjanya Akula <gakula@marvell.com>,
        Jerin Jacob Kollanukkaran <jerinj@marvell.com>,
        Subbaraya Sundeep Bhatta <sbhatta@marvell.com>,
        "jhs@mojatatu.com" <jhs@mojatatu.com>,
        "xiyou.wangcong@gmail.com" <xiyou.wangcong@gmail.com>,
        "jiri@resnulli.us" <jiri@resnulli.us>,
        "saeedm@nvidia.com" <saeedm@nvidia.com>,
        "richardcochran@gmail.com" <richardcochran@gmail.com>,
        "tariqt@nvidia.com" <tariqt@nvidia.com>,
        "linux-rdma@vger.kernel.org" <linux-rdma@vger.kernel.org>,
        "maxtram95@gmail.com" <maxtram95@gmail.com>,
        Naveen Mamindlapalli <naveenm@marvell.com>,
        "bpf@vger.kernel.org" <bpf@vger.kernel.org>,
        "hariprasad.netdev@gmail.com" <hariprasad.netdev@gmail.com>
Subject: Re: [net-next Patch V4 3/4] octeontx2-pf: Refactor schedular queue
 alloc/free calls
Thread-Topic: [net-next Patch V4 3/4] octeontx2-pf: Refactor schedular queue
 alloc/free calls
Thread-Index: AQHZPv4FNS+AGWAAjECq6I+pSwUS4Q==
Date:   Sun, 12 Feb 2023 16:21:12 +0000
Message-ID: <PH0PR18MB447442487D0968D52D3030ACDEDC9@PH0PR18MB4474.namprd18.prod.outlook.com>
References: <20230210111051.13654-1-hkelam@marvell.com>
 <20230210111051.13654-4-hkelam@marvell.com> <Y+Zdi48x+g/Ypre+@corigine.com>
In-Reply-To: <Y+Zdi48x+g/Ypre+@corigine.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?Alr3r1IZaPyb0YCuYcv7RbQzDkF5G7C6E1ke7WCqKJIbxidv7BEUew0H9bIh?=
 =?us-ascii?Q?MdE8OUKeo+LL75MBuNmCoRqfn5EOvQVbqiHsp5PDuNgPnVb9MX8d3gNzayTf?=
 =?us-ascii?Q?mWY8Ko5g2xV2zSJUcxe3c8ByI9/X3La/a8zN21vFzs4Ahm9LZTnLOegPzOrU?=
 =?us-ascii?Q?cpnOKsG6ANqSSBfg1HhMl97NOXOWLm8nV8Xlme/FVJ8Iks0SmLjfduxopmmQ?=
 =?us-ascii?Q?mL08tJQlaSfllGDgeQDJYnNXjPbAJYu0/bPx+o3VRgBzy4QbjIxPs18ifVN3?=
 =?us-ascii?Q?IFDcDBV6CXHPnbWkRxFWmG17EepywkvCAcJkD+2P90mFjc2vynac0g9GlZOC?=
 =?us-ascii?Q?d+oMiY8I4bhxjPO5yiACPrilBY5ir+LpbUsaBKA4f1sPPNItPfNzFGOmN3Nc?=
 =?us-ascii?Q?BqGsIap7RBqWAGeyaDv8Ch7CwurWMeA+GYLoO8HvJK8rwt06/tvdXSGdDEsi?=
 =?us-ascii?Q?7G6lMIL76Q8EfNSISN1FJ6UfJ4ElaBtVe4QTix2Wm7/3noBxugDX8vznV+nM?=
 =?us-ascii?Q?tNgYK2nZaiU7h1s4n4L4X+1Uke5UJO5MrJSzh8leG1vLTS9Buu6J6iLKwaoB?=
 =?us-ascii?Q?0Q22BXl5dUqLlo8kG00ye0xi+2fuKSwQsYA9xjLfw5UiPp9RwXEm2x6Vsgx3?=
 =?us-ascii?Q?7vfgUYqa4n79Cw9ACbJ+Quhb82dbig2K/Vq+p7Ppa8fwNViXC0A4MsmvLLGp?=
 =?us-ascii?Q?Z5H54Kmduas7hZ7GdyIDO7IBZNx0TmB9O8pwibJQUEuCvOXXZnX5IL1O3UYe?=
 =?us-ascii?Q?G00bu1vEB4zSuRzntt+ol0z5SKSOG4GL1hSfs7ERxKgL+RADxyamnid5xvq0?=
 =?us-ascii?Q?Z6ptp79k4SbSxJ6scbuEikKrQowRCJS9bxo5+dFu3kiybXyFW+yvs8slaaEF?=
 =?us-ascii?Q?CusBBfDyxsNNfn6Q90nm4FI9hKYgo7BUBZWdsxyeLOSGed1o76VquSudBIJO?=
 =?us-ascii?Q?+w2X3hTGQ2QOqoqlnP+73jxYRqnmamo0y/sTBRFE5Nz/GyGwPBPEpkU5FTf8?=
 =?us-ascii?Q?4bQG+6fEkNNwMhM6huQjSuKer4OICSzyHxLfzEeaIDXW/3evklU0/Ck/LeL+?=
 =?us-ascii?Q?Hg+XB9oa2oPeoOrW1J8bD7rpLvsfeCEpYzwqzce15F9v+Vvpv7u58PxlyF1z?=
 =?us-ascii?Q?Q1DpR7HYdb+g2lU/Q1pyOItF/qhkubdIwwHs6XFehLL57/G5ktDG6UnqbUG4?=
 =?us-ascii?Q?E6SmmPxsZNXr2SLaKKcYey7BXWZvzjHpBJKnrqY9DYxUCcqn2hzVNAfyHhgF?=
 =?us-ascii?Q?YzL0Ukxnz4W+daRm2hXTRVhIHqcU3H2uZekiSAjekHTvVO51rVBnjENdxy8r?=
 =?us-ascii?Q?ycmjKNUTzmaECh0iTL6xLz28lP5oQtAUSWmd1GdJVT3/xyqDVogeh6Si5dwl?=
 =?us-ascii?Q?EwUAcFYGXT7RjqwEeEIcHxl6244QA+10Lk6lEd198+ETfr7emgdNUfAhGl0e?=
 =?us-ascii?Q?i2uYTIOKdFmxc5NCXwW3OuwyHxaqX7F3UN3kavKGWDwRPZU6NROtqZIiUP/P?=
 =?us-ascii?Q?F+IhH/O2h3LHtnNXa5PCZwjq0IEG/coQ4ospCFqmv6i347kzKXJPioXZXS2x?=
 =?us-ascii?Q?voceQr8Gxw7FfA/mw5oUeDO1Y2S8tu/aKp74gPXw?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: marvell.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: PH0PR18MB4474.namprd18.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: e5a243fc-ab4d-419b-a56c-08db0d152852
X-MS-Exchange-CrossTenant-originalarrivaltime: 12 Feb 2023 16:21:12.4879
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: MaI1GuFIF4SSbcP0OhU89Rw5IAbi0eOPut3PjG0JqcQ90bIttaB/w0wuAMzZpSsI3iAeGnyPSzev0nB95aqnaQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS0PR18MB5477
X-Proofpoint-GUID: ovJcgreWGaC5o6-SRfh-FK_hmLHdANaI
X-Proofpoint-ORIG-GUID: ovJcgreWGaC5o6-SRfh-FK_hmLHdANaI
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.219,Aquarius:18.0.930,Hydra:6.0.562,FMLib:17.11.170.22
 definitions=2023-02-12_06,2023-02-09_03,2023-02-09_01
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


> On Fri, Feb 10, 2023 at 04:40:50PM +0530, Hariprasad Kelam wrote:
> > Multiple transmit scheduler queues can be configured at different
> > levels to support traffic shaping and scheduling. But on txschq free
> > requests, the transmit schedular config in hardware is not getting
> > reset. This patch adds support to reset the stale config.
> >
> > The txschq alloc response handler updates the default txschq array
> > which is used to configure the transmit packet path from SMQ to TL2
> > levels. However, for new features such as QoS offload that requires
> > it's own txschq queues, this handler is still invoked and results in
> > undefined behavior. The code now handles txschq response in the mbox
> > caller function.
> >
> > Signed-off-by: Hariprasad Kelam <hkelam@marvell.com>
> > Signed-off-by: Naveen Mamindlapalli <naveenm@marvell.com>
> > Signed-off-by: Sunil Kovvuri Goutham <sgoutham@marvell.com>
> > ---
> >  .../ethernet/marvell/octeontx2/af/rvu_nix.c   | 45
> +++++++++++++++++++
> >  .../marvell/octeontx2/nic/otx2_common.c       | 36 ++++++++-------
> >  .../ethernet/marvell/octeontx2/nic/otx2_pf.c  |  4 --
> > .../ethernet/marvell/octeontx2/nic/otx2_vf.c  |  4 --
> >  4 files changed, 64 insertions(+), 25 deletions(-)
>=20
> ...
>=20
> > diff --git a/drivers/net/ethernet/marvell/octeontx2/nic/otx2_common.c
> > b/drivers/net/ethernet/marvell/octeontx2/nic/otx2_common.c
> > index 73c8d36b6e12..4cb3fab8baae 100644
> > --- a/drivers/net/ethernet/marvell/octeontx2/nic/otx2_common.c
> > +++ b/drivers/net/ethernet/marvell/octeontx2/nic/otx2_common.c
> > @@ -716,7 +716,8 @@ EXPORT_SYMBOL(otx2_smq_flush);  int
> > otx2_txsch_alloc(struct otx2_nic *pfvf)  {
> >  	struct nix_txsch_alloc_req *req;
> > -	int lvl;
> > +	struct nix_txsch_alloc_rsp *rsp;
> > +	int lvl, schq, rc;
> >
> >  	/* Get memory to put this msg */
> >  	req =3D otx2_mbox_alloc_msg_nix_txsch_alloc(&pfvf->mbox);
> > @@ -726,8 +727,24 @@ int otx2_txsch_alloc(struct otx2_nic *pfvf)
> >  	/* Request one schq per level */
> >  	for (lvl =3D 0; lvl < NIX_TXSCH_LVL_CNT; lvl++)
> >  		req->schq[lvl] =3D 1;
> > +	rc =3D otx2_sync_mbox_msg(&pfvf->mbox);
> > +	if (rc)
> > +		return rc;
> >
> > -	return otx2_sync_mbox_msg(&pfvf->mbox);
> > +	rsp =3D (struct nix_txsch_alloc_rsp *)
> > +	      otx2_mbox_get_rsp(&pfvf->mbox.mbox, 0, &req->hdr);
> > +	if (IS_ERR(rsp))
> > +		return PTR_ERR(rsp);
> > +
> > +	/* Setup transmit scheduler list */
> > +	for (lvl =3D 0; lvl < NIX_TXSCH_LVL_CNT; lvl++)
> > +		for (schq =3D 0; schq < rsp->schq[lvl]; schq++)
> > +			pfvf->hw.txschq_list[lvl][schq] =3D
> > +				rsp->schq_list[lvl][schq];
> > +
> > +	pfvf->hw.txschq_link_cfg_lvl     =3D rsp->link_cfg_lvl;
>=20
> nit: extra whitespace before '=3D'
>=20
ACK , will fix in next version.

Thanks,
Hariprasad k
> > +
> > +	return 0;
> >  }