From:   Nick Alcock <nick.alcock@oracle.com>
To:     Leon Romanovsky <leon@kernel.org>
Cc:     Conor Dooley <conor@kernel.org>, mcgrof@kernel.org,
        linux-modules@vger.kernel.org, linux-kernel@vger.kernel.org,
        linux-pci@vger.kernel.org, linux-riscv@lists.infradead.org
Subject: Re: [PATCH 8/8] kbuild, PCI: microchip: comment out MODULE_LICENSE
 in non-modules
References: <20230210164749.368998-1-nick.alcock@oracle.com>
        <20230210164749.368998-9-nick.alcock@oracle.com>
        <Y+aMh5e9bWaTphiZ@spud> <871qmx1fv5.fsf@esperi.org.uk>
        <Y+akw9VBjg9oZ7QV@spud> <Y+kx3fb2Lzlg+u5+@unreal>
Emacs:  the prosecution rests its case.
Date:   Sun, 12 Feb 2023 19:52:57 +0000
In-Reply-To: <Y+kx3fb2Lzlg+u5+@unreal> (Leon Romanovsky's message of "Sun, 12
        Feb 2023 20:37:17 +0200")
Message-ID: <87wn4my82u.fsf@esperi.org.uk>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.1.91 (gnu/linux)
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?PBx4T5f+gYXoxexmyRFFW5VG4B3fOa+j79RBwcnH7pYQOeLdfXCjjeZp5awh?=
 =?us-ascii?Q?PNl+/VYCbCQTkt/69rGXQBFPwVS8iJsGG/kToybO8vu//jk5Cc5Hjh2nuV7Q?=
 =?us-ascii?Q?r9RY2cqFCgmgTUJ3q0SK9pcUtsJtwmJTmjP8BmU3UyQ4uHa+hjLWlyGbFeCY?=
 =?us-ascii?Q?iHeldsxftnn/pPH3H5reRJorE40CWks9+ItPqIbwgXIt8J/Lp9GnoVAtQx6S?=
 =?us-ascii?Q?WzWQi37kcKSjfqhzesGCsf2q/7BwyL4sArnY54d4WtcqcMZW1bf46kl2SDuY?=
 =?us-ascii?Q?ab50ZBAlD8AiynsgLJIqBiXwJSVVvTALhoOGIg/oWXtAZLFylBPpSeM/NGlV?=
 =?us-ascii?Q?I/zSxpDkHa/qs6BkNOCzUFTWQUbHE5gnY3bjVf47Jf6ZBtvlSWoHaDNdSbSX?=
 =?us-ascii?Q?uqXOU+Gx+bVrMgTAe/0r+G1pn/nMm82RQVO2+c9sN3YmqElLHfjaCG6ja7Y6?=
 =?us-ascii?Q?+g+oLZP/tHYYn3fDTG5ZQNsJnhUG03lfqavi18Zk/eOusoBaQZO48dgj8Zpe?=
 =?us-ascii?Q?qXp7dh9stEfOb+b3TvxXFAZIy2WL9+WZnyRO2jvI7Vj4NVxQMdBF7z4itNFE?=
 =?us-ascii?Q?jUEbbtdWszsOExsfGfugBbDMEc2s2yypLIILdiO4EyhLuFm/COMslKMJe810?=
 =?us-ascii?Q?ECuUp83FBYOmAxe7mNV/pv8TvG3QLH1nzi04OU1g2HsuB6w2LQ0wwTVdOUCw?=
 =?us-ascii?Q?yRakbSAJPsiYLLyDIhMWsl4NlJaSQZvLulGIMbOVuSiH4EOU26V+WcTL23a3?=
 =?us-ascii?Q?+ogim8DzIjRQUa16st57NKQxJNuD04yhh/qo+f8Pu4Dz8HThZna4EneGTCur?=
 =?us-ascii?Q?aSNczXqPZ4QlsjFAAsIo6Xyo6XLDcKNdogFgGsac+I/gHop9ntXw/vNeE0la?=
 =?us-ascii?Q?uW6y0QSerRNNGclyg6oTn01qq2dWD5DniBagGGSgYGFSfWqR1sv5HTDMlahd?=
 =?us-ascii?Q?Va8Da0kGueGQmpXtScFx16ytKSbCwv5IeJJzy/e0ktsZraGdevjMi6VP8/I0?=
 =?us-ascii?Q?QfbPgtv+0o/NkVMRynokEvLWvRcYb9xJ0cq80J8A4tPV0II9WzVz01Vx6RNV?=
 =?us-ascii?Q?eobVgccoKwxu2ra/GqlFl+tVpYzlRukWFIIIc6063WB5jcr5XohvWa98b21K?=
 =?us-ascii?Q?hC6zrPwG4BwYznkTVFn/KIkJ0Mlu9CjYjw9hJOSPp9mpzPzOJ0lIzEpDQdUi?=
 =?us-ascii?Q?QV+Qe3rKLxalhQf01BWr2ytM9JUnY0lP5TbKwYH3oFobXuvOnyZM4NDiveA9?=
 =?us-ascii?Q?Zbr46kK2MtjBz2W+6pf1KMm8Vknq9QzucChWcUv8Qk7wiOpBPtQq5b2zZ/aF?=
 =?us-ascii?Q?GUe+B9BIqYp6NyFrh/k+9bLcWmtrLpImJtLXxB9sitBqDNRfsBDTapu8CHLl?=
 =?us-ascii?Q?Bbc2jcRGB3Olzc40G/jyUnFO9MSMq2H7eHCSmZKB3Vc4fq/hvu5UPNWboEkZ?=
 =?us-ascii?Q?AgfggxqNWUS5yarMa/xdveLBeygWpnmvK1aF5sXHMJf/za+Ocp934q6B6ioK?=
 =?us-ascii?Q?7fDT8EEJhkXLIEprMrcTCckyu2ww+NCw+DBbcZAwM+49Xa+z8S/k3QPfMNvN?=
 =?us-ascii?Q?uqSz8B4Or+SQWWf1g0qsFJijJG9/1zcwBhqx71a8Xj0eVu2ZPqZ6Y6jckxBY?=
 =?us-ascii?Q?ww=3D=3D?=
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: VGyWcSPu19J5RI/zCTunJsFwgtXpvM6jfQQsJXv6UP9M9mW9l/VnhwlFUzB5U9XGmGIFdlBqQpmD29Q1Yzz9+XyGIYzdnqLgXZMW8IzRufZ8NL0SyKWRjkTVLlKZ2lYtzCWGPmcKqa8aSoofyffwOKpgEM3xYMoPTt1mUzvt2ey9KaoKTa38W74RILqgriGF1nLlRruuWNIuw/XyG2m5yL15xaRkcJGMDxLNzJf93Sn9KaVRrZDWfxaniM6zOXbiYareBH3RI5I/yaF/xuGCoqvHMtB+2MhMbb3vq5zDivspBed8Oz+e6AUg2mM4Z0ssJjbZl9CVb89PGtJOHsNM8Jo56J3aQ6qNdHhqCNKjwAFCYaLXWaUjBJtUVlYBW1i45EmjwGriwMtPmjvs1X6lOHadzhsIl4JJg5KH+IIGWE/1fQffbHPaN2ix+m2wLvMVfT6mkII6CpU+t07I/ZD9OmQujfDBXzY1nyKdjZIPqTc2i9/4i/7Pj6Zpi8z3rlgAzh5pLqnL46KmrIezl8z8Mo0GE/xpD64VbC+QM4nkrQWwkPStWmZuFbvORxvWTHANd4VJpl+WgSci9p8Afd2F17KHPkOqY7VsTqf/SYO9Fm0Iv5GtRb2SKKfSRkK6XuiBa/IBcXzIGqKM7E0nae7GJeAFbgGbHvBoO1O7yp/dVaA9jp13diYb3tM23qPNARB7an9/SxCHYisUjZlujG+uKYhyXHJHyN7z14KkAzgZNlKNTa/UQhuSb+T14xGJvYToPLn07lRW33QmZCEnAWRknPQFUBFctJ6zaaXK4DsDwI5dmSIRS20wi3o6pQVfGKQdgJCfa7Hjz6fDeHH8v8V4Cw==
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: b015601a-2bca-44a0-d20c-08db0d32c036
X-MS-Exchange-CrossTenant-AuthSource: DS0PR10MB6798.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Feb 2023 19:53:02.9120
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: j4NWF278rVyadcICBWvI07WxxKOT/5OqmMz+Pd3stcW4+hwH6Ia6vZlwuIFPMn1/EspRX9nhb7InM3CYfYYGQA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR10MB5784
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.219,Aquarius:18.0.930,Hydra:6.0.562,FMLib:17.11.170.22
 definitions=2023-02-12_09,2023-02-09_03,2023-02-09_01
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 malwarescore=0 bulkscore=0 adultscore=0
 mlxlogscore=784 phishscore=0 spamscore=0 mlxscore=0 suspectscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2212070000
 definitions=main-2302120181
X-Proofpoint-GUID: E5kbyDmLX66JS_0fGovJAv8Ap074oiqr
X-Proofpoint-ORIG-GUID: E5kbyDmLX66JS_0fGovJAv8Ap074oiqr
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 12 Feb 2023, Leon Romanovsky uttered the following:

> On Fri, Feb 10, 2023 at 08:10:43PM +0000, Conor Dooley wrote:
>> On Fri, Feb 10, 2023 at 07:26:38PM +0000, Nick Alcock wrote:
>> > On 10 Feb 2023, Conor Dooley said:
>> > > FYI $subject seems wrong, this is a PCI patch AFAICT.
>
> <...>
>
>> > kbuild is present in every patch in the series because this is a
>> > kbuild-driven change (the thing it disturbs is part of the build system,
>> > the construction of modules.builtin*). This seems to be common practice
>> > for kbuild-related treewide changes.
>> 
>> Okay, I'll take your word for it. It just looked/looks odd to me!
>
> It looks odd to me too. Please add SPDX tag in modules which don't have
> it already, instead of commenting code.

OK, I now have two votes for removal-and-SPDX (you and Luis) and nobody
suggesting that keeping it in but commented out is actually a good idea:
I'll respin with removals instead, and add SPDX to anything so adjusted
that doesn't already have it (if anything).

(I'll stick both the removal and addition in the same commit, so there
is no point at which such files have no declared license at all.)

-- 
NULL && (void)