Message-ID: <87lel2phdu.wl-kuninori.morimoto.gx@renesas.com>
From:   Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
To:     Sameer Pujar <spujar@nvidia.com>
Cc:     robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org,
        thierry.reding@gmail.com, jonathanh@nvidia.com,
        oder_chiou@realtek.com, broonie@kernel.org, perex@perex.cz,
        tiwai@suse.com, lgirdwood@gmail.com, devicetree@vger.kernel.org,
        linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org,
        alsa-devel@alsa-project.org
Subject: Re: [PATCH 1/2] ASoC: rt5640: Update MCLK rate in set_sysclk()
In-Reply-To: <4a45f084-7d33-59d2-8ef9-cb95e29866a3@nvidia.com>
References: <1675953417-8686-1-git-send-email-spujar@nvidia.com>
        <1675953417-8686-2-git-send-email-spujar@nvidia.com>
        <87lel61k3h.wl-kuninori.morimoto.gx@renesas.com>
        <4a45f084-7d33-59d2-8ef9-cb95e29866a3@nvidia.com>
User-Agent: Wanderlust/2.15.9 Emacs/26.3 Mule/6.0
Content-Type: text/plain; charset=US-ASCII
Date:   Sun, 12 Feb 2023 23:56:46 +0000
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?ms0HnH7KdWTyxXGZjI5QdbESoF0kjgyndaFbJFJ8fXW1E+iZ0SV3Xv/Qssmj?=
 =?us-ascii?Q?jlIAEB60S7sX+Q8vCY/MPmsqgXVU2RZUhpvA7Z5UbagyIDxHJcHgPHGbxFtR?=
 =?us-ascii?Q?rUs51NVj1N29Zwt14QlKI1K4Ey9/5d70ycCOm8/9uYqPE3C2ESFrYK8LUzAC?=
 =?us-ascii?Q?1XGtMxe1p+Jq2nVqX9Np/Qsp2Gp4Tuf0P6f0DFXSgK/5aPPC0PO0VeYIeifP?=
 =?us-ascii?Q?cgkbAGlbm4tg3viuRiXEy5/EXhSVVByUAhhKWiZI67r5FKnbCJApx8ItP1+E?=
 =?us-ascii?Q?DsNMhAwaSkvrJvzqNzxBR44+vs2yxKzXSU/xpog3J4uboDFfSL24E8JXHmqz?=
 =?us-ascii?Q?FoIzk9ynTNp3Ea3yT1Etu5Z6Uyylc64zb0GaAAd544HY3tfhaT8YPBhOmYc5?=
 =?us-ascii?Q?yQLzQxNoSb0axilC/YSKogZRLyKuyaGhFpUQstJvBY/iFml0uT70730+gY4h?=
 =?us-ascii?Q?i9Ek0wen6CWzY+5s1B9tzqEojMuXjinYcDyCVcO7uk8PrjSBrcdY1kLYia5v?=
 =?us-ascii?Q?BGf1qsWVo5vCXUuzEoouvc5F3Sdbaz5NVVlNG87DjGPpxGPVDSZqLxvh/P+T?=
 =?us-ascii?Q?vKOdjAmcgl1akYni4c1cO9yGQAlJN++ZiTEQ0OglRwLTjXe1rtVkaCokc2m/?=
 =?us-ascii?Q?tlA+M0MThHaB5Sl1dCkVsskBbYevNbcfa3Ded+pA8VC4xLOeg4Ijq7PT3tXm?=
 =?us-ascii?Q?Zro0RZ9gMknKHQAscUMUHb6aJl2VG8V3o+BKyz1Q6UBRTocrwcobFSB6Bubn?=
 =?us-ascii?Q?4mECJIAm91LgcXBdOlL96cSsFZBEmi8ZckP/L2A89Ss7k5HasPCqnqd/QuQA?=
 =?us-ascii?Q?xFgH11TzfMKyW4Qab+DAB22uGJseriy4wHjy6GU9SrkgxmY9wDQGcpQrBHTM?=
 =?us-ascii?Q?3XMzHxaEUqFWmSjwZ3ImvmLjhkBXcu9Gee8IEJS9aBqZ53HgPO2Hqh2+ezpZ?=
 =?us-ascii?Q?he/b34ZIO9xA0gTRezuFXVors09cGLYimIRSpENScrM9Hvv87UzmGLhNiSph?=
 =?us-ascii?Q?TZdEFgU2sq9wiBf19z9zGrnfy6ypPj5Zs9fK9gZG+MDCoRr8tG+hsqF0d0zp?=
 =?us-ascii?Q?OWrXZCT3+L6Ds+4T8ph3/fX0o/dWLkznj/2IPiz7irsbfF1YqUiVh6sMBmp3?=
 =?us-ascii?Q?ADAEnvTcII83NGuw55IHbpPONE6AovnjGpQYNoSSlNYktcA+CmvZk+LAPqqi?=
 =?us-ascii?Q?HsJtBbKkwdF5sTcff36jzDaIOpIj7MvzPbGOyjk8QW+Kd00ezpDTm9k9UT2H?=
 =?us-ascii?Q?ZcWoLF1jwbmxEwuFyTP1lmza63Z76W/6iKzqE7KlK7yuC+ADIb6UVwHPMEQu?=
 =?us-ascii?Q?CL5AK4T2jG2XsDtDumeePZYtIQMUI2ytV6vQQ6Nder4Cy6DyMf7OJd5uHtID?=
 =?us-ascii?Q?N+88a5bMRE5EPcqAF3ft9/n6CE5jqJYQFKp72sH0/ODIdMazJqz5UKh8SFI/?=
 =?us-ascii?Q?kF8rrJKmWCcfR6OXEDhVeF7zOTi5qmxM5KHZoLJvjonB7mOGnx3jh/IY4DUQ?=
 =?us-ascii?Q?Rj5oWPLwzZDvVXLjDQivOUbmCrDJKajsAnYJ5HKZ5lQfJqqSx1zSqoSO1m6q?=
 =?us-ascii?Q?WCsgVCTXv730msjKbup4Qe0LC8EuyjCU/Zwo74obpelcLML5pCjREFDHft7A?=
 =?us-ascii?Q?gTDlIb3N/AypTxuNGwBTOsc=3D?=
X-OriginatorOrg: renesas.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 63db1afa-fc8d-49f6-daaa-08db0d54cc7a
X-MS-Exchange-CrossTenant-AuthSource: OS3PR01MB8426.jpnprd01.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Feb 2023 23:56:46.3011
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 53d82571-da19-47e4-9cb4-625a166a4a2a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: bb9ftjADzuL3U8HQ3RWYTBn5gJC46Fdup6FL+UeSJUEpIaSn8gTGktyRUzBbfuZDW4e93Yc1uW0o7hPiKeWpwM3I3j33GxRaqi80x2L0JJ/IsmpjCcQuUPXnxKYevHHJ
X-MS-Exchange-Transport-CrossTenantHeadersStamped: TY3PR01MB9795
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


Hi Sameer

> > Simple-card/audio-graph-card both are using asoc_simple_hw_params,
> > and it calls clk_set_rate() for Codec/CPU if it has mclk.
> > But am I misunderstanding ?
> > If it was simple-card-utils side miss, I'm happy to fix it.
> 
> The simple-card-utils driver does not populate the clock handle whenever 
> the MCLK clock is parsed from CODEC device node. So 
> asoc_simple_set_clk_rate() will not update the rate and clock 
> enable/disable won't happen either.Initially I had tried to fix this in 
> the simple-card-utils itself and it did break few things on other HW.
> Please see [0] for relevant discussion.
> 
> Later [1] was pushed to address the issue I was facing that time.
> 
> In summary, the suggestion was, clock property should be associated with 
> only devices and device driver should own up the clock handling for it. 
> The machine driver can just pass the required configuration for it.

Thank you for explanation about your issue,
I think I could understand it.

Thank you for your help !!

Best regards
---
Kuninori Morimoto