From:   Mike Christie <michael.christie@oracle.com>
To:     brauner@kernel.org, ebiederm@xmission.com,
        torvalds@linux-foundation.org, linux-kernel@vger.kernel.org
Cc:     Mike Christie <michael.christie@oracle.com>
Subject: [PATCH 5/5] kernel: Convert kthread to use setup_thread_fn
Date:   Sun, 12 Feb 2023 19:00:20 -0600
Message-Id: <20230213010020.1813-6-michael.christie@oracle.com>
In-Reply-To: <20230213010020.1813-1-michael.christie@oracle.com>
References: <20230213010020.1813-1-michael.christie@oracle.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?rKGjVcjVF4JP4uQ9J5L6rWF68qttmHs0J1KeiKfUL7x8gEwwywHY5cOSU8Qd?=
 =?us-ascii?Q?FXU1BPuWM/OqXBXtCW4Jv3bP8AW0hAbboXUD4osLVE0G6dMOPpbh70GhGR/O?=
 =?us-ascii?Q?KyIjlnl5D97bA0OqYMoLN3JBEa1Z/5pxzNa1xjMlHdMxXOcANWetWJ8qxvfP?=
 =?us-ascii?Q?uiZR3UNCaAPHDvUXOboMsAnOzzqXBClMVHQKLMYi80wLlRZ99pqElVP56S0f?=
 =?us-ascii?Q?cvC4CG8RRCYPsfZ3iV+mdjCcW7yfnAybxgyHMlIEjmNcBC8e10+xagPoU6P0?=
 =?us-ascii?Q?gXcJV7U51RowstohZoYGCklGPJGSmJa+w1vF1hTpaAmp/ZihB0k5xAFF/yTs?=
 =?us-ascii?Q?hgPfkAQDx6wiH/seHCtx84AClT024hMNmdiCxQTPut8BNKm/A6a1fW1qL9wv?=
 =?us-ascii?Q?0b5zvvhRFXv24vi4kJhO0XdWz5Pn8K4nJNwn536g/it29Zo4m45RS9ppw6Pi?=
 =?us-ascii?Q?FfCSl+cCoUnpiYooX4HHgLC8PxKeZJlSsk1xR5lQpd9+RVEJB2m7lmOoydyW?=
 =?us-ascii?Q?km8hblW1yPftCxj0zHZo0fTLGBrfR26b1iFxeageFyYWDnvZ5lApStKdgrHQ?=
 =?us-ascii?Q?TZvVWL1UQ6cMl4LjE8N5RyVILNqK6VdcTvieeb1rPWSamB3yBuZcYhKI5oxm?=
 =?us-ascii?Q?J77Huwq2vy58xszmA75LuIKAbP8CJGXpmn3afIq83K5YB54+H8Prj++AEufM?=
 =?us-ascii?Q?Mlmlts3HaS0Abplmeh+BdmqoP9c+hZ1EMg9wofT63zxpgBScHQuOnwVLqF2N?=
 =?us-ascii?Q?Dpw99/qnaobdNwgnPe6oR3JvmirEXlU7wqloDWQVtH8K4D/khsiZLe3Ed8jP?=
 =?us-ascii?Q?mIIK2tFVWvkkQsZigVwLXPZjwC0Zd5pZlzk07o7qcmTjBayKeNQTnmWhXKji?=
 =?us-ascii?Q?y5hSnmU02AR7ohceO24Ur5kNnZ7aqARMPA0T83qKZ2zPVsLO30Ss3t7DiR4Y?=
 =?us-ascii?Q?PMHKuuTIrAUbv6lAFTG3fTg2YycQCRj9LEv4a6nuZn25cu2Q8dcTi3M5HEMe?=
 =?us-ascii?Q?n0l+GVDWZ1DKI1N74+P+OC1Ldt5rcU+mWhMuYJ+35MAtNvSfa4yKtT/N4v2b?=
 =?us-ascii?Q?bAsEW5rP5YhrPoKu1E4tf6JcsrX1G7S39yPYIMPn/Rj4XiVO8dAfl8NWDW9H?=
 =?us-ascii?Q?6RhXyrgd4VfjyYzqnbeok5MoGqamG+PL4IZHz8bN6CjUpQ0IwCwpSvtTWrH2?=
 =?us-ascii?Q?sF7q/+FUO3IWv0r85Ha7SO63+pr/bJP7CuhBwsnX6/j0lVngmmW0mZYah0f3?=
 =?us-ascii?Q?zZlnBs+CAh6x1X8VBZBGRWBshWFRbcZ7s/mqg1pWLAkexalfLGRidxLGA8Fs?=
 =?us-ascii?Q?V6455sW9Vbon3rwcdJSFX69ZZ0B5p2tzIYFZwdvgMIXNyCb6ol3o5m62os8F?=
 =?us-ascii?Q?KswJSB3RuQCOrQN+CQH/paz3Ika+/fZr8zxcj2740t0Eq7EC18hktFeuEXe/?=
 =?us-ascii?Q?YHHSuh7ePeOCsk+qmJfs49q6mpCZGEbfq07e9j9prubTQWnSrEnaYTZ2DgDV?=
 =?us-ascii?Q?5MKaqDvTVpTDrNjfRNFxPRgUqYkjFDsnfozdPfKmXg9NzBtyccqrhqM6RrNK?=
 =?us-ascii?Q?oCLaFkp5PrW0VVh7AuQicfFBI3bqut0+dnPXscaMx/aiGht+9EtXPOfQpqG6?=
 =?us-ascii?Q?kg=3D=3D?=
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: 6ybF7IugkYg4hTi8orUZRiG/fp9a9wGLWwjikHL7Efph5+CHjjZDgYVtE1xElh7FVN4Fix3telwIHQQfw3NP9DP19Ig9WYD0cmeDakDyTUk7ByNovw9eArcLdc1UVpJxfuPO9qhYUsTmKGLGBAmSDyYftVVHlmB8oA7HWFo52NCEuVznf5W2ph3csP7uYJsr/mv7GSc1mgpOG5DOsd8ZxSK/ZFEI669hcZi4WiMFOsdRZa+yjIwP6nlPZlBpyd3s77QCryC8GfRnTcXkiQJL5sRw1L5YsFnV4Qq0AOQ8761sKO0draT+JBZ7cfEI6icJSw2FwApDDVmTohPQlOTwe+Yr/ZhaDQa5qPRyMExzEjMeE8JoBlu7lJ3ptXV47aWTUPRY13clKpEf22GnYy143Z7hArN0VmsnNekStIorDPZp5l0tXeyUancvdObEUmmzuPhPlEsYactBk7tSjQ/bncH6qKpeCCBqVWmEFkRYf/X+5zf1VbxQIMkF7IqXyOdt4e7lMAa2pB0CaPNRbwfSvkyxnt6zryuyOiXTVjFcP3lNUtMiqhiWyrSveuPltVBBgptpkDyhOLUU0JjPsgcufKGK8+0fK2asCyjM+/ktuIjlTilMClkm7Bzy+SxDESFQGLKeUMofHh7BRpTGCS3qRV8wyMOUFywJhw2wXFM+7QqXslGlza3pLERb6m5v6o9slhoO0+hspU9b790vAjxRcQ5tSIB2+DVw/38ogdzSJUv2POSOZgOEFi76he3a+DhN8VnBs+KiZx9jRvdtwyITf5Ekgca9Fpb5rmM/7mTTzqg1ec7kpzj+MBAa3mfCMc9DBjcc8lqGfYCawPY3DJqErXtLISy+h4+iXfnAKTn8VlZJtSlLYg9bzI4VSiT6CE41
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: c0410924-2526-46bb-ed26-08db0d5db95f
X-MS-Exchange-CrossTenant-AuthSource: DM5PR10MB1466.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Feb 2023 01:00:39.7966
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: qc1UgzpFjiZ+FqSAVC3tJu1uHh0B3CcnVpLMmY/RFKVrVVAj98R+oX1xdL2yOg4O2S+9WDBtDpIZNYy6rUPqfUA6qzX+ZBKmu+HbHQyrEaY=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH0PR10MB4921
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.219,Aquarius:18.0.930,Hydra:6.0.562,FMLib:17.11.170.22
 definitions=2023-02-12_12,2023-02-09_03,2023-02-09_01
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 malwarescore=0 bulkscore=0 adultscore=0
 mlxlogscore=999 phishscore=0 spamscore=0 mlxscore=0 suspectscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2212070000
 definitions=main-2302130007
X-Proofpoint-GUID: Airdgt-bD4DuRjolji43sYD9ODEezn35
X-Proofpoint-ORIG-GUID: Airdgt-bD4DuRjolji43sYD9ODEezn35
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

kthread_setup_struct can now setup the kthread struct and setup the
comm, so remove the call to kthread_setup_struct in copy_process and
have kthread.c set the setup_thread_fn callback, so it works like
io_uring.

Signed-off-by: Mike Christie <michael.christie@oracle.com>
---
 kernel/fork.c    | 5 +----
 kernel/kthread.c | 1 +
 2 files changed, 2 insertions(+), 4 deletions(-)

diff --git a/kernel/fork.c b/kernel/fork.c
index bd60ecc6b29c..7cdd85befa41 100644
--- a/kernel/fork.c
+++ b/kernel/fork.c
@@ -2189,10 +2189,6 @@ static __latent_entropy struct task_struct *copy_process(
 	p->io_context = NULL;
 	audit_set_context(p, NULL);
 	cgroup_fork(p);
-	if (args->kthread) {
-		if (kthread_setup_struct(p, args->fn_arg))
-			goto bad_fork_cleanup_delayacct;
-	}
 #ifdef CONFIG_NUMA
 	p->mempolicy = mpol_dup(p->mempolicy);
 	if (IS_ERR(p->mempolicy)) {
@@ -2598,6 +2594,7 @@ struct task_struct * __init fork_idle(int cpu)
 	struct task_struct *task;
 	struct kernel_clone_fns fns = {
 		.thread_fn	= &idle_dummy,
+		.setup_thread_fn = kthread_setup_struct,
 	};
 	struct kernel_clone_args args = {
 		.flags		= CLONE_VM,
diff --git a/kernel/kthread.c b/kernel/kthread.c
index b67c2caf2ccb..7776d19789f6 100644
--- a/kernel/kthread.c
+++ b/kernel/kthread.c
@@ -429,6 +429,7 @@ int tsk_fork_get_node(struct task_struct *tsk)
 
 static struct kernel_clone_fns thread_clone_fns = {
 	.thread_fn	= kthread,
+	.setup_thread_fn = kthread_setup_struct,
 };
 
 static void create_kthread(struct kthread_create_info *create)
-- 
2.25.1