Message-ID: <d9adef45-82c3-52fa-1261-c2df88c95639@quicinc.com>
Date:   Mon, 13 Feb 2023 10:37:35 +0530
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.6.1
Subject: Re: [PATCH V3] arm64: defconfig: Enable scm download mode config for
 IPQ Targets
To:     Bjorn Andersson <andersson@kernel.org>
CC:     <agross@kernel.org>, <konrad.dybcio@linaro.org>,
        <robh+dt@kernel.org>, <krzysztof.kozlowski+dt@linaro.org>,
        <lee@kernel.org>, <mturquette@baylibre.com>, <sboyd@kernel.org>,
        <jassisinghbrar@gmail.com>, <catalin.marinas@arm.com>,
        <will@kernel.org>, <shawnguo@kernel.org>, <arnd@arndb.de>,
        <marcel.ziswiler@toradex.com>, <robimarko@gmail.com>,
        <dmitry.baryshkov@linaro.org>, <nfraprado@collabora.com>,
        <broonie@kernel.org>, <quic_gurus@quicinc.com>,
        <linux-arm-msm@vger.kernel.org>, <linux-clk@vger.kernel.org>,
        <devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
        <linux-arm-kernel@lists.infradead.org>,
        <quic_srichara@quicinc.com>, <quic_gokulsri@quicinc.com>,
        <quic_sjaganat@quicinc.com>, <quic_kathirav@quicinc.com>,
        <quic_arajkuma@quicinc.com>, <quic_anusha@quicinc.com>,
        <quic_devipriy@quicinc.com>
References: <20230208053332.16537-1-quic_poovendh@quicinc.com>
 <20230208053332.16537-5-quic_poovendh@quicinc.com>
 <20230208214254.nabavfpj5ymdgr3a@ripper>
Content-Language: en-US
From:   POOVENDHAN SELVARAJ <quic_poovendh@quicinc.com>
In-Reply-To: <20230208214254.nabavfpj5ymdgr3a@ripper>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk


On 2/9/2023 3:12 AM, Bjorn Andersson wrote:
> On Wed, Feb 08, 2023 at 11:03:31AM +0530, Poovendhan Selvaraj wrote:
>> Enabling the download mode config by default as the IPQ Targets use
>> crashdump feature extensively to debug crashes.
>>
> No thanks.
>
> You can pass qcom_scm.download_mode=1 on the kernel command line to turn
> this on dynamically when you want it. There's no reason to attempt
> enabling download mode on every Qualcomm board running the upstream
> kernel.
>
> Regards,
> Bjorn

Okay sure...i will remove this patch in next series.

Regards,
Poovendhan S

>> Signed-off-by: Poovendhan Selvaraj <quic_poovendh@quicinc.com>
>> ---
>>   Changes in V3:
>> 	- Updated the commit message
>>
>>   arch/arm64/configs/defconfig | 1 +
>>   1 file changed, 1 insertion(+)
>>
>> diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig
>> index 37a60df14e1d..42c9ccdbf0dc 100644
>> --- a/arch/arm64/configs/defconfig
>> +++ b/arch/arm64/configs/defconfig
>> @@ -258,6 +258,7 @@ CONFIG_ARM_SCPI_PROTOCOL=y
>>   CONFIG_RASPBERRYPI_FIRMWARE=y
>>   CONFIG_INTEL_STRATIX10_SERVICE=y
>>   CONFIG_INTEL_STRATIX10_RSU=m
>> +CONFIG_QCOM_SCM_DOWNLOAD_MODE_DEFAULT=y
>>   CONFIG_EFI_CAPSULE_LOADER=y
>>   CONFIG_IMX_SCU=y
>>   CONFIG_IMX_SCU_PD=y
>> -- 
>> 2.17.1
>>