Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8D433C636D7 for ; Mon, 13 Feb 2023 05:27:18 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229904AbjBMF1R (ORCPT ); Mon, 13 Feb 2023 00:27:17 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39832 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229485AbjBMF1P (ORCPT ); Mon, 13 Feb 2023 00:27:15 -0500 Received: from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com [148.163.156.1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6E340EB5A; Sun, 12 Feb 2023 21:27:14 -0800 (PST) Received: from pps.filterd (m0098399.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 31D5BC3D024330; Mon, 13 Feb 2023 05:27:03 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=from : to : cc : subject : in-reply-to : references : date : message-id : mime-version : content-type : content-transfer-encoding; s=pp1; bh=2qAHun67YDL1ANmg/gkNMnPX1mBWFtofWsMAq4D/I6A=; b=cpfQ4hhyx+JmiCWgWLqSRQbpDeZ/PK0VxgLydhAxeG6cZvY1+SdT7WgdcfeMEfjAuQ+p /JyuAZpe20kdYbPTh+okUYBu1C+rudi8eojlmAmO10+7yJcVBBhOMUejJaePSI+Itp+q P9cJ6qgk5dt4joV8+jHILATAwdK56PubPCw78ZjHA/iu+3CndVafU/z9zleLNQ7/yxnd ksHPN8TYgvbc0E76ztv25hjn/Z0+hqftbCLpscLrTd0tTf6qSdSe89daP43smW2l0OM2 /0QJDbIpEhbZHLvoIhYsT8LQmziiMni72ZQJut5zcQpPezlwkKpkxAnsv/a7nEN2qzWK Qg== Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3nq4xps6rn-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 13 Feb 2023 05:27:03 +0000 Received: from m0098399.ppops.net (m0098399.ppops.net [127.0.0.1]) by pps.reinject (8.17.1.5/8.17.1.5) with ESMTP id 31D5R2nO013565; Mon, 13 Feb 2023 05:27:02 GMT Received: from ppma03ams.nl.ibm.com (62.31.33a9.ip4.static.sl-reverse.com [169.51.49.98]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3nq4xps6r5-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 13 Feb 2023 05:27:02 +0000 Received: from pps.filterd (ppma03ams.nl.ibm.com [127.0.0.1]) by ppma03ams.nl.ibm.com (8.17.1.19/8.17.1.19) with ESMTP id 31CJ2N3F017578; Mon, 13 Feb 2023 05:27:00 GMT Received: from smtprelay07.fra02v.mail.ibm.com ([9.218.2.229]) by ppma03ams.nl.ibm.com (PPS) with ESMTPS id 3np2n6j5ma-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 13 Feb 2023 05:27:00 +0000 Received: from smtpav06.fra02v.mail.ibm.com (smtpav06.fra02v.mail.ibm.com [10.20.54.105]) by smtprelay07.fra02v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 31D5Qvcr50004354 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 13 Feb 2023 05:26:57 GMT Received: from smtpav06.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id AC28420040; Mon, 13 Feb 2023 05:26:57 +0000 (GMT) Received: from smtpav06.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 1911D20043; Mon, 13 Feb 2023 05:26:57 +0000 (GMT) Received: from ozlabs.au.ibm.com (unknown [9.192.253.14]) by smtpav06.fra02v.mail.ibm.com (Postfix) with ESMTP; Mon, 13 Feb 2023 05:26:57 +0000 (GMT) Received: from localhost (unknown [9.177.92.162]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.au.ibm.com (Postfix) with ESMTPSA id BA7E3600BA; Mon, 13 Feb 2023 16:26:50 +1100 (AEDT) From: Michael Ellerman To: Andrew Donnellan , Stefan Berger , linuxppc-dev@lists.ozlabs.org, linux-integrity@vger.kernel.org Cc: sudhakar@linux.ibm.com, erichte@linux.ibm.com, gregkh@linuxfoundation.org, nayna@linux.ibm.com, npiggin@gmail.com, linux-kernel@vger.kernel.org, zohar@linux.ibm.com, gjoyce@linux.ibm.com, ruscur@russell.cc, joel@jms.id.au, bgray@linux.ibm.com, brking@linux.ibm.com, gcwilson@linux.ibm.com Subject: Re: [PATCH v6 24/26] powerpc/pseries: Implement secvars for dynamic secure boot In-Reply-To: References: <20230210080401.345462-1-ajd@linux.ibm.com> <20230210080401.345462-25-ajd@linux.ibm.com> Date: Mon, 13 Feb 2023 16:26:45 +1100 Message-ID: <87y1p2uodm.fsf@mpe.ellerman.id.au> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-TM-AS-GCONF: 00 X-Proofpoint-ORIG-GUID: 1m_fVLMazNjP5KgcCuuoM2G21Cc_E33d X-Proofpoint-GUID: xrUCJ2msPrTUMSeGrnBVJOfYyGHXJCOh X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.219,Aquarius:18.0.930,Hydra:6.0.562,FMLib:17.11.170.22 definitions=2023-02-13_02,2023-02-09_03,2023-02-09_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 lowpriorityscore=0 clxscore=1011 spamscore=0 bulkscore=0 suspectscore=0 mlxscore=0 mlxlogscore=908 impostorscore=0 priorityscore=1501 adultscore=0 phishscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2212070000 definitions=main-2302130041 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Andrew Donnellan writes: > On Fri, 2023-02-10 at 16:28 -0500, Stefan Berger wrote: >> > > +err: >> > > +=C2=A0=C2=A0=C2=A0 kfree(var.data); >> >=20 >> > remove the kfree() >>=20 >> Actually don't remove it but it should probably be >>=20 >> if (var.data !=3D &version) >> =C2=A0=C2=A0=C2=A0=C2=A0 kfree(var.data); >>=20 > > Argh, thanks for catching this. > > I don't think the condition is needed - we can assume the var.data is > unmodified. > > mpe, are you able to fix this up in merge? Yeah, can you reply here with the delta you want applied. cheers