MIME-Version: 1.0
References: <20230131114632.14078-1-fengqi706@gmail.com> <CACOZ=ZU0zgRmoRu8X5bMUzUrXA9x-qoDJqrQroUs=+qKR58MQA@mail.gmail.com>
In-Reply-To: <CACOZ=ZU0zgRmoRu8X5bMUzUrXA9x-qoDJqrQroUs=+qKR58MQA@mail.gmail.com>
From:   qi feng <fengqi706@gmail.com>
Date:   Mon, 13 Feb 2023 14:09:31 +0800
Message-ID: <CACOZ=ZXDDWxPFt7sbpiOzh3WHcJN0xPod1YzSj07FMADaXHTuQ@mail.gmail.com>
Subject: Re: [PATCH v2] HID: add KEY_CAMERA_FOCUS event in HID
To:     jikos@kernel.org
Cc:     benjamin.tissoires@redhat.com, rydberg@bitmath.org,
        linux-input@vger.kernel.org, linux-kernel@vger.kernel.org,
        fengqi <fengqi@xiaomi.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

Thanks for your help to review


loop more

qi feng <fengqi706@gmail.com> =E4=BA=8E2023=E5=B9=B42=E6=9C=887=E6=97=A5=E5=
=91=A8=E4=BA=8C 10:35=E5=86=99=E9=81=93=EF=BC=9A
>
> Hi=EF=BC=8C
>
> Please help to review this  v2 code
>
> thanks a lot
>
> Qi Feng <fengqi706@gmail.com> =E4=BA=8E2023=E5=B9=B41=E6=9C=8831=E6=97=A5=
=E5=91=A8=E4=BA=8C 19:46=E5=86=99=E9=81=93=EF=BC=9A
> >
> > From: fengqi <fengqi@xiaomi.com>
> >
> > Our HID device need KEY_CAMERA_FOCUS event to control camera, but this
> > event is non-existent in current HID driver.we add this event in hid-in=
put.c
> > We committed this v2 version following your previous suggestion
> >
> > Signed-off-by: fengqi <fengqi@xiaomi.com>
> > ---
> >  drivers/hid/hid-input.c | 7 +++++++
> >  include/linux/hid.h     | 1 +
> >  2 files changed, 8 insertions(+)
> >
> > diff --git a/drivers/hid/hid-input.c b/drivers/hid/hid-input.c
> > index 9b59e436df0a..05fa3e191574 100644
> > --- a/drivers/hid/hid-input.c
> > +++ b/drivers/hid/hid-input.c
> > @@ -1221,6 +1221,13 @@ static void hidinput_configure_usage(struct hid_=
input *hidinput, struct hid_fiel
> >                         return;
> >                 }
> >                 goto unknown;
> > +       case HID_UP_CAMERA:
> > +               switch (usage->hid & HID_USAGE){
> > +               case 0x020: map_key_clear(KEY_CAMERA_FOCUS);    break;
> > +               case 0x021: map_key_clear(KEY_CAMERA);          break;
> > +               default:        goto ignore;
> > +               }
> > +               break;
> >
> >         case HID_UP_HPVENDOR:   /* Reported on a Dutch layout HP5308 */
> >                 set_bit(EV_REP, input->evbit);
> > diff --git a/include/linux/hid.h b/include/linux/hid.h
> > index 8677ae38599e..e3daf2c7739c 100644
> > --- a/include/linux/hid.h
> > +++ b/include/linux/hid.h
> > @@ -155,6 +155,7 @@ struct hid_item {
> >  #define HID_UP_DIGITIZER       0x000d0000
> >  #define HID_UP_PID             0x000f0000
> >  #define HID_UP_BATTERY         0x00850000
> > +#define HID_UP_CAMERA          0x00900000
> >  #define HID_UP_HPVENDOR         0xff7f0000
> >  #define HID_UP_HPVENDOR2        0xff010000
> >  #define HID_UP_MSVENDOR                0xff000000
> > --
> > 2.39.0
> >