From:   Hariprasad Kelam <hkelam@marvell.com>
To:     Simon Horman <simon.horman@corigine.com>
CC:     "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "kuba@kernel.org" <kuba@kernel.org>,
        "davem@davemloft.net" <davem@davemloft.net>,
        "pabeni@redhat.com" <pabeni@redhat.com>,
        "edumazet@google.com" <edumazet@google.com>,
        Sunil Kovvuri Goutham <sgoutham@marvell.com>,
        Linu Cherian <lcherian@marvell.com>,
        Geethasowjanya Akula <gakula@marvell.com>,
        Jerin Jacob Kollanukkaran <jerinj@marvell.com>,
        Subbaraya Sundeep Bhatta <sbhatta@marvell.com>,
        "jhs@mojatatu.com" <jhs@mojatatu.com>,
        "xiyou.wangcong@gmail.com" <xiyou.wangcong@gmail.com>,
        "jiri@resnulli.us" <jiri@resnulli.us>,
        "saeedm@nvidia.com" <saeedm@nvidia.com>,
        "richardcochran@gmail.com" <richardcochran@gmail.com>,
        "tariqt@nvidia.com" <tariqt@nvidia.com>,
        "linux-rdma@vger.kernel.org" <linux-rdma@vger.kernel.org>,
        "maxtram95@gmail.com" <maxtram95@gmail.com>,
        Naveen Mamindlapalli <naveenm@marvell.com>,
        "bpf@vger.kernel.org" <bpf@vger.kernel.org>,
        "hariprasad.netdev@gmail.com" <hariprasad.netdev@gmail.com>
Subject: Re: [net-next Patch V4 2/4] octeontx2-pf: qos send queues management
Thread-Topic: [net-next Patch V4 2/4] octeontx2-pf: qos send queues management
Thread-Index: AQHZP3MQZvDbYymWt0CrV5vTm5G1tg==
Date:   Mon, 13 Feb 2023 06:19:01 +0000
Message-ID: <CO6PR18MB44671631BA1F0148A8B9D405DEDD9@CO6PR18MB4467.namprd18.prod.outlook.com>
References: <20230210111051.13654-1-hkelam@marvell.com>
 <20230210111051.13654-3-hkelam@marvell.com> <Y+ZfAC/5NjiuPfQE@corigine.com>
In-Reply-To: <Y+ZfAC/5NjiuPfQE@corigine.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?AkA7ffWm0y+f+Qn4c7p6LeG5tHIC4NkgyRJRcH9UijOPY9SAqbNdShyq8ryk?=
 =?us-ascii?Q?jLKAq+15r+Jdo1lokZceSKDu9OTMidWs6l+7mGTcK81CP2T33HVTqd4gQyOb?=
 =?us-ascii?Q?aq6QCK96Z+2a0GHDyQ4bu+7Ykn1YeISQVKM3hZ3Wlhb14lt6eGnDSKIcPF6I?=
 =?us-ascii?Q?m4xSVoMWBgcNQRbAfV0xXUb2jMK2cfUke4hUhqZEjR4Um16ewXLSZqTNpEYx?=
 =?us-ascii?Q?Ia9Lj/d7uuVbWjAhEzVrjf1XQmICQYmh8Eg+oRsCBnLM3qF9eXoYEnR6wko4?=
 =?us-ascii?Q?grxZcx8d0ZUQa1cCHlwO30j+yQ0Qzmp8hnw0Im2JHHQnV4agheebwPReUJzR?=
 =?us-ascii?Q?0WeBYMW1W06KS8+f1ds+LhCi3efVVpzy11NShi10Jfgt/SIuvIlE49HT5ZVb?=
 =?us-ascii?Q?kUfFDJc9WEAp63WuTiP8Mo7CSmCTpWkETa652H8Dq7kr9NA103OAjAyV2QjY?=
 =?us-ascii?Q?uU8pkS2ODs9F4Xk+FqbJkmm9DvpOtW/+pNYC4DXzZ591QKcpVFXYNpSWSJwX?=
 =?us-ascii?Q?1wQtooPY/cFGQ+5leMZNiHrBIza04ro1MjilFZlNlZ7tTogAcjxxrp1crLsF?=
 =?us-ascii?Q?ErO9cQdpqrwUW56O0g788nAn2ZonQBpyBlgTfoael5I2NGh0g0CbaI6/bVNB?=
 =?us-ascii?Q?T84sXffVg7weWpspH3qSzf1xYXnTvL+/dR7HZpgQUpa1lCD+qbkFPxHE/KJ8?=
 =?us-ascii?Q?U86qt1VFUBkekCbxT9UIJwvS4vEIKpH3Ms45goLxAfdDKIYSKKDEC7afn8Be?=
 =?us-ascii?Q?bI7TpHyleSB+ZJD69KV6ltLP8QDOT1yedq+fepkdgPkD0QXXwf51EkvE4pTf?=
 =?us-ascii?Q?cLOR8UkcM7HeUZ+rTuIzpudOpGEbIhNUEeIFkKS+Alv7UUFRtHwAm+u6iilj?=
 =?us-ascii?Q?eE76mJk8fFQApKRb0o6S3Zis+aEFdsb4SY1xqoKXzWY2NRbtfHMufRsyIi61?=
 =?us-ascii?Q?Q3kj0X9yIHD73QtNtCB0fWKcfOXZrP1uBSBV+eaeoXJno7rk6I/btgoKuFI/?=
 =?us-ascii?Q?Eiz8iDMhwx1YyJBAou+xjfBpUBz+uGKuyZ8eCw8ssNp47J3mMzxlCdsNWUeV?=
 =?us-ascii?Q?cEoT3xPaRHB0kXq9dXZovbNvut4kjeATf9ytQsWotftqm+aJSFA5kz9IES9H?=
 =?us-ascii?Q?okRwtuR1neYJnSHs4RNPWHGLVbM3rcEaQgPQ/GppD6uOCATmuo2IszEzs3Ik?=
 =?us-ascii?Q?Zj9N5ro6kK1is+J4v9sKlj6U3EdIY93GaN/R0GF8A/we3/DbcJ2fonjAIxk9?=
 =?us-ascii?Q?jM9pbeXluTNeJkH0Dqkbev6OfWMxwK54UTwapnL/pOl1zWD1ewl/QDa76Kdn?=
 =?us-ascii?Q?2WAC2tqQzudx/m/82hrSa+72XoOIVX4iMED/7qLIKeFE4VDmT/ruYbRO9QrZ?=
 =?us-ascii?Q?H0BQZCvLr7mjvSvdc1q9ugSHPo4sRUBzGwVymW0925koaCO1EIeSw2OwJ40c?=
 =?us-ascii?Q?4evfS8GKFLPsSIfw/6aG2oKsCbcgZLPpASugxBruC3QYUKJGuIgu3zVvG5Hm?=
 =?us-ascii?Q?h6K0+yXMwZa3upHdF+gXI1DBoVput2m/j1lPbRPMcT6kvqG9gC9XIWTmAOnL?=
 =?us-ascii?Q?+JBMzwPON1L4TORcxoXxV6APi+qAAYWFO/Ebicz2?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: marvell.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: CO6PR18MB4467.namprd18.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 2d79abbf-ec11-4298-a239-08db0d8a3344
X-MS-Exchange-CrossTenant-originalarrivaltime: 13 Feb 2023 06:19:01.9372
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: 5TWKdAhJIu+ZEDyQIS/j4IZsxMyhqWMJ+X/xWQwgxUhYu++4DJflNujWAo6wmLC7IQqMGcHbZeOUneHhASiFcQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN7PR18MB4016
X-Proofpoint-GUID: 27-uWUfcYJ8s1kGfv-HGTKIGWy-jDuxu
X-Proofpoint-ORIG-GUID: 27-uWUfcYJ8s1kGfv-HGTKIGWy-jDuxu
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.219,Aquarius:18.0.930,Hydra:6.0.562,FMLib:17.11.170.22
 definitions=2023-02-13_02,2023-02-09_03,2023-02-09_01
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


> -----Original Message-----
> From: Simon Horman <simon.horman@corigine.com>
> On Fri, Feb 10, 2023 at 04:40:49PM +0530, Hariprasad Kelam wrote:
> > From: Subbaraya Sundeep <sbhatta@marvell.com>
> >
> > Current implementation is such that the number of Send queues (SQs)
> > are decided on the device probe which is equal to the number of online
> > cpus. These SQs are allocated and deallocated in interface open and c
> > lose calls respectively.
> >
> > This patch defines new APIs for initializing and deinitializing Send
> > queues dynamically and allocates more number of transmit queues for
> > QOS feature.
> >
> > Signed-off-by: Subbaraya Sundeep <sbhatta@marvell.com>
> > Signed-off-by: Hariprasad Kelam <hkelam@marvell.com>
> > Signed-off-by: Sunil Kovvuri Goutham <sgoutham@marvell.com>
> > ---
> >  .../marvell/octeontx2/af/rvu_debugfs.c        |   5 +
> >  .../ethernet/marvell/octeontx2/nic/Makefile   |   2 +-
> >  .../marvell/octeontx2/nic/otx2_common.c       |  40 ++-
> >  .../marvell/octeontx2/nic/otx2_common.h       |  29 +-
> >  .../ethernet/marvell/octeontx2/nic/otx2_pf.c  |  51 ++-
> >  .../marvell/octeontx2/nic/otx2_txrx.c         |  25 +-
> >  .../marvell/octeontx2/nic/otx2_txrx.h         |   3 +-
> >  .../ethernet/marvell/octeontx2/nic/otx2_vf.c  |   9 +-
> >  .../net/ethernet/marvell/octeontx2/nic/qos.h  |  19 ++
> >  .../ethernet/marvell/octeontx2/nic/qos_sq.c   | 290 ++++++++++++++++++
> >  10 files changed, 430 insertions(+), 43 deletions(-)  create mode
> > 100644 drivers/net/ethernet/marvell/octeontx2/nic/qos.h
> >  create mode 100644
> > drivers/net/ethernet/marvell/octeontx2/nic/qos_sq.c
>=20
> nit: this patch is a little long
>=20
ACK, will split this patch.
> > diff --git a/drivers/net/ethernet/marvell/octeontx2/nic/otx2_txrx.c
> > b/drivers/net/ethernet/marvell/octeontx2/nic/otx2_txrx.c
> > index ef10aef3cda0..050be13dfa46 100644
> > --- a/drivers/net/ethernet/marvell/octeontx2/nic/otx2_txrx.c
> > +++ b/drivers/net/ethernet/marvell/octeontx2/nic/otx2_txrx.c
> > @@ -463,12 +463,14 @@ static int otx2_tx_napi_handler(struct otx2_nic
> *pfvf,
> >  			break;
> >  		}
> >
> > -		if (cq->cq_type =3D=3D CQ_XDP) {
> > +		qidx =3D cq->cq_idx - pfvf->hw.rx_queues;
> > +
> > +		if (cq->cq_type =3D=3D CQ_XDP)
> >  			otx2_xdp_snd_pkt_handler(pfvf, sq, cqe);
> > -		} else {
> > -			otx2_snd_pkt_handler(pfvf, cq, sq, cqe, budget,
> > -					     &tx_pkts, &tx_bytes);
> > -		}
> > +		else
> > +			otx2_snd_pkt_handler(pfvf, cq, &pfvf->qset.sq[qidx],
> > +					     cqe, budget, &tx_pkts, &tx_bytes);
> > +
> >
>=20
> nit: there are now two blank lines here
ACK, will fix in next version.

Thanks,
Hariprasad k
>=20
> >  		cqe->hdr.cqe_type =3D NIX_XQE_TYPE_INVALID;
> >  		processed_cqe++;