Feedback-ID: i8771445c:Fastmail
Date:   Mon, 13 Feb 2023 09:45:25 +0100
From:   Maxime Ripard <maxime@cerno.tech>
To:     Andreas Feldner <pelzi@flying-snail.de>
Cc:     Andre Przywara <andre.przywara@arm.com>,
        Linus Walleij <linus.walleij@linaro.org>,
        Chen-Yu Tsai <wens@csie.org>,
        Jernej Skrabec <jernej.skrabec@gmail.com>,
        Samuel Holland <samuel@sholland.org>,
        linux-gpio@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
        linux-sunxi@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] pinctrl: sunxi: set minimal debounce on
 input-debounce 0
Message-ID: <20230213084525.gr4urlvygsmonati@houat>
References: <Y+kuD+/v3+N1vwxR@debian-qemu.internal.flying-snail.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
In-Reply-To: <Y+kuD+/v3+N1vwxR@debian-qemu.internal.flying-snail.de>
Precedence: bulk

Hi,

On Sun, Feb 12, 2023 at 07:21:03PM +0100, Andreas Feldner wrote:
> sunxi-h3-h5 based boards have no support for switching
> off IRQ debouncing filter. This would be the expected
> behaviour of value 0 for the general pinctl parameter
> input-debounce.
> The current driver implementation ignores value 0
> for input-debounce, leaving the chip's default. This
> default, however, is not minimal, but equivalent to
> value 31 (microseconds).
>=20
> This patch does not ignore value 0 but instead makes
> sure the corresponding IRQ debounce filter is set
> to the shortest time selectable, i. e. the fast
> oscillator with a divider of 1 =3D=3D (2 ^ 0).
>=20
> Fixes: 7c926492d38a ("pinctrl: sunxi: Add support for interrupt debouncin=
g")
>=20
> Signed-off-by: Andreas Feldner <pelzi@flying-snail.de>

Like I said in the other thread, I don't think that deviating from the
generic property semantics is a good thing.

Maxime