Message-ID: <ec674bf1-95e6-a238-4a40-721f004a6161@nxp.com>
Date:   Mon, 13 Feb 2023 10:46:55 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.7.2
Subject: Re: [PATCH] serial: imx: remove a redundant check
To:     Tom Rix <trix@redhat.com>, gregkh@linuxfoundation.org,
        jirislaby@kernel.org, shawnguo@kernel.org, s.hauer@pengutronix.de,
        kernel@pengutronix.de, festevam@gmail.com, linux-imx@nxp.com
Cc:     linux-serial@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
        linux-kernel@vger.kernel.org
References: <20230211154550.2130670-1-trix@redhat.com>
Content-Language: en-US
From:   Iuliana Prodan <iuliana.prodan@nxp.com>
In-Reply-To: <20230211154550.2130670-1-trix@redhat.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ZUE1RC9EelNZM3VBc2ZPYUFsNFg4cWNKS1lvZS90MUZzQi9IMFFQWmJqNkda?=
 =?utf-8?B?WU1xdlpGU0JlVTdNNXlEZzVjUVhUN3MyeUU4NHdXdWRWY2pyOVdLWUNGYjR3?=
 =?utf-8?B?bnJpT0YvMnZSemZkMGRBRGtVOWh0Vk1uaVYvRU5LU2tKZUdiY2hJUEp5czZo?=
 =?utf-8?B?OE8vTXBKOFhEVCs5ejNlRllXVC9hSndoUVNRZFB4dEhORVkrUDlxMGs0RUdn?=
 =?utf-8?B?VWFwb1JDc3pnZlpwSVFJbTdRdXZsVmtXNFZGNGMvcVdNWU9qY0JqUDF3Y20v?=
 =?utf-8?B?OXJmMVdUYU5ZemFZcGNIZzJTRWJhWXRrNGVEcVF4WUNSYkhZYmczdlJwYTh4?=
 =?utf-8?B?bzFaMjhORTU4TkVXUndEbWxPdHFmc25RdDFIZ0FSVHdmc1hLZ0hZVkN3TUdK?=
 =?utf-8?B?ZmFXUEx4T0dwOUNSRUZxTFN3QzNqSkJ6RmhkU1hBSkx6R1VlNld0dUF2Zzh0?=
 =?utf-8?B?cUkzZC9qQkhRSUxaVk5rdHFTRTJjclhPM20vTlhUUTlMZHlwOUxVSFJIZk8w?=
 =?utf-8?B?MmxxM1lZUERBN2ZONENLRWlZTEZVQkhpR29FRHc0ZGFoV2VKTVdaYkMzVWpm?=
 =?utf-8?B?SGRtSW5mMTcwd1ZLN040Mm5xS2tndTRQNW9SNWkwZm1yZFkvQ2hXaXl1MHRo?=
 =?utf-8?B?UkQxK002ZE1JZ2V2N1JRZUZFWTlwNW0xcDNSeW4vZURuK3llRFlhRjUwTjZv?=
 =?utf-8?B?aFErTEhoYXVValhOanVHd01TZFpFNFI0LzZlU1lGRGt3TjZIN3M3alAwUTFy?=
 =?utf-8?B?UGdNUWh5bUxYRndNMkpYSmxzaXc5SmlLdWc5ajdteHNGd1JSdlhOR0VpRTBq?=
 =?utf-8?B?enZReG1zNXkrKzdEdVRGOTJXNkIxaVkvR1JxZFNjY3ptZ0xxM1lReGVoYi9F?=
 =?utf-8?B?MjJWWnhRQnlRY1k5TFJxRFR2cS9wdmlmMnlFL01jMVFQZDFzTVNOM2xKOWxz?=
 =?utf-8?B?b1ByV1NaRktkcFNDNzhwSXpGYTVKYjZicWxVNkx6SzRDSkdSTTJZWndzNUhJ?=
 =?utf-8?B?b21HdHN1dXlWMFUzMEVQcEx0c3lTRGQzRXF2QnNlV3NPTG9KTEZhc1FIWlQy?=
 =?utf-8?B?aWJ4b2lRUjQ0eE9UNExSOTUyVnRMVm1yaXE0RUR6T0FuY1FSZVhqT3N3VkFw?=
 =?utf-8?B?N1Jpamlzd0dzWDVXdWFYTEUxT016aS9VQ0RodzZjQXkwTWZERDlNOHBnYkZT?=
 =?utf-8?B?OGEzWVZnejMwSy96TndpMzcybkpRWFlHaEtzTlhoSDZaUStxVVEyRWRwU0V6?=
 =?utf-8?B?NFBDYzJZcUxTa3k2VGdvQWxBTm1JbjJFTUZWeTArdDBpWEhBQ05RR2Z2M09B?=
 =?utf-8?B?UUdGTFVaTndZRmhhbGtVaStvcmYxRzBXSkZITmtGT2FEdm5zNjBEd3FnMzRP?=
 =?utf-8?B?NGV4K09pUzV3anlLaFlPNU81ZVpWaWNIYW1BM1JmZVo0aTNGS2tyOHdVdUFa?=
 =?utf-8?B?Q1dYMXRhTjUzNFJPT1pVS1FMWG52UUxVb0YzT2x1OXVPS1dwWE5PSGdRMGln?=
 =?utf-8?B?SXllbElHLzdJTFQxQ0VBUW9tQXdzeGdQQnpXWVNCdHo5NmUwY3RQS2VCNjJW?=
 =?utf-8?B?eUNscWdsY093S2JKSkFLZG4rOE43NXBqVW14UG5YNmU0ZHl2RE9VRkRVclA1?=
 =?utf-8?B?aDZKYmNVOFdvUkREMzhBdVE5S0U4ZmtkR1lZYkduTHRpeHpwTjhhZnJVSU1o?=
 =?utf-8?B?ejNpcUdQS01OU3VHczg1SUxqZHVpYTFrNTllSVJiKzc0bmY0VkN4TzA5VjlF?=
 =?utf-8?B?cDZlaFg5TzVYVjhSYVJIclB5S25HRk5UajV4eWFGalhGQVFzeDZVZ2dIY3l5?=
 =?utf-8?B?b0NOZXorTGFGZUNTN05rTWtzb2p2cWJGQmlvRm40c21uaUN4RmhzV3FRb0li?=
 =?utf-8?B?N2tLcXBsT2d5dXFjMXBTYWZvWGtHVGEvY0hrbkxlbWlZSmd3a2F6U05KS3lT?=
 =?utf-8?B?UjNzZmlLeXVCL3AzdkdXamNjTXA0TDdCZnNqYlhHdWt1WDVhRVRNTkY4cHd6?=
 =?utf-8?B?Q0JPVU1CaCtHNnJpSStyUC9XUE5FVzh0T1lQWStySUlKdThJRmw2K1NYWTF2?=
 =?utf-8?B?V2tOQjJpUHVnNlJwTUlDNFUrdnpFR01oVGEyL2hsVVhxb2JCZk8zdUxCV1hI?=
 =?utf-8?B?bC9FcnN3NEFtS0t3Rm5kQnNocGV0Z1A3RWJleFJZUEYwaE5UZmRyS1NSbVlk?=
 =?utf-8?B?Q0E9PQ==?=
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 8fa05b8e-9b70-4b1f-4f25-08db0d9f0665
X-MS-Exchange-CrossTenant-AuthSource: DB9PR04MB9628.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Feb 2023 08:48:06.2570
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: hXORZ1aiX0QqS8mMb4Q7gV5b5ddPPhEgEwPWT7dbTtUlwyzMRBSDdlREWwu2l6qfMYpNQ4Mtsx7gFYjkrGGm5w==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR04MB9093
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 2/11/2023 5:45 PM, Tom Rix wrote:
> cpp_check reports
> drivers/tty/serial/imx.c:1207:15: style: Condition 'r_bytes>0' is always true [knownConditionTrueFalse]
>    if (r_bytes > 0) {
>
> r_byte is set to
>    r_bytes = rx_ring->head - rx_ring->tail;
>
> The head - tail calculation is also done by the earlier check
>    if (rx_ring->head <= sg_dma_len(sgl) &&
>        rx_ring->head > rx_ring->tail) {
>
> so r_bytes will always be > 0, so the second check is not needed.
>
> Signed-off-by: Tom Rix <trix@redhat.com>

Reviewed-by: Iuliana Prodan <iuliana.prodan@nxp.com>

> ---
>   drivers/tty/serial/imx.c | 8 +++-----
>   1 file changed, 3 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/tty/serial/imx.c b/drivers/tty/serial/imx.c
> index 363c77a140f0..523f296d5747 100644
> --- a/drivers/tty/serial/imx.c
> +++ b/drivers/tty/serial/imx.c
> @@ -1204,11 +1204,9 @@ static void imx_uart_dma_rx_callback(void *data)
>   		r_bytes = rx_ring->head - rx_ring->tail;
>   
>   		/* If we received something, check for 0xff flood */
> -		if (r_bytes > 0) {
> -			spin_lock(&sport->port.lock);
> -			imx_uart_check_flood(sport, imx_uart_readl(sport, USR2));
> -			spin_unlock(&sport->port.lock);
> -		}
> +		spin_lock(&sport->port.lock);
> +		imx_uart_check_flood(sport, imx_uart_readl(sport, USR2));
> +		spin_unlock(&sport->port.lock);
>   
>   		if (!(sport->port.ignore_status_mask & URXD_DUMMY_READ)) {
>