Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1F31EC636D7 for ; Mon, 13 Feb 2023 09:08:41 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229869AbjBMJIj (ORCPT ); Mon, 13 Feb 2023 04:08:39 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37456 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229472AbjBMJIg (ORCPT ); Mon, 13 Feb 2023 04:08:36 -0500 Received: from formenos.hmeau.com (167-179-156-38.a7b39c.syd.nbn.aussiebb.net [167.179.156.38]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3DDAF1206F; Mon, 13 Feb 2023 01:08:35 -0800 (PST) Received: from loth.rohan.me.apana.org.au ([192.168.167.2]) by formenos.hmeau.com with smtp (Exim 4.94.2 #2 (Debian)) id 1pRUoP-00AWqI-Sv; Mon, 13 Feb 2023 17:07:50 +0800 Received: by loth.rohan.me.apana.org.au (sSMTP sendmail emulation); Mon, 13 Feb 2023 17:07:49 +0800 Date: Mon, 13 Feb 2023 17:07:49 +0800 From: Herbert Xu To: Linus Torvalds Cc: luto@kernel.org, david@fromorbit.com, willy@infradead.org, metze@samba.org, axboe@kernel.dk, linux-fsdevel@vger.kernel.org, linux-api@vger.kernel.org, io-uring@vger.kernel.org, linux-kernel@vger.kernel.org, viro@zeniv.linux.org.uk, samba-technical@lists.samba.org Subject: Re: copy on write for splice() from file to pipe? Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Newsgroups: apana.lists.os.linux.kernel Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Linus Torvalds wrote: > > - if (!(sk->sk_route_caps & NETIF_F_SG)) > + if (!(sk->sk_route_caps & NETIF_F_SG) || > + !(sk->sk_route_caps & (NETIF_F_HW_CSUM | NETIF_F_IP_CSUM))) > return sock_no_sendpage_locked(sk, page, offset, size, flags); NETIF_F_SG depends on checksum offload so it should already be calling sock_no_sendpage_locked if checksum offload is not supported. Cheers, -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt