Message-ID: <0000e9d1-7876-0830-4ec3-dadc69f8c54d@linaro.org>
Date:   Mon, 13 Feb 2023 10:16:49 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.7.1
Subject: Re: [PATCH v5 04/12] dt-bindings: arm: mediatek: sgmiisys: add MT7981
 SoC
Content-Language: en-US
To:     Daniel Golle <daniel@makrotopia.org>, devicetree@vger.kernel.org,
        Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        netdev@vger.kernel.org, linux-mediatek@lists.infradead.org,
        linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org,
        Russell King <linux@armlinux.org.uk>,
        Heiner Kallweit <hkallweit1@gmail.com>,
        Lorenzo Bianconi <lorenzo@kernel.org>,
        Mark Lee <Mark-MC.Lee@mediatek.com>,
        John Crispin <john@phrozen.org>, Felix Fietkau <nbd@nbd.name>,
        AngeloGioacchino Del Regno 
        <angelogioacchino.delregno@collabora.com>,
        Matthias Brugger <matthias.bgg@gmail.com>,
        DENG Qingfang <dqfext@gmail.com>,
        Landen Chao <Landen.Chao@mediatek.com>,
        Sean Wang <sean.wang@mediatek.com>,
        Paolo Abeni <pabeni@redhat.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Eric Dumazet <edumazet@google.com>,
        "David S. Miller" <davem@davemloft.net>,
        Vladimir Oltean <olteanv@gmail.com>,
        Florian Fainelli <f.fainelli@gmail.com>,
        Andrew Lunn <andrew@lunn.ch>
Cc:     Jianhui Zhao <zhaojh329@gmail.com>,
        =?UTF-8?Q?Bj=c3=b8rn_Mork?= <bjorn@mork.no>
References: <cover.1676128246.git.daniel@makrotopia.org>
 <7273678366079b93ee19c4c6f6ea9bc13cd8dcfb.1676128246.git.daniel@makrotopia.org>
From:   Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
In-Reply-To: <7273678366079b93ee19c4c6f6ea9bc13cd8dcfb.1676128246.git.daniel@makrotopia.org>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 11/02/2023 17:02, Daniel Golle wrote:
> Add mediatek,pnswap boolean property as well as an example for the
> MediaTek MT7981 SoC making use of that new property.
> 
> Signed-off-by: Daniel Golle <daniel@makrotopia.org>
> ---
>  .../arm/mediatek/mediatek,sgmiisys.yaml       | 22 +++++++++++++++++++
>  1 file changed, 22 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/arm/mediatek/mediatek,sgmiisys.yaml b/Documentation/devicetree/bindings/arm/mediatek/mediatek,sgmiisys.yaml
> index 99ceb08ad7c0..97d4ab70e541 100644
> --- a/Documentation/devicetree/bindings/arm/mediatek/mediatek,sgmiisys.yaml
> +++ b/Documentation/devicetree/bindings/arm/mediatek/mediatek,sgmiisys.yaml
> @@ -23,6 +23,8 @@ properties:
>            - enum:
>                - mediatek,mt7622-sgmiisys
>                - mediatek,mt7629-sgmiisys
> +              - mediatek,mt7981-sgmiisys_0
> +              - mediatek,mt7981-sgmiisys_1
>                - mediatek,mt7986-sgmiisys_0
>                - mediatek,mt7986-sgmiisys_1
>            - const: syscon
> @@ -33,6 +35,10 @@ properties:
>    '#clock-cells':
>      const: 1
>  
> +  mediatek,pnswap:
> +    description: Invert polarity of the SGMII data lanes
> +    type: boolean
> +
>  required:
>    - compatible
>    - reg
> @@ -51,3 +57,19 @@ examples:
>          #clock-cells = <1>;
>        };
>      };
> +  - |
> +    soc {
> +      #address-cells = <2>;
> +      #size-cells = <2>;
> +      sgmiisys0: syscon@10060000 {
> +        compatible = "mediatek,mt7981-sgmiisys_0", "syscon";
> +        reg = <0 0x10060000 0 0x1000>;
> +        mediatek,pnswap;

No really need for three almost the same nodes. Just choose one - with
or without pnswap.

Best regards,
Krzysztof