Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 01902C636CC for ; Mon, 13 Feb 2023 09:38:05 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230493AbjBMJiE convert rfc822-to-8bit (ORCPT ); Mon, 13 Feb 2023 04:38:04 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43990 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230433AbjBMJho (ORCPT ); Mon, 13 Feb 2023 04:37:44 -0500 Received: from rtits2.realtek.com.tw (rtits2.realtek.com [211.75.126.72]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D6320EC71; Mon, 13 Feb 2023 01:37:40 -0800 (PST) Authenticated-By: X-SpamFilter-By: ArmorX SpamTrap 5.77 with qID 31D9b5UQ1001113, This message is accepted by code: ctloc85258 Received: from mail.realtek.com (rtexh36505.realtek.com.tw[172.21.6.25]) by rtits2.realtek.com.tw (8.15.2/2.81/5.90) with ESMTPS id 31D9b5UQ1001113 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=OK); Mon, 13 Feb 2023 17:37:05 +0800 Received: from RTEXDAG01.realtek.com.tw (172.21.6.100) by RTEXH36505.realtek.com.tw (172.21.6.25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.32; Mon, 13 Feb 2023 17:37:06 +0800 Received: from RTEXMBS04.realtek.com.tw (172.21.6.97) by RTEXDAG01.realtek.com.tw (172.21.6.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.7; Mon, 13 Feb 2023 17:37:05 +0800 Received: from RTEXMBS04.realtek.com.tw ([fe80::b4a2:2bcc:48d1:8b02]) by RTEXMBS04.realtek.com.tw ([fe80::b4a2:2bcc:48d1:8b02%5]) with mapi id 15.01.2375.007; Mon, 13 Feb 2023 17:37:05 +0800 From: Ping-Ke Shih To: Lu jicong , "kvalo@kernel.org" , "davem@davemloft.net" , "edumazet@google.com" , "kuba@kernel.org" , "pabeni@redhat.com" CC: "quic_srirrama@quicinc.com" , "johannes.berg@intel.com" , "linux-wireless@vger.kernel.org" , "netdev@vger.kernel.org" , "linux-kernel@vger.kernel.org" Subject: RE: [PATCH] rtlwifi: rtl8192ce: fix dealing empty eeprom values Thread-Topic: [PATCH] rtlwifi: rtl8192ce: fix dealing empty eeprom values Thread-Index: AQHZPtpzAGnnaWohP069MdtRfPTR/q7Mm0ug Date: Mon, 13 Feb 2023 09:37:05 +0000 Message-ID: References: <20230212120610.2026291-1-jiconglu58@gmail.com> In-Reply-To: <20230212120610.2026291-1-jiconglu58@gmail.com> Accept-Language: en-US, zh-TW Content-Language: zh-TW X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [172.21.69.188] x-kse-serverinfo: RTEXDAG01.realtek.com.tw, 9 x-kse-antispam-interceptor-info: fallback x-kse-antivirus-interceptor-info: fallback Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 X-KSE-AntiSpam-Interceptor-Info: fallback X-KSE-ServerInfo: RTEXH36505.realtek.com.tw, 9 X-KSE-AntiSpam-Interceptor-Info: fallback X-KSE-Antivirus-Interceptor-Info: fallback X-KSE-AntiSpam-Interceptor-Info: fallback Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > -----Original Message----- > From: Lu jicong > Sent: Sunday, February 12, 2023 8:06 PM > To: Ping-Ke Shih ; kvalo@kernel.org; davem@davemloft.net; edumazet@google.com; > kuba@kernel.org; pabeni@redhat.com > Cc: quic_srirrama@quicinc.com; jiconglu58@gmail.com; johannes.berg@intel.com; > linux-wireless@vger.kernel.org; netdev@vger.kernel.org; linux-kernel@vger.kernel.org > Subject: [PATCH] rtlwifi: rtl8192ce: fix dealing empty eeprom values > > In some cases, eeprom is empty or partly empty. This looks weird to me. Why does hardware could be programmed improper eeprom? Where do you get the hardware? Can I have a picture of this module privately? I think we only need to support MP hardware. > Load default values when the eeprom values are empty to avoid problems. > > Signed-off-by: Lu jicong > --- > .../wireless/realtek/rtlwifi/rtl8192ce/hw.c | 31 +++++++++++++------ > 1 file changed, 21 insertions(+), 10 deletions(-) > > diff --git a/drivers/net/wireless/realtek/rtlwifi/rtl8192ce/hw.c > b/drivers/net/wireless/realtek/rtlwifi/rtl8192ce/hw.c > index b9c62640d2cb..8ddf0017af4c 100644 > --- a/drivers/net/wireless/realtek/rtlwifi/rtl8192ce/hw.c > +++ b/drivers/net/wireless/realtek/rtlwifi/rtl8192ce/hw.c > @@ -1428,7 +1428,9 @@ static void _rtl92ce_read_txpower_info_from_hwpg(struct ieee80211_hw *hw, > > for (rf_path = 0; rf_path < 2; rf_path++) { > for (i = 0; i < 3; i++) { > - if (!autoload_fail) { > + if (!autoload_fail && > + hwinfo[EEPROM_TXPOWERCCK + rf_path * 3 + i] != 0xff && > + hwinfo[EEPROM_TXPOWERHT40_1S + rf_path * 3 + i] != 0xff) { > rtlefuse-> > eeprom_chnlarea_txpwr_cck[rf_path][i] = > hwinfo[EEPROM_TXPOWERCCK + rf_path * 3 + i]; > @@ -1448,7 +1450,8 @@ static void _rtl92ce_read_txpower_info_from_hwpg(struct ieee80211_hw *hw, > } > > for (i = 0; i < 3; i++) { > - if (!autoload_fail) > + if (!autoload_fail && > + hwinfo[EEPROM_TXPOWERHT40_2SDIFF + i] != 0xff) > tempval = hwinfo[EEPROM_TXPOWERHT40_2SDIFF + i]; > else > tempval = EEPROM_DEFAULT_HT40_2SDIFF; > @@ -1518,7 +1521,9 @@ static void _rtl92ce_read_txpower_info_from_hwpg(struct ieee80211_hw *hw, > } > > for (i = 0; i < 3; i++) { > - if (!autoload_fail) { > + if (!autoload_fail && > + hwinfo[EEPROM_TXPWR_GROUP + i] != 0xff && > + hwinfo[EEPROM_TXPWR_GROUP + 3 + i] != 0xff) { > rtlefuse->eeprom_pwrlimit_ht40[i] = > hwinfo[EEPROM_TXPWR_GROUP + i]; > rtlefuse->eeprom_pwrlimit_ht20[i] = > @@ -1563,7 +1568,8 @@ static void _rtl92ce_read_txpower_info_from_hwpg(struct ieee80211_hw *hw, > for (i = 0; i < 14; i++) { > index = rtl92c_get_chnl_group((u8)i); > > - if (!autoload_fail) > + if (!autoload_fail && > + hwinfo[EEPROM_TXPOWERHT20DIFF + index] != 0xff) > tempval = hwinfo[EEPROM_TXPOWERHT20DIFF + index]; > else > tempval = EEPROM_DEFAULT_HT20_DIFF; > @@ -1580,7 +1586,8 @@ static void _rtl92ce_read_txpower_info_from_hwpg(struct ieee80211_hw *hw, > > index = rtl92c_get_chnl_group((u8)i); > > - if (!autoload_fail) > + if (!autoload_fail && > + hwinfo[EEPROM_TXPOWER_OFDMDIFF + index] != 0xff) > tempval = hwinfo[EEPROM_TXPOWER_OFDMDIFF + index]; > else > tempval = EEPROM_DEFAULT_LEGACYHTTXPOWERDIFF; > @@ -1610,14 +1617,16 @@ static void _rtl92ce_read_txpower_info_from_hwpg(struct ieee80211_hw *hw, > "RF-B Legacy to HT40 Diff[%d] = 0x%x\n", > i, rtlefuse->txpwr_legacyhtdiff[RF90_PATH_B][i]); > > - if (!autoload_fail) > + if (!autoload_fail && hwinfo[RF_OPTION1] != 0xff) > rtlefuse->eeprom_regulatory = (hwinfo[RF_OPTION1] & 0x7); > else > rtlefuse->eeprom_regulatory = 0; > RTPRINT(rtlpriv, FINIT, INIT_TXPOWER, > "eeprom_regulatory = 0x%x\n", rtlefuse->eeprom_regulatory); > > - if (!autoload_fail) { > + if (!autoload_fail && > + hwinfo[EEPROM_TSSI_A] != 0xff && > + hwinfo[EEPROM_TSSI_B] != 0xff) { > rtlefuse->eeprom_tssi[RF90_PATH_A] = hwinfo[EEPROM_TSSI_A]; > rtlefuse->eeprom_tssi[RF90_PATH_B] = hwinfo[EEPROM_TSSI_B]; > } else { > @@ -1628,7 +1637,7 @@ static void _rtl92ce_read_txpower_info_from_hwpg(struct ieee80211_hw *hw, > rtlefuse->eeprom_tssi[RF90_PATH_A], > rtlefuse->eeprom_tssi[RF90_PATH_B]); > > - if (!autoload_fail) > + if (!autoload_fail && hwinfo[EEPROM_THERMAL_METER] != 0xff) > tempval = hwinfo[EEPROM_THERMAL_METER]; > else > tempval = EEPROM_DEFAULT_THERMALMETER; > -- > 2.30.2