Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id BD054C636D7 for ; Mon, 13 Feb 2023 10:17:24 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230039AbjBMKRX (ORCPT ); Mon, 13 Feb 2023 05:17:23 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51458 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229940AbjBMKRV (ORCPT ); Mon, 13 Feb 2023 05:17:21 -0500 Received: from mail-yw1-x1133.google.com (mail-yw1-x1133.google.com [IPv6:2607:f8b0:4864:20::1133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6826E2134 for ; Mon, 13 Feb 2023 02:17:19 -0800 (PST) Received: by mail-yw1-x1133.google.com with SMTP id 00721157ae682-5258f66721bso156680067b3.1 for ; Mon, 13 Feb 2023 02:17:19 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=B/9LKJBt/uFWrt2eaPCZXoPKu9jtJqzqiT0yu2iiXgA=; b=OM2Q7Dz3LTR45PgX0M0nt7MxrcR2SsThReuPjqCBzPxd5c4QunEGEjp/DRduZE3xIn XPbEDm5u9h1ISmC3kXacdxf48PBPMYor6N97cjwrle9+odF9Upg5zlGqwyUV9xGl8DFK GA2bKWRD3tAs1RscJKxKKAO6PkP5+MyxizdbL9PCPCiD0i94tLKhkM88lUi7qNXuQkg+ 8oDO4qdXBEl2mkBfPrnLjFaR1/GBvFw9F5ZbBD/l0TpN549fZH9XbzytNOFJd6XE8VuA Va6XjRrqIXwANHdCOdRNtMe0szAiHpQ6YEazgheQEgq2JMEkIFDR6zmnfInMNNqX/C2s ivEg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=B/9LKJBt/uFWrt2eaPCZXoPKu9jtJqzqiT0yu2iiXgA=; b=eGWb6ovQEN0Hvo3Da+Mkq93pOUqqKhHtaUHyl+zojd11yle2NYQx6+J+AG5k70I9Sb tzwk0jL4pxNJcixEW3Inn4F7MoKjXOym29eZA1NfqJwuN2C5iVA32xmdF1rvZyPEypdi XqWi2LkRhBNWznNVK0ooB/ul/0iIN4pdegTVYnWrRG0hi+a1VVwhKJNejA54SL5UZcC7 sjwBUTANHxhrjbuBz7G8V+f4gkopGiZReKZY4PPub/nj6s6aFEqIyNTMnjF0bnGOGwCT q++cnWqTqE870XzLFLUCPhKz/C8mc80kyYSUnK4WVfcGaCbKJNGCLcpu2XceQyKmsyth fwxg== X-Gm-Message-State: AO0yUKXRqFaN2jcRPbDcwKU5HKHgHpxTDHG0KIIHQv/h9Q0Je3ieq4GU yGnVZWZXMT5gkxak9wwoHS3hA5VdQyjRfTCkcnr7Pb1qmQJg+Q== X-Google-Smtp-Source: AK7set+LOXZf9z2fNtm1MlC7Tu7YYgsXp5XaxlLDCioWXk45a/E7fhy5d6++PstBOHEi2eCQ0PxXdO+s20DwzyhcA3o= X-Received: by 2002:a0d:db96:0:b0:52e:c7a1:7439 with SMTP id d144-20020a0ddb96000000b0052ec7a17439mr1206379ywe.384.1676283438656; Mon, 13 Feb 2023 02:17:18 -0800 (PST) MIME-Version: 1.0 References: <20230210150319.200799-1-asmaa@nvidia.com> <20230210150319.200799-2-asmaa@nvidia.com> In-Reply-To: <20230210150319.200799-2-asmaa@nvidia.com> From: Linus Walleij Date: Mon, 13 Feb 2023 11:17:07 +0100 Message-ID: Subject: Re: [PATCH v3 1/2] Support NVIDIA BlueField-3 GPIO controller To: Asmaa Mnebhi Cc: linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, andy.shevchenko@gmail.com, bgolaszewski@baylibre.com, linux-acpi@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Feb 10, 2023 at 4:03 PM Asmaa Mnebhi wrote: > This patch adds support for the BlueField-3 SoC GPIO driver > which allows: > - setting certain GPIOs as interrupts from other dependent drivers > - ability to manipulate certain GPIO pins via libgpiod tools > > BlueField-3 has 56 GPIOs but the user is only allowed to change some > of them into GPIO mode. Use valid_mask to make it impossible to alter > the rest of the GPIOs. > > Signed-off-by: Asmaa Mnebhi Excellent work Asmaa, Reviewed-by: Linus Walleij Yours, Linus Walleij